Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baggage activity processor - key predicate #1695

Closed
MikeGoldsmith opened this issue Apr 25, 2024 · 1 comment · Fixed by #1816
Closed

Baggage activity processor - key predicate #1695

MikeGoldsmith opened this issue Apr 25, 2024 · 1 comment · Fixed by #1816
Labels
comp:extensions Things related to OpenTelemetry.Extensions

Comments

@MikeGoldsmith
Copy link
Member

          I'd prefer if we had a constructor that allowed the user to add a prefix for baggage items that they'd like to add as attributes. We've had situations where customers have used a similar approach and managed to receive data from externally propagated baggage (accidentally).

A pattern like adding a prefix would mean that it becomes a lot more intentional, and therefore just a little safer.

Originally posted by @martinjt in #1659 (comment)

@MikeGoldsmith
Copy link
Member Author

Another suggestion from the JS contrib project is to allow a user-provided predicate function. This puts the responsibility on the user to ensure sensitive baggage keys are not copied while also not prescribing how that is determined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:extensions Things related to OpenTelemetry.Extensions
Projects
None yet
2 participants