Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log the ports that jaegerreceiver listens to #6412

Open
yurishkuro opened this issue Dec 25, 2024 · 0 comments · May be fixed by open-telemetry/opentelemetry-collector-contrib#36961
Open

Log the ports that jaegerreceiver listens to #6412

yurishkuro opened this issue Dec 25, 2024 · 0 comments · May be fixed by open-telemetry/opentelemetry-collector-contrib#36961
Labels
area/otel enhancement good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member

yurishkuro commented Dec 25, 2024

The implementation for this issue is actually in the OTEL/contrib/jaegerreceiver module. By convention Jaeger internal extensions try to log which ports / endpoints they are listening when creating the servers, e.g.:

  • Serving metrics {"address": "localhost:8888", "metrics level": "Detailed"}
  • Query server started {"kind": "extension", "name": "jaeger_query", "http_addr": "[::]:16686", "grpc_addr": "[::]:16685"}
  • Starting GRPC server {"kind": "extension", "name": "jaeger_query", "port": 16685, "addr": ":16685"}
  • Starting HTTP server {"kind": "extension", "name": "jaeger_query", "port": 16686, "addr": ":16686"}

(side note: the log from Query server should be split into two lines)

However, the jaegerreceiver that we're importing from OTEL/contrib is not logging any of the ports / endpoints, even though in all-in-one configuratiob we enable all four:

      grpc:
        endpoint: "${env:JAEGER_LISTEN_HOST:-localhost}:14250"
      thrift_http:
        endpoint: "${env:JAEGER_LISTEN_HOST:-localhost}:14268"
      thrift_binary:
        endpoint: "${env:JAEGER_LISTEN_HOST:-localhost}:6832"
      thrift_compact:
        endpoint: "${env:JAEGER_LISTEN_HOST:-localhost}:6831"

The goal is to make changes upstream to log a similar "Server started" log for each port that jaegerreceiver is listening to. For the reference of how it's done we can look at OTLP receiver that does log its endpoints:

  • Starting GRPC server {"kind": "receiver", "name": "otlp", "data_type": "traces", "endpoint": "localhost:4317"}
  • Starting HTTP server {"kind": "receiver", "name": "otlp", "data_type": "traces", "endpoint": "localhost:4318"}
@yurishkuro yurishkuro added good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement labels Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/otel enhancement good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
1 participant