Improve

Author: vanous

fixture.py

@@ -883,9 +883,14 @@ def process_channels(self, dmx_mode_channels, channels):
                 ):
                     new_channel["cached_channels"][str(dmx_channel.dmx_break)] = {}
                 for ch_of in new_channel.offsets:
-                    new_channel["cached_channels"][str(dmx_channel.dmx_break)][
-                        str(ch_of)
-                    ] = None
+                    if ch_of > 0:
+                        new_channel["cached_channels"][str(dmx_channel.dmx_break)][
+                            str(ch_of)
+                        ] = None
+                        # channel offsets are not good, we will need channel node and store final value
+                        # together with attribute, physical value and slot index value
+                        # this is needed because many channels operate together (pan+tilt, r+g+b,...)
+                        print("adding channel to cached", ch_of)
 
             else:
                 # virtual channels are 8 bit now
@@ -1282,12 +1287,11 @@ def render(self, skip_cache=False, current_frame=None):
             # check if channel or other mode dependent channels are the same as in the cache
             for cached_break, cached_channels in channel["cached_channels"].items():
                 for cached_channel in cached_channels.keys():
-                    print("channel", cached_channel, cached_break)
                     store_val = dmx_data[int(cached_break)].get(
                         int(cached_channel), None
                     )
                     print(
-                        f"{channel.attribute}: {store_val=} {cached_channels[cached_channel]=}"
+                        f"{channel.attribute}: {store_val=} {cached_channels[cached_channel]=} {cached_channel=}"
                     )
                     if store_val != cached_channels[cached_channel]:
                         channel_cached_already = False
@@ -1851,6 +1855,7 @@ def updateRGB(
         if geometry is not None:
             geometry = geometry.replace(" ", "_")
         DMX_Log.log.info(("color change for geometry", geometry, colors))
+        print("colors", colors)
         colors = [
             c if c is not None else 0 for c in colors
         ]  # replace None with 0, can happen if someone maps colors across geometries...