Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode missing #347

Closed
1 task
ricardo-reis-1970 opened this issue Oct 22, 2024 · 1 comment
Closed
1 task

Dark mode missing #347

ricardo-reis-1970 opened this issue Oct 22, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@ricardo-reis-1970
Copy link

Problem

As a visually impaired user, I would very much like to have a dark mode option. For people like me, this new trend of "whitewashing" backgrounds is physically offensive (as in painful), not to mention that it prevents actually seeing whatever.

My whole Chrome Dev Tools is in dark mode and all other extensions are just happy to comply. If this could follow suit, that would be great.

I tried getting into the many scss files but this approach feels hacky and wrong.

Solution

I think a good solution would be either to inherit from the default Dev Tools style, or to make available an alternate style sheet configured for dark mode. This could be in an alternate branch (requiring rebuild / reapply config edits, etc.) or an extension slider / button / checkbox feature.

Additional information

No response

👨‍👧‍👦 Contributing

  • 🙋‍♂️ Yes, I'd love to make a PR to implement this feature!
@ricardo-reis-1970 ricardo-reis-1970 added the enhancement New feature or request label Oct 22, 2024
@garrettlchow
Copy link
Contributor

Great news! As of Reactime 26.0, we've added full dark mode support to address exactly this accessibility concern. The extension now automatically syncs with your Chrome DevTools theme preferences.

To ensure you're using the version with dark mode:

  1. Make sure you have the latest version of Reactime from the Chrome Web Store
  2. Your Chrome DevTools should be in dark mode (Settings → Preferences → Theme → Dark)
  3. Reactime will automatically match your DevTools theme

Thank you for bringing up this important accessibility issue. Making Reactime accessible to all users is a priority for us. If you experience any issues with the dark mode implementation or have other accessibility suggestions, please don't hesitate to let us know.

Closing as implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants