Skip to content

Commit 84c9a3a

Browse files
committed
Use selenium-firefox docker image version 2.53.1
Also remove PROFILE env var in .travis.yml to prevent assumption that changing its value to `firefox` will work (it won't if version remain 3). Also add moodle dir mount to selenium container to allow running file upload tests.
1 parent 0b2090b commit 84c9a3a

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

.travis.dist.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ before_install:
3232
- cd ../..
3333
- composer create-project -n --no-dev --prefer-dist blackboard-open-source/moodle-plugin-ci ci ^2
3434
- export PATH="$(cd ci/bin; pwd):$(cd ci/vendor/bin; pwd):$PATH"
35-
- docker run -d -p 127.0.0.1:4444:4444 --net=host -v /dev/shm:/dev/shm selenium/standalone-firefox:3
35+
- docker run -d -p 127.0.0.1:4444:4444 --net=host -v /dev/shm:/dev/shm -v $HOME/build/moodle:$HOME/build/moodle selenium/standalone-firefox:2.53.1
3636

3737
install:
3838
- moodle-plugin-ci install

.travis.yml

+3-4
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,14 @@ env:
2323
- MUSTACHE_IGNORE_NAMES=broken.mustache
2424
- DB=pgsql
2525
- MOODLE_BRANCH=master
26-
- PROFILE=chrome
2726

2827
install:
2928
- phpenv config-rm xdebug.ini
3029
- nvm install 8.9
3130
- nvm use 8.9
3231
- make init
33-
# Start Selenium Standalone with Chrome/Firefox installed.
34-
- docker run -d -p 127.0.0.1:4444:4444 --net=host -v /dev/shm:/dev/shm selenium/standalone-${PROFILE}:3
32+
# Start Selenium Standalone with Chrome.
33+
- docker run -d -p 127.0.0.1:4444:4444 --net=host -v /dev/shm:/dev/shm -v $HOME/build/moodle:$HOME/build/moodle selenium/standalone-chrome:3
3534
# Mimic how a Moodle plugin would be run.
3635
- cp -R tests/Fixture/moodle-local_travis ../moodle-local_travis
3736
- export PATH="$(cd bin; pwd):$(cd vendor/bin; pwd):$PATH"
@@ -54,7 +53,7 @@ script:
5453
- moodle-plugin-ci grunt || [ "$MOODLE_BRANCH" != 'master' -a "$MOODLE_BRANCH" != 'MOODLE_38_STABLE' ]
5554
- moodle-plugin-ci phpdoc
5655
- moodle-plugin-ci phpunit --coverage-text
57-
- moodle-plugin-ci behat --profile $PROFILE
56+
- moodle-plugin-ci behat --profile chrome
5857

5958
jobs:
6059
include:

docs/TravisFileExplained.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ before_install:
6969
# Start Selenium Standalone server with Chrome/Firefox installed. If you
7070
# prefer to run Behat tests with Chrome profile (see Behat step details below),
7171
# use selenium/standalone-chrome:3 image instead.
72-
- docker run -d -p 127.0.0.1:4444:4444 --net=host -v /dev/shm:/dev/shm selenium/standalone-firefox:3
72+
- docker run -d -p 127.0.0.1:4444:4444 --net=host -v /dev/shm:/dev/shm -v $HOME/build/moodle:$HOME/build/moodle selenium/standalone-firefox:2.53.1
7373

7474
# This lists steps that are run for installation and setup.
7575
install:

0 commit comments

Comments
 (0)