INT-17886: Fix code checker 3.1.0

Author: OscarNadjar

backup/moodle2/backup_collaborate_activity_task.class.php

@@ -54,7 +54,7 @@ protected function define_my_steps() {
      * @param string $content some HTML text that eventually contains URLs to the activity instance scripts
      * @return string the content with the URLs encoded
      */
-    static public function encode_content_links($content) {
+    public static function encode_content_links($content) {
         global $CFG;
 
         $base = preg_quote($CFG->wwwroot, '/');

backup/moodle2/backup_collaborate_stepslib.php

@@ -22,8 +22,6 @@
  * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * Define the complete collaborate structure for backup, with file and id annotations
  *

backup/moodle2/restore_collaborate_activity_task.class.php

@@ -56,7 +56,7 @@ protected function define_my_steps() {
      * Define the contents in the activity that must be
      * processed by the link decoder
      */
-    static public function define_decode_contents() {
+    public static function define_decode_contents() {
         $contents = array();
 
         $contents[] = new restore_decode_content('collaborate', array('intro'), 'collaborate');
@@ -68,7 +68,7 @@ static public function define_decode_contents() {
      * Define the decoding rules for links belonging
      * to the activity to be executed by the link decoder
      */
-    static public function define_decode_rules() {
+    public static function define_decode_rules() {
         $rules = array();
 
         $rules[] = new restore_decode_rule('COLLABORATEVIEWBYID', '/mod/collaborate/view.php?id=$1', 'course_module');
@@ -84,7 +84,7 @@ static public function define_decode_rules() {
      * collaborate logs. It must return one array
      * of {@link restore_log_rule} objects
      */
-    static public function define_restore_log_rules() {
+    public static function define_restore_log_rules() {
         $rules = array();
 
         $rules[] = new restore_log_rule('collaborate', 'add', 'view.php?id={course_module}', '{collaborate}');
@@ -104,7 +104,7 @@ static public function define_restore_log_rules() {
      * by the restore final task, but are defined here at
      * activity level. All them are rules not linked to any module instance (cmid = 0)
      */
-    static public function define_restore_log_rules_for_course() {
+    public static function define_restore_log_rules_for_course() {
         $rules = array();
 
         $rules[] = new restore_log_rule('collaborate', 'view all', 'index.php?id={course}', null);

backup/moodle2/restore_collaborate_stepslib.php

@@ -14,8 +14,6 @@
 // You should have received a copy of the GNU General Public License
 // along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Define all the restore steps that will be used by the restore_collaborate_activity_task
  *

classes/completion/custom_completion.php

@@ -91,4 +91,4 @@ public function get_sort_order(): array {
             'completionlaunch'
         ];
     }
-}
+}

classes/controller/controller_abstract.php

@@ -24,8 +24,6 @@
 
 namespace mod_collaborate\controller;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Controllers handle requests.  Any methods that end with "_action"
  * can be routed to via the URL.  See the router for how this happens.

classes/controller/view_controller.php

@@ -72,8 +72,8 @@ protected function set_properties() {
         global $DB;
 
         // Set class properties from params.
-        $id = optional_param('id', 0, PARAM_INT); // Course_module ID, or
-        $n  = optional_param('n', 0, PARAM_INT);  // collaborate instance ID.
+        $id = optional_param('id', 0, PARAM_INT); // Course_module ID or collaborate instance ID.
+        $n  = optional_param('n', 0, PARAM_INT);
 
         if ($id) {
             $cm         = get_coursemodule_from_id('collaborate', $id, 0, false, MUST_EXIST);
@@ -84,7 +84,7 @@ protected function set_properties() {
             $course     = $DB->get_record('course', array('id' => $collaborate->course), '*', MUST_EXIST);
             $cm         = get_coursemodule_from_instance('collaborate', $collaborate->id, $course->id, false, MUST_EXIST);
         } else {
-            print_error('error:invalidmoduleid', 'mod_collaborate');
+            throw new \moodle_exception('error:invalidmoduleid', 'mod_collaborate');
         }
 
         $this->cm = $cm;

classes/event/course_module_instance_list_viewed.php

@@ -24,8 +24,6 @@
 
 namespace mod_collaborate\event;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * The mod_collaborate instance list viewed event class.
  *

classes/event/course_module_viewed.php

@@ -24,8 +24,6 @@
 
 namespace mod_collaborate\event;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * The mod_collaborate instance list viewed event class
  *

classes/event/recording_deleted.php

@@ -26,8 +26,6 @@
 
 use core\event\base;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Recording deleted event.
  *

classes/event/recording_downloaded.php

@@ -26,8 +26,6 @@
 
 use core\event\base;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Recording downloaded event.
  *

classes/event/recording_viewed.php

@@ -26,8 +26,6 @@
 
 use core\event\base;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Recording viewed event.
  *

classes/event/session_launched.php

@@ -26,8 +26,6 @@
 
 use core\event\base;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * The mod_collaborate session launched event class.
  *

classes/event_handlers.php

@@ -25,8 +25,6 @@
 use core\event\group_deleted;
 use core\event\group_updated;
 
-defined('MOODLE_INTERNAL') || die();
-
 class event_handlers {
 
     /**

classes/exceptions/soap_migration_exception.php

@@ -23,8 +23,7 @@
  */
 
 namespace mod_collaborate\exceptions;
-defined('MOODLE_INTERNAL') || die();
 
 class soap_migration_exception extends \Exception {
 
-}
+}

classes/grades/grading.php

@@ -16,8 +16,6 @@
 
 namespace mod_collaborate\grades;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Grading functions.
  *

classes/iface/api_attendee.php

@@ -16,8 +16,6 @@
 
 namespace mod_collaborate\iface;
 
-defined('MOODLE_INTERNAL') || die();
-
 use stdClass;
 
 /**

classes/iface/api_recordings.php

@@ -15,7 +15,8 @@
 // along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
 
 namespace mod_collaborate\iface;
-
+// Prepare for code checker update. Will be removed on INT-17966.
+// @codingStandardsIgnoreLine
 defined('MOODLE_INTERNAL') || die();
 
 use stdClass,

classes/iface/api_session.php

@@ -16,8 +16,6 @@
 
 namespace mod_collaborate\iface;
 
-defined('MOODLE_INTERNAL') || die();
-
 use stdClass;
 
 /**

classes/local.php

@@ -23,7 +23,8 @@
  */
 
 namespace mod_collaborate;
-
+// Prepare for code checker update. Will be removed on INT-17966.
+// @codingStandardsIgnoreLine
 defined('MOODLE_INTERNAL') || die();
 
 use mod_collaborate\soap\generated\ServerConfiguration,

classes/logging/constants.php

@@ -16,8 +16,6 @@
 
 namespace mod_collaborate\logging;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Define logging constants.
  *

classes/migration_status.php

@@ -73,4 +73,4 @@ public function show_migration_notification ($message) {
         }
         return $shown;
     }
-}
+}

classes/privacy/provider.php

@@ -28,8 +28,6 @@
 use core_privacy\local\request\contextlist;
 use core_privacy\local\request\userlist;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Implementation of the privacy subsystem plugin provider for the Collaborate activity module.
  *

classes/recording_counter.php

@@ -23,7 +23,8 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 namespace mod_collaborate;
-
+// Prepare for code checker update. Will be removed on INT-17966.
+// @codingStandardsIgnoreLine
 defined('MOODLE_INTERNAL') || die();
 
 use mod_collaborate\renderables\recording_counts,

classes/renderables/copyablelink.php

@@ -23,9 +23,7 @@
 
 namespace mod_collaborate\renderables;
 
-defined('MOODLE_INTERNAL') || die();
-
-class copyablelink implements \renderable{
+class copyablelink implements \renderable {
 
     public function __construct($label, $id, $groups) {
         $nogrouplabel = get_string('nogroup', 'mod_collaborate');

classes/renderables/meetingstatus.php

@@ -23,12 +23,10 @@
 
 namespace mod_collaborate\renderables;
 
-defined('MOODLE_INTERNAL') || die();
-
 use mod_collaborate\local;
 use mod_collaborate\traits\exportable;
 
-class meetingstatus implements \renderable, \templatable{
+class meetingstatus implements \renderable, \templatable {
 
     use exportable;
 

classes/renderables/recording.php

@@ -22,8 +22,6 @@
  */
 namespace mod_collaborate\renderables;
 
-defined('MOODLE_INTERNAL') || die();
-
 class recording implements \renderable {
 
     /**

classes/renderables/recording_counts.php

@@ -24,8 +24,6 @@
  */
 namespace mod_collaborate\renderables;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Simple recording count renderable model.
  *

classes/renderables/view_action.php

@@ -24,9 +24,7 @@
 
 namespace mod_collaborate\renderables;
 
-defined('MOODLE_INTERNAL') || die();
-
-class view_action implements \renderable{
+class view_action implements \renderable {
 
     /**
      * @var \stdClass

classes/rest/http_code_validation.php

@@ -22,7 +22,8 @@
  */
 
 namespace mod_collaborate\rest;
-
+// Prepare for code checker update. Will be removed on INT-17966.
+// @codingStandardsIgnoreLine
 defined('MOODLE_INTERNAL') || die();
 
 use mod_collaborate\traits\loggable,

classes/rest/http_validation_code_error.php

@@ -23,8 +23,6 @@
 
 namespace mod_collaborate\rest;
 
-defined('MOODLE_INTERNAL') || die();
-
 use mod_collaborate\logging\constants;
 
 class http_validation_code_error {

classes/rest/requestoptions.php

@@ -23,8 +23,6 @@
 
 namespace mod_collaborate\rest;
 
-defined('MOODLE_INTERNAL') || die();
-
 class requestoptions {
 
     /**

classes/rest/response.php

@@ -23,8 +23,6 @@
 
 namespace mod_collaborate\rest;
 
-defined('MOODLE_INTERNAL') || die();
-
 class response {
     /**
      * @var string

classes/sessionlink.php

@@ -21,7 +21,8 @@
  * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 namespace mod_collaborate;
-
+// Prepare for code checker update. Will be removed on INT-17966.
+// @codingStandardsIgnoreLine
 defined('MOODLE_INTERNAL') || die();
 
 use mod_collaborate\local, stdClass;

classes/settings/setting_statictext.php

@@ -21,8 +21,6 @@
 
 namespace mod_collaborate\settings;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * @author    Guy Thomas
  * @copyright Copyright (c) 2017 Open LMS

classes/settings/setting_trimmed_configtext.php

@@ -16,8 +16,6 @@
 
 namespace mod_collaborate\settings;
 
-defined('MOODLE_INTERNAL') || die();
-
 class setting_trimmed_configtext extends \admin_setting_configtext {
     /**
      * Config text constructor

classes/task/cleanup_sessions_task.php

@@ -23,8 +23,6 @@
  */
 namespace mod_collaborate\task;
 
-defined('MOODLE_INTERNAL') || die();
-
 use mod_collaborate\sessionlink;
 
 class cleanup_sessions_task extends \core\task\scheduled_task {

classes/task/soap_migrator_task.php

@@ -22,7 +22,8 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 namespace mod_collaborate\task;
-
+// Prepare for code checker update. Will be removed on INT-17966.
+// @codingStandardsIgnoreLine
 defined('MOODLE_INTERNAL') || die();
 
 use core\task\adhoc_task,