Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add evaluation details to finally hook stage #1246

Open
toddbaert opened this issue Dec 11, 2024 · 1 comment · May be fixed by #1262
Open

Add evaluation details to finally hook stage #1246

toddbaert opened this issue Dec 11, 2024 · 1 comment · May be fixed by #1262

Comments

@toddbaert
Copy link
Member

Add evaluation details to finally hook stage.

Notes

This breaks the signature of the finally stages based on this spec enhancement. It is not considered a breaking change to the SDK because hooks are marked as experimental in the spec, and the change has no impact on known hooks.

- finally(hookContext, hookHints)
+finally(hookContext, evaluationDetails, hookHints)

Acceptance criteria:

  • finally hook stage modified
  • associated tests

Follow ups:

  • update contribs
@chrfwow
Copy link
Contributor

chrfwow commented Dec 23, 2024

I would like to take this over

chrfwow added a commit to chrfwow/java-sdk that referenced this issue Dec 23, 2024
@chrfwow
feat: Add evaluation details to finally hook stage open-feature#1246
f7e59b0
chrfwow added a commit to chrfwow/java-sdk that referenced this issue Dec 23, 2024
@chrfwow
feat: Add evaluation details to finally hook stage open-feature#1246
0e1db4b 
Signed-off-by: christian.lutnik <[email protected]>
chrfwow added a commit to chrfwow/java-sdk that referenced this issue Dec 23, 2024
@chrfwow
feat: Add evaluation details to finally hook stage open-feature#1246
4f1919d 
Signed-off-by: christian.lutnik <[email protected]>
@chrfwow chrfwow mentioned this issue Dec 23, 2024
Closed
chrfwow added a commit to chrfwow/java-sdk that referenced this issue Dec 23, 2024
@chrfwow
feat: Add evaluation details to finally hook stage open-feature#1246
df686e5 
Signed-off-by: christian.lutnik <[email protected]>
@chrfwow chrfwow linked a pull request Dec 23, 2024 that will close this issue
Open
chrfwow added a commit to chrfwow/java-sdk that referenced this issue Dec 23, 2024
@chrfwow
fixup! feat: Add evaluation details to finally hook stage open-featur…
d9c0982 
…e#1246

Signed-off-by: christian.lutnik <[email protected]>
chrfwow added a commit to chrfwow/java-sdk that referenced this issue Dec 30, 2024
@chrfwow
fixup! feat: Add evaluation details to finally hook stage open-featur…
292310b 
…e#1246

Signed-off-by: christian.lutnik <[email protected]>
chrfwow added a commit to chrfwow/java-sdk that referenced this issue Dec 30, 2024
@chrfwow
fixup! feat: Add evaluation details to finally hook stage open-featur…
000ca10 
…e#1246

Signed-off-by: christian.lutnik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@chrfwow @toddbaert