Skip to content

Commit f034867

Browse files
authored
chore: pin golangci-lint (#849)
golangci requires go 1.20 now 😬 . We can upgrade to 1.20, but for now the change in this tool is causing lint failures since we use `@latest` when we install it. Signed-off-by: Todd Baert <[email protected]>
1 parent b7aacc0 commit f034867

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

.pre-commit-config.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@ repos:
55
- id: gofumpt
66

77
- repo: https://github.com/golangci/golangci-lint
8-
rev: v1.46.2
8+
rev: v1.50.1
99
hooks:
1010
- id: golangci-lint

Makefile

+2-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,8 @@ uninstall:
6060
rm /etc/systemd/system/flagd.service
6161
rm -f $(DESTDIR)$(PREFIX)/bin/flagd
6262
lint:
63-
go install -v github.com/golangci/golangci-lint/cmd/golangci-lint@latest
63+
# pinned to @v1.53.3 until we migrate to go 1.20 (newer versions use incompatible transitive deps)
64+
go install -v github.com/golangci/golangci-lint/cmd/[email protected]
6465
$(foreach module, $(ALL_GO_MOD_DIRS), ${GOPATH}/bin/golangci-lint run --deadline=5m --timeout=5m $(module)/... || exit;)
6566
install-mockgen:
6667
go install github.com/golang/mock/[email protected]

0 commit comments

Comments
 (0)