Skip to content

Commit c4a029b

Browse files
committed
feat: add traces to sync streams
Signed-off-by: Simon Schrottner <[email protected]>
1 parent 9ee0c57 commit c4a029b

File tree

2 files changed

+12
-5
lines changed

2 files changed

+12
-5
lines changed

Makefile

+3-3
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ docker-build: # default to flagd
3232
docker-push: # default to flagd
3333
make docker-push-flagd
3434
docker-build-flagd:
35-
docker buildx build --build-arg=VERSION="$$(git describe --tags --abbrev=0)" --build-arg=COMMIT="$$(git rev-parse --short HEAD)" --build-arg DATE="$$(date +%FT%TZ)" --platform="linux/arm64" -t ${IMG} -f flagd/build.Dockerfile .
35+
docker buildx build --build-arg=VERSION="$$(git describe --tags --abbrev=0)" --build-arg=COMMIT="$$(git rev-parse --short HEAD)" --build-arg DATE="$$(date +%FT%TZ)" --platform="linux/amd64" -t ${IMG} -f flagd/build.Dockerfile .
3636
docker-push-flagd:
3737
docker buildx build --push --build-arg=VERSION="$$(git describe --tags --abbrev=0)" --build-arg=COMMIT="$$(git rev-parse --short HEAD)" --build-arg DATE="$$(date +%FT%TZ)" --platform="linux/ppc64le,linux/s390x,linux/amd64,linux/arm64" -t ${IMG} -f flagd/build.Dockerfile .
3838
build: workspace-init # default to flagd
@@ -108,11 +108,11 @@ run-flagd-proxy-zd-test:
108108
# - .markdownlint.yaml contains the rules for markdownfiles
109109
MDL_DOCKER_VERSION := next
110110
ROOT_DIR := $(dir $(realpath $(lastword $(MAKEFILE_LIST))))
111-
MDL_CMD := docker run -v $(ROOT_DIR):/workdir --rm
111+
MDL_CMD := docker run -v $(ROOT_DIR):/workdir --rm
112112

113113
.PHONY: markdownlint markdownlint-fix
114114
markdownlint:
115-
$(MDL_CMD) davidanson/markdownlint-cli2-rules:$(MDL_DOCKER_VERSION) "**/*.md"
115+
$(MDL_CMD) davidanson/markdownlint-cli2-rules:$(MDL_DOCKER_VERSION) "**/*.md"
116116

117117
markdownlint-fix:
118118
$(MDL_CMD) --entrypoint="markdownlint-cli2-fix" davidanson/markdownlint-cli2-rules:$(MDL_DOCKER_VERSION) "**/*.md"

flagd/pkg/service/flag-sync/sync_service.go

+9-2
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ import (
1111
"buf.build/gen/go/open-feature/flagd/grpc/go/flagd/sync/v1/syncv1grpc"
1212
"github.com/open-feature/flagd/core/pkg/logger"
1313
"github.com/open-feature/flagd/core/pkg/store"
14+
"go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc"
15+
"go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/filters"
1416
"golang.org/x/sync/errgroup"
1517
"google.golang.org/grpc"
1618
"google.golang.org/grpc/credentials"
@@ -75,9 +77,14 @@ func NewSyncService(cfg SvcConfigurations) (*Service, error) {
7577
if err != nil {
7678
return nil, fmt.Errorf("failed to load TLS cert and key: %w", err)
7779
}
78-
server = grpc.NewServer(grpc.Creds(tlsCredentials))
80+
server = grpc.NewServer(
81+
grpc.Creds(tlsCredentials),
82+
grpc.StatsHandler(
83+
otelgrpc.NewServerHandler(otelgrpc.WithFilter(filters.Not(filters.MethodName("SyncFlags"))))))
7984
} else {
80-
server = grpc.NewServer()
85+
server = grpc.NewServer(
86+
grpc.StatsHandler(
87+
otelgrpc.NewServerHandler(otelgrpc.WithFilter(filters.Not(filters.MethodName("SyncFlags"))))))
8188
}
8289

8390
syncv1grpc.RegisterFlagSyncServiceServer(server, &syncHandler{

0 commit comments

Comments
 (0)