From 316e82e3ce316a074d9ad81e1d7da0f6b6875adf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Silva?= <2493377+askpt@users.noreply.github.com> Date: Mon, 19 May 2025 16:08:54 +0100 Subject: [PATCH 1/8] chore: remove Nullable enable setting from project files MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com> --- .../OpenFeature.DependencyInjection.csproj | 1 - src/OpenFeature.Hosting/OpenFeature.Hosting.csproj | 1 - .../OpenFeature.DependencyInjection.Tests.csproj | 1 - .../OpenFeature.IntegrationTests.csproj | 1 - 4 files changed, 4 deletions(-) diff --git a/src/OpenFeature.DependencyInjection/OpenFeature.DependencyInjection.csproj b/src/OpenFeature.DependencyInjection/OpenFeature.DependencyInjection.csproj index 99270ab3..f09cab94 100644 --- a/src/OpenFeature.DependencyInjection/OpenFeature.DependencyInjection.csproj +++ b/src/OpenFeature.DependencyInjection/OpenFeature.DependencyInjection.csproj @@ -3,7 +3,6 @@ netstandard2.0;net8.0;net9.0;net462 enable - enable OpenFeature.DependencyInjection diff --git a/src/OpenFeature.Hosting/OpenFeature.Hosting.csproj b/src/OpenFeature.Hosting/OpenFeature.Hosting.csproj index 43237e0f..3dddc944 100644 --- a/src/OpenFeature.Hosting/OpenFeature.Hosting.csproj +++ b/src/OpenFeature.Hosting/OpenFeature.Hosting.csproj @@ -3,7 +3,6 @@ net8.0;net9.0 enable - enable OpenFeature diff --git a/test/OpenFeature.DependencyInjection.Tests/OpenFeature.DependencyInjection.Tests.csproj b/test/OpenFeature.DependencyInjection.Tests/OpenFeature.DependencyInjection.Tests.csproj index 4d714afe..36ae4d61 100644 --- a/test/OpenFeature.DependencyInjection.Tests/OpenFeature.DependencyInjection.Tests.csproj +++ b/test/OpenFeature.DependencyInjection.Tests/OpenFeature.DependencyInjection.Tests.csproj @@ -3,7 +3,6 @@ net8.0;net9.0 enable - enable false true diff --git a/test/OpenFeature.IntegrationTests/OpenFeature.IntegrationTests.csproj b/test/OpenFeature.IntegrationTests/OpenFeature.IntegrationTests.csproj index 151c61b9..c0a04a29 100644 --- a/test/OpenFeature.IntegrationTests/OpenFeature.IntegrationTests.csproj +++ b/test/OpenFeature.IntegrationTests/OpenFeature.IntegrationTests.csproj @@ -3,7 +3,6 @@ net9.0 enable - enable false true From 94311fc745043e9c71986b17bc34598ad7508834 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Silva?= <2493377+askpt@users.noreply.github.com> Date: Mon, 19 May 2025 16:09:29 +0100 Subject: [PATCH 2/8] chore: remove IsTestProject setting from test project file MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com> --- .../OpenFeature.DependencyInjection.Tests.csproj | 1 - .../OpenFeature.IntegrationTests.csproj | 1 - 2 files changed, 2 deletions(-) diff --git a/test/OpenFeature.DependencyInjection.Tests/OpenFeature.DependencyInjection.Tests.csproj b/test/OpenFeature.DependencyInjection.Tests/OpenFeature.DependencyInjection.Tests.csproj index 36ae4d61..9b274035 100644 --- a/test/OpenFeature.DependencyInjection.Tests/OpenFeature.DependencyInjection.Tests.csproj +++ b/test/OpenFeature.DependencyInjection.Tests/OpenFeature.DependencyInjection.Tests.csproj @@ -5,7 +5,6 @@ enable false - true diff --git a/test/OpenFeature.IntegrationTests/OpenFeature.IntegrationTests.csproj b/test/OpenFeature.IntegrationTests/OpenFeature.IntegrationTests.csproj index c0a04a29..e485ddf7 100644 --- a/test/OpenFeature.IntegrationTests/OpenFeature.IntegrationTests.csproj +++ b/test/OpenFeature.IntegrationTests/OpenFeature.IntegrationTests.csproj @@ -5,7 +5,6 @@ enable false - true From a9a258bf6d097427e8264fa9b083751a4ea115b4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Silva?= <2493377+askpt@users.noreply.github.com> Date: Mon, 19 May 2025 16:09:52 +0100 Subject: [PATCH 3/8] chore: remove IsPackable setting from test project files MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com> --- .../OpenFeature.DependencyInjection.Tests.csproj | 2 -- .../OpenFeature.IntegrationTests.csproj | 2 -- 2 files changed, 4 deletions(-) diff --git a/test/OpenFeature.DependencyInjection.Tests/OpenFeature.DependencyInjection.Tests.csproj b/test/OpenFeature.DependencyInjection.Tests/OpenFeature.DependencyInjection.Tests.csproj index 9b274035..6d7ad565 100644 --- a/test/OpenFeature.DependencyInjection.Tests/OpenFeature.DependencyInjection.Tests.csproj +++ b/test/OpenFeature.DependencyInjection.Tests/OpenFeature.DependencyInjection.Tests.csproj @@ -3,8 +3,6 @@ net8.0;net9.0 enable - - false diff --git a/test/OpenFeature.IntegrationTests/OpenFeature.IntegrationTests.csproj b/test/OpenFeature.IntegrationTests/OpenFeature.IntegrationTests.csproj index e485ddf7..555cabbf 100644 --- a/test/OpenFeature.IntegrationTests/OpenFeature.IntegrationTests.csproj +++ b/test/OpenFeature.IntegrationTests/OpenFeature.IntegrationTests.csproj @@ -3,8 +3,6 @@ net9.0 enable - - false From a202207c21c96abc77204a49075eeac3dcd59aab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Silva?= <2493377+askpt@users.noreply.github.com> Date: Mon, 19 May 2025 16:10:57 +0100 Subject: [PATCH 4/8] chore: remove ImplicitUsings setting from project files MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com> --- build/Common.props | 1 + .../OpenFeature.DependencyInjection.csproj | 1 - src/OpenFeature.Hosting/OpenFeature.Hosting.csproj | 1 - .../OpenFeature.DependencyInjection.Tests.csproj | 1 - .../OpenFeature.IntegrationTests.csproj | 1 - 5 files changed, 1 insertion(+), 4 deletions(-) diff --git a/build/Common.props b/build/Common.props index 1c769bcf..77715cc3 100644 --- a/build/Common.props +++ b/build/Common.props @@ -7,6 +7,7 @@ EnableGenerateDocumentationFile enable + enable true true all diff --git a/src/OpenFeature.DependencyInjection/OpenFeature.DependencyInjection.csproj b/src/OpenFeature.DependencyInjection/OpenFeature.DependencyInjection.csproj index f09cab94..855ab2ab 100644 --- a/src/OpenFeature.DependencyInjection/OpenFeature.DependencyInjection.csproj +++ b/src/OpenFeature.DependencyInjection/OpenFeature.DependencyInjection.csproj @@ -2,7 +2,6 @@ netstandard2.0;net8.0;net9.0;net462 - enable OpenFeature.DependencyInjection diff --git a/src/OpenFeature.Hosting/OpenFeature.Hosting.csproj b/src/OpenFeature.Hosting/OpenFeature.Hosting.csproj index 3dddc944..1d54ff02 100644 --- a/src/OpenFeature.Hosting/OpenFeature.Hosting.csproj +++ b/src/OpenFeature.Hosting/OpenFeature.Hosting.csproj @@ -2,7 +2,6 @@ net8.0;net9.0 - enable OpenFeature diff --git a/test/OpenFeature.DependencyInjection.Tests/OpenFeature.DependencyInjection.Tests.csproj b/test/OpenFeature.DependencyInjection.Tests/OpenFeature.DependencyInjection.Tests.csproj index 6d7ad565..d6bce29e 100644 --- a/test/OpenFeature.DependencyInjection.Tests/OpenFeature.DependencyInjection.Tests.csproj +++ b/test/OpenFeature.DependencyInjection.Tests/OpenFeature.DependencyInjection.Tests.csproj @@ -2,7 +2,6 @@ net8.0;net9.0 - enable diff --git a/test/OpenFeature.IntegrationTests/OpenFeature.IntegrationTests.csproj b/test/OpenFeature.IntegrationTests/OpenFeature.IntegrationTests.csproj index 555cabbf..e8ddaa63 100644 --- a/test/OpenFeature.IntegrationTests/OpenFeature.IntegrationTests.csproj +++ b/test/OpenFeature.IntegrationTests/OpenFeature.IntegrationTests.csproj @@ -2,7 +2,6 @@ net9.0 - enable From a847e56e97f299dce4fc535e5ea66b1755ce7c97 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Silva?= <2493377+askpt@users.noreply.github.com> Date: Mon, 19 May 2025 16:12:29 +0100 Subject: [PATCH 5/8] Refactor: Remove unnecessary using directives across multiple files MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com> --- src/OpenFeature/Api.cs | 5 ----- src/OpenFeature/AsyncLocalTransactionContextPropagator.cs | 1 - src/OpenFeature/Error/FeatureProviderException.cs | 1 - src/OpenFeature/Error/FlagNotFoundException.cs | 1 - src/OpenFeature/Error/GeneralException.cs | 1 - src/OpenFeature/Error/InvalidContextException.cs | 1 - src/OpenFeature/Error/ParseErrorException.cs | 1 - src/OpenFeature/Error/ProviderFatalException.cs | 1 - src/OpenFeature/Error/ProviderNotReadyException.cs | 1 - src/OpenFeature/Error/TargetingKeyMissingException.cs | 1 - src/OpenFeature/Error/TypeMismatchException.cs | 1 - src/OpenFeature/EventExecutor.cs | 3 --- src/OpenFeature/Extension/EnumExtensions.cs | 2 -- src/OpenFeature/FeatureProvider.cs | 2 -- src/OpenFeature/Hook.cs | 4 ---- src/OpenFeature/HookData.cs | 1 - src/OpenFeature/HookRunner.cs | 4 ---- src/OpenFeature/Hooks/LoggingHook.cs | 4 ---- src/OpenFeature/IFeatureClient.cs | 3 --- src/OpenFeature/Model/EvaluationContext.cs | 2 -- src/OpenFeature/Model/EvaluationContextBuilder.cs | 2 -- src/OpenFeature/Model/HookContext.cs | 1 - src/OpenFeature/Model/ImmutableMetadata.cs | 1 - src/OpenFeature/Model/ProviderEvents.cs | 1 - src/OpenFeature/Model/Structure.cs | 1 - src/OpenFeature/Model/StructureBuilder.cs | 2 -- src/OpenFeature/Model/TrackingEventDetails.cs | 2 -- src/OpenFeature/Model/TrackingEventDetailsBuilder.cs | 2 -- src/OpenFeature/Model/Value.cs | 2 -- src/OpenFeature/NoOpProvider.cs | 2 -- src/OpenFeature/OpenFeatureClient.cs | 5 ----- src/OpenFeature/ProviderRepository.cs | 4 ---- src/OpenFeature/Providers/Memory/Flag.cs | 2 -- src/OpenFeature/Providers/Memory/InMemoryProvider.cs | 4 ---- src/OpenFeature/SharedHookContext.cs | 1 - src/OpenFeature/Telemetry/EvaluationEvent.cs | 2 -- src/OpenFeature/Telemetry/EvaluationEventBuilder.cs | 1 - test/OpenFeature.Benchmarks/OpenFeatureClientBenchmarks.cs | 1 - test/OpenFeature.E2ETests/Steps/BaseStepDefinitions.cs | 4 ---- .../Steps/ContextMergingPrecedenceStepDefinitions.cs | 1 - test/OpenFeature.E2ETests/Steps/EvaluationStepDefinitions.cs | 1 - test/OpenFeature.E2ETests/Steps/MetadataStepDefinitions.cs | 2 -- test/OpenFeature.E2ETests/Utils/ContextStoringProvider.cs | 2 -- test/OpenFeature.E2ETests/Utils/FlagTypesUtil.cs | 1 - test/OpenFeature.E2ETests/Utils/TestHook.cs | 4 ---- test/OpenFeature.Tests/ClearOpenFeatureInstanceFixture.cs | 1 - test/OpenFeature.Tests/FeatureProviderExceptionTests.cs | 1 - test/OpenFeature.Tests/FeatureProviderTests.cs | 1 - test/OpenFeature.Tests/HookDataTests.cs | 2 -- test/OpenFeature.Tests/Hooks/LoggingHookTests.cs | 2 -- test/OpenFeature.Tests/ImmutableMetadataTest.cs | 1 - test/OpenFeature.Tests/Internal/SpecificationAttribute.cs | 2 -- test/OpenFeature.Tests/OpenFeatureClientTests.cs | 5 ----- test/OpenFeature.Tests/OpenFeatureEvaluationContextTests.cs | 2 -- test/OpenFeature.Tests/OpenFeatureEventTests.cs | 4 ---- test/OpenFeature.Tests/OpenFeatureHookTests.cs | 5 ----- test/OpenFeature.Tests/OpenFeatureTests.cs | 3 --- test/OpenFeature.Tests/ProviderRepositoryTests.cs | 2 -- .../Providers/Memory/InMemoryProviderTests.cs | 2 -- test/OpenFeature.Tests/StructureTests.cs | 2 -- .../Telemetry/EvaluationEventBuilderTests.cs | 1 - test/OpenFeature.Tests/TestImplementations.cs | 4 ---- test/OpenFeature.Tests/TestUtils.cs | 5 ----- test/OpenFeature.Tests/TestUtilsTest.cs | 2 -- test/OpenFeature.Tests/TrackingEventDetailsTest.cs | 2 -- test/OpenFeature.Tests/ValueTests.cs | 2 -- 66 files changed, 142 deletions(-) diff --git a/src/OpenFeature/Api.cs b/src/OpenFeature/Api.cs index cc0161c1..cea66139 100644 --- a/src/OpenFeature/Api.cs +++ b/src/OpenFeature/Api.cs @@ -1,9 +1,4 @@ -using System; using System.Collections.Concurrent; -using System.Collections.Generic; -using System.Linq; -using System.Threading; -using System.Threading.Tasks; using Microsoft.Extensions.Logging; using OpenFeature.Constant; using OpenFeature.Error; diff --git a/src/OpenFeature/AsyncLocalTransactionContextPropagator.cs b/src/OpenFeature/AsyncLocalTransactionContextPropagator.cs index 86992aac..723c3dcb 100644 --- a/src/OpenFeature/AsyncLocalTransactionContextPropagator.cs +++ b/src/OpenFeature/AsyncLocalTransactionContextPropagator.cs @@ -1,4 +1,3 @@ -using System.Threading; using OpenFeature.Model; namespace OpenFeature; diff --git a/src/OpenFeature/Error/FeatureProviderException.cs b/src/OpenFeature/Error/FeatureProviderException.cs index b0431ab7..162f2c93 100644 --- a/src/OpenFeature/Error/FeatureProviderException.cs +++ b/src/OpenFeature/Error/FeatureProviderException.cs @@ -1,4 +1,3 @@ -using System; using OpenFeature.Constant; namespace OpenFeature.Error; diff --git a/src/OpenFeature/Error/FlagNotFoundException.cs b/src/OpenFeature/Error/FlagNotFoundException.cs index d685bb4a..a605e920 100644 --- a/src/OpenFeature/Error/FlagNotFoundException.cs +++ b/src/OpenFeature/Error/FlagNotFoundException.cs @@ -1,4 +1,3 @@ -using System; using System.Diagnostics.CodeAnalysis; using OpenFeature.Constant; diff --git a/src/OpenFeature/Error/GeneralException.cs b/src/OpenFeature/Error/GeneralException.cs index 0f9da24c..ac9caad4 100644 --- a/src/OpenFeature/Error/GeneralException.cs +++ b/src/OpenFeature/Error/GeneralException.cs @@ -1,4 +1,3 @@ -using System; using System.Diagnostics.CodeAnalysis; using OpenFeature.Constant; diff --git a/src/OpenFeature/Error/InvalidContextException.cs b/src/OpenFeature/Error/InvalidContextException.cs index 881d0464..526a8775 100644 --- a/src/OpenFeature/Error/InvalidContextException.cs +++ b/src/OpenFeature/Error/InvalidContextException.cs @@ -1,4 +1,3 @@ -using System; using System.Diagnostics.CodeAnalysis; using OpenFeature.Constant; diff --git a/src/OpenFeature/Error/ParseErrorException.cs b/src/OpenFeature/Error/ParseErrorException.cs index 57bcf271..364437e8 100644 --- a/src/OpenFeature/Error/ParseErrorException.cs +++ b/src/OpenFeature/Error/ParseErrorException.cs @@ -1,4 +1,3 @@ -using System; using System.Diagnostics.CodeAnalysis; using OpenFeature.Constant; diff --git a/src/OpenFeature/Error/ProviderFatalException.cs b/src/OpenFeature/Error/ProviderFatalException.cs index 60ba5f25..3865f29f 100644 --- a/src/OpenFeature/Error/ProviderFatalException.cs +++ b/src/OpenFeature/Error/ProviderFatalException.cs @@ -1,4 +1,3 @@ -using System; using System.Diagnostics.CodeAnalysis; using OpenFeature.Constant; diff --git a/src/OpenFeature/Error/ProviderNotReadyException.cs b/src/OpenFeature/Error/ProviderNotReadyException.cs index 5d2e3af1..b301a0c8 100644 --- a/src/OpenFeature/Error/ProviderNotReadyException.cs +++ b/src/OpenFeature/Error/ProviderNotReadyException.cs @@ -1,4 +1,3 @@ -using System; using System.Diagnostics.CodeAnalysis; using OpenFeature.Constant; diff --git a/src/OpenFeature/Error/TargetingKeyMissingException.cs b/src/OpenFeature/Error/TargetingKeyMissingException.cs index 488009f4..e655ffc7 100644 --- a/src/OpenFeature/Error/TargetingKeyMissingException.cs +++ b/src/OpenFeature/Error/TargetingKeyMissingException.cs @@ -1,4 +1,3 @@ -using System; using System.Diagnostics.CodeAnalysis; using OpenFeature.Constant; diff --git a/src/OpenFeature/Error/TypeMismatchException.cs b/src/OpenFeature/Error/TypeMismatchException.cs index 2df3b29f..c53b98f6 100644 --- a/src/OpenFeature/Error/TypeMismatchException.cs +++ b/src/OpenFeature/Error/TypeMismatchException.cs @@ -1,4 +1,3 @@ -using System; using System.Diagnostics.CodeAnalysis; using OpenFeature.Constant; diff --git a/src/OpenFeature/EventExecutor.cs b/src/OpenFeature/EventExecutor.cs index edb75780..db2b6fb1 100644 --- a/src/OpenFeature/EventExecutor.cs +++ b/src/OpenFeature/EventExecutor.cs @@ -1,7 +1,4 @@ -using System; -using System.Collections.Generic; using System.Threading.Channels; -using System.Threading.Tasks; using Microsoft.Extensions.Logging; using Microsoft.Extensions.Logging.Abstractions; using OpenFeature.Constant; diff --git a/src/OpenFeature/Extension/EnumExtensions.cs b/src/OpenFeature/Extension/EnumExtensions.cs index d5d7e72b..73c39125 100644 --- a/src/OpenFeature/Extension/EnumExtensions.cs +++ b/src/OpenFeature/Extension/EnumExtensions.cs @@ -1,6 +1,4 @@ -using System; using System.ComponentModel; -using System.Linq; namespace OpenFeature.Extension; diff --git a/src/OpenFeature/FeatureProvider.cs b/src/OpenFeature/FeatureProvider.cs index 9c9d9327..16c495c6 100644 --- a/src/OpenFeature/FeatureProvider.cs +++ b/src/OpenFeature/FeatureProvider.cs @@ -1,7 +1,5 @@ using System.Collections.Immutable; -using System.Threading; using System.Threading.Channels; -using System.Threading.Tasks; using OpenFeature.Constant; using OpenFeature.Model; diff --git a/src/OpenFeature/Hook.cs b/src/OpenFeature/Hook.cs index d38550ff..cd9f76d2 100644 --- a/src/OpenFeature/Hook.cs +++ b/src/OpenFeature/Hook.cs @@ -1,7 +1,3 @@ -using System; -using System.Collections.Generic; -using System.Threading; -using System.Threading.Tasks; using OpenFeature.Model; namespace OpenFeature; diff --git a/src/OpenFeature/HookData.cs b/src/OpenFeature/HookData.cs index ecfdfabd..b450b3bb 100644 --- a/src/OpenFeature/HookData.cs +++ b/src/OpenFeature/HookData.cs @@ -1,4 +1,3 @@ -using System.Collections.Generic; using System.Collections.Immutable; using OpenFeature.Model; diff --git a/src/OpenFeature/HookRunner.cs b/src/OpenFeature/HookRunner.cs index c80b8613..07322774 100644 --- a/src/OpenFeature/HookRunner.cs +++ b/src/OpenFeature/HookRunner.cs @@ -1,8 +1,4 @@ -using System; -using System.Collections.Generic; using System.Collections.Immutable; -using System.Threading; -using System.Threading.Tasks; using Microsoft.Extensions.Logging; using OpenFeature.Model; diff --git a/src/OpenFeature/Hooks/LoggingHook.cs b/src/OpenFeature/Hooks/LoggingHook.cs index b8308167..77bf703f 100644 --- a/src/OpenFeature/Hooks/LoggingHook.cs +++ b/src/OpenFeature/Hooks/LoggingHook.cs @@ -1,8 +1,4 @@ -using System; -using System.Collections.Generic; using System.Text; -using System.Threading; -using System.Threading.Tasks; using Microsoft.Extensions.Logging; using OpenFeature.Model; diff --git a/src/OpenFeature/IFeatureClient.cs b/src/OpenFeature/IFeatureClient.cs index c14e6e4b..acf38804 100644 --- a/src/OpenFeature/IFeatureClient.cs +++ b/src/OpenFeature/IFeatureClient.cs @@ -1,6 +1,3 @@ -using System.Collections.Generic; -using System.Threading; -using System.Threading.Tasks; using OpenFeature.Constant; using OpenFeature.Model; diff --git a/src/OpenFeature/Model/EvaluationContext.cs b/src/OpenFeature/Model/EvaluationContext.cs index ed4f989a..28b522e2 100644 --- a/src/OpenFeature/Model/EvaluationContext.cs +++ b/src/OpenFeature/Model/EvaluationContext.cs @@ -1,5 +1,3 @@ -using System; -using System.Collections.Generic; using System.Collections.Immutable; namespace OpenFeature.Model; diff --git a/src/OpenFeature/Model/EvaluationContextBuilder.cs b/src/OpenFeature/Model/EvaluationContextBuilder.cs index 3d85ba98..4f1ccc4d 100644 --- a/src/OpenFeature/Model/EvaluationContextBuilder.cs +++ b/src/OpenFeature/Model/EvaluationContextBuilder.cs @@ -1,5 +1,3 @@ -using System; - namespace OpenFeature.Model; /// diff --git a/src/OpenFeature/Model/HookContext.cs b/src/OpenFeature/Model/HookContext.cs index 4abc773c..c6448cbd 100644 --- a/src/OpenFeature/Model/HookContext.cs +++ b/src/OpenFeature/Model/HookContext.cs @@ -1,4 +1,3 @@ -using System; using OpenFeature.Constant; namespace OpenFeature.Model; diff --git a/src/OpenFeature/Model/ImmutableMetadata.cs b/src/OpenFeature/Model/ImmutableMetadata.cs index f1d54449..5af7b555 100644 --- a/src/OpenFeature/Model/ImmutableMetadata.cs +++ b/src/OpenFeature/Model/ImmutableMetadata.cs @@ -1,4 +1,3 @@ -using System.Collections.Generic; using System.Collections.Immutable; namespace OpenFeature.Model; diff --git a/src/OpenFeature/Model/ProviderEvents.cs b/src/OpenFeature/Model/ProviderEvents.cs index 1977edb6..18b9ec5c 100644 --- a/src/OpenFeature/Model/ProviderEvents.cs +++ b/src/OpenFeature/Model/ProviderEvents.cs @@ -1,4 +1,3 @@ -using System.Collections.Generic; using OpenFeature.Constant; namespace OpenFeature.Model; diff --git a/src/OpenFeature/Model/Structure.cs b/src/OpenFeature/Model/Structure.cs index 9807ec45..55a7babe 100644 --- a/src/OpenFeature/Model/Structure.cs +++ b/src/OpenFeature/Model/Structure.cs @@ -1,5 +1,4 @@ using System.Collections; -using System.Collections.Generic; using System.Collections.Immutable; using System.Diagnostics.CodeAnalysis; diff --git a/src/OpenFeature/Model/StructureBuilder.cs b/src/OpenFeature/Model/StructureBuilder.cs index 0cc922ac..eaa7de74 100644 --- a/src/OpenFeature/Model/StructureBuilder.cs +++ b/src/OpenFeature/Model/StructureBuilder.cs @@ -1,5 +1,3 @@ -using System; -using System.Collections.Generic; using System.Collections.Immutable; namespace OpenFeature.Model; diff --git a/src/OpenFeature/Model/TrackingEventDetails.cs b/src/OpenFeature/Model/TrackingEventDetails.cs index 0d342cc1..3e3e4312 100644 --- a/src/OpenFeature/Model/TrackingEventDetails.cs +++ b/src/OpenFeature/Model/TrackingEventDetails.cs @@ -1,5 +1,3 @@ -using System; -using System.Collections.Generic; using System.Collections.Immutable; namespace OpenFeature.Model; diff --git a/src/OpenFeature/Model/TrackingEventDetailsBuilder.cs b/src/OpenFeature/Model/TrackingEventDetailsBuilder.cs index 6520ab3e..60381f8b 100644 --- a/src/OpenFeature/Model/TrackingEventDetailsBuilder.cs +++ b/src/OpenFeature/Model/TrackingEventDetailsBuilder.cs @@ -1,5 +1,3 @@ -using System; - namespace OpenFeature.Model; /// diff --git a/src/OpenFeature/Model/Value.cs b/src/OpenFeature/Model/Value.cs index 2f75eca3..f09a2466 100644 --- a/src/OpenFeature/Model/Value.cs +++ b/src/OpenFeature/Model/Value.cs @@ -1,5 +1,3 @@ -using System; -using System.Collections.Generic; using System.Collections.Immutable; namespace OpenFeature.Model; diff --git a/src/OpenFeature/NoOpProvider.cs b/src/OpenFeature/NoOpProvider.cs index 20973365..0317fbd2 100644 --- a/src/OpenFeature/NoOpProvider.cs +++ b/src/OpenFeature/NoOpProvider.cs @@ -1,5 +1,3 @@ -using System.Threading; -using System.Threading.Tasks; using OpenFeature.Constant; using OpenFeature.Model; diff --git a/src/OpenFeature/OpenFeatureClient.cs b/src/OpenFeature/OpenFeatureClient.cs index 98aae19f..02acde07 100644 --- a/src/OpenFeature/OpenFeatureClient.cs +++ b/src/OpenFeature/OpenFeatureClient.cs @@ -1,10 +1,5 @@ -using System; using System.Collections.Concurrent; -using System.Collections.Generic; using System.Collections.Immutable; -using System.Linq; -using System.Threading; -using System.Threading.Tasks; using Microsoft.Extensions.Logging; using Microsoft.Extensions.Logging.Abstractions; using OpenFeature.Constant; diff --git a/src/OpenFeature/ProviderRepository.cs b/src/OpenFeature/ProviderRepository.cs index 54e797db..4f938940 100644 --- a/src/OpenFeature/ProviderRepository.cs +++ b/src/OpenFeature/ProviderRepository.cs @@ -1,8 +1,4 @@ -using System; using System.Collections.Concurrent; -using System.Collections.Generic; -using System.Threading; -using System.Threading.Tasks; using Microsoft.Extensions.Logging; using Microsoft.Extensions.Logging.Abstractions; using OpenFeature.Constant; diff --git a/src/OpenFeature/Providers/Memory/Flag.cs b/src/OpenFeature/Providers/Memory/Flag.cs index fd8cf19f..f42b0af7 100644 --- a/src/OpenFeature/Providers/Memory/Flag.cs +++ b/src/OpenFeature/Providers/Memory/Flag.cs @@ -1,5 +1,3 @@ -using System; -using System.Collections.Generic; using OpenFeature.Constant; using OpenFeature.Error; using OpenFeature.Model; diff --git a/src/OpenFeature/Providers/Memory/InMemoryProvider.cs b/src/OpenFeature/Providers/Memory/InMemoryProvider.cs index fce7afe1..617a2ecb 100644 --- a/src/OpenFeature/Providers/Memory/InMemoryProvider.cs +++ b/src/OpenFeature/Providers/Memory/InMemoryProvider.cs @@ -1,7 +1,3 @@ -using System.Collections.Generic; -using System.Linq; -using System.Threading; -using System.Threading.Tasks; using OpenFeature.Constant; using OpenFeature.Model; diff --git a/src/OpenFeature/SharedHookContext.cs b/src/OpenFeature/SharedHookContext.cs index c364e40c..887e19fc 100644 --- a/src/OpenFeature/SharedHookContext.cs +++ b/src/OpenFeature/SharedHookContext.cs @@ -1,4 +1,3 @@ -using System; using OpenFeature.Constant; using OpenFeature.Model; diff --git a/src/OpenFeature/Telemetry/EvaluationEvent.cs b/src/OpenFeature/Telemetry/EvaluationEvent.cs index 51506ad7..a2a8c275 100644 --- a/src/OpenFeature/Telemetry/EvaluationEvent.cs +++ b/src/OpenFeature/Telemetry/EvaluationEvent.cs @@ -1,5 +1,3 @@ -using System.Collections.Generic; - namespace OpenFeature.Telemetry; /// diff --git a/src/OpenFeature/Telemetry/EvaluationEventBuilder.cs b/src/OpenFeature/Telemetry/EvaluationEventBuilder.cs index 2f73224f..d9520c12 100644 --- a/src/OpenFeature/Telemetry/EvaluationEventBuilder.cs +++ b/src/OpenFeature/Telemetry/EvaluationEventBuilder.cs @@ -1,4 +1,3 @@ -using System.Collections.Generic; using OpenFeature.Constant; using OpenFeature.Model; diff --git a/test/OpenFeature.Benchmarks/OpenFeatureClientBenchmarks.cs b/test/OpenFeature.Benchmarks/OpenFeatureClientBenchmarks.cs index d4c770eb..0c2e614a 100644 --- a/test/OpenFeature.Benchmarks/OpenFeatureClientBenchmarks.cs +++ b/test/OpenFeature.Benchmarks/OpenFeatureClientBenchmarks.cs @@ -1,6 +1,5 @@ using System.Collections.Immutable; -using System.Threading.Tasks; using AutoFixture; using BenchmarkDotNet.Attributes; using BenchmarkDotNet.Jobs; diff --git a/test/OpenFeature.E2ETests/Steps/BaseStepDefinitions.cs b/test/OpenFeature.E2ETests/Steps/BaseStepDefinitions.cs index 6b2bfebf..a0f36d0c 100644 --- a/test/OpenFeature.E2ETests/Steps/BaseStepDefinitions.cs +++ b/test/OpenFeature.E2ETests/Steps/BaseStepDefinitions.cs @@ -1,7 +1,3 @@ -using System.Collections.Generic; -using System.Linq; -using System.Threading; -using System.Threading.Tasks; using OpenFeature.E2ETests.Utils; using OpenFeature.Model; using OpenFeature.Providers.Memory; diff --git a/test/OpenFeature.E2ETests/Steps/ContextMergingPrecedenceStepDefinitions.cs b/test/OpenFeature.E2ETests/Steps/ContextMergingPrecedenceStepDefinitions.cs index c9f454ac..639ba22f 100644 --- a/test/OpenFeature.E2ETests/Steps/ContextMergingPrecedenceStepDefinitions.cs +++ b/test/OpenFeature.E2ETests/Steps/ContextMergingPrecedenceStepDefinitions.cs @@ -1,4 +1,3 @@ -using System.Threading.Tasks; using OpenFeature.E2ETests.Utils; using Reqnroll; using Xunit; diff --git a/test/OpenFeature.E2ETests/Steps/EvaluationStepDefinitions.cs b/test/OpenFeature.E2ETests/Steps/EvaluationStepDefinitions.cs index 6efcf3d4..a2e85429 100644 --- a/test/OpenFeature.E2ETests/Steps/EvaluationStepDefinitions.cs +++ b/test/OpenFeature.E2ETests/Steps/EvaluationStepDefinitions.cs @@ -1,4 +1,3 @@ -using System.Threading.Tasks; using OpenFeature.Constant; using OpenFeature.E2ETests.Utils; using OpenFeature.Extension; diff --git a/test/OpenFeature.E2ETests/Steps/MetadataStepDefinitions.cs b/test/OpenFeature.E2ETests/Steps/MetadataStepDefinitions.cs index 63c8cdbe..7acbf917 100644 --- a/test/OpenFeature.E2ETests/Steps/MetadataStepDefinitions.cs +++ b/test/OpenFeature.E2ETests/Steps/MetadataStepDefinitions.cs @@ -1,5 +1,3 @@ -using System; -using System.Linq; using OpenFeature.E2ETests.Utils; using OpenFeature.Model; using Reqnroll; diff --git a/test/OpenFeature.E2ETests/Utils/ContextStoringProvider.cs b/test/OpenFeature.E2ETests/Utils/ContextStoringProvider.cs index 40141e79..193f4f44 100644 --- a/test/OpenFeature.E2ETests/Utils/ContextStoringProvider.cs +++ b/test/OpenFeature.E2ETests/Utils/ContextStoringProvider.cs @@ -1,5 +1,3 @@ -using System.Threading; -using System.Threading.Tasks; using OpenFeature.Model; namespace OpenFeature.E2ETests.Utils; diff --git a/test/OpenFeature.E2ETests/Utils/FlagTypesUtil.cs b/test/OpenFeature.E2ETests/Utils/FlagTypesUtil.cs index 5b05c799..bc065a7b 100644 --- a/test/OpenFeature.E2ETests/Utils/FlagTypesUtil.cs +++ b/test/OpenFeature.E2ETests/Utils/FlagTypesUtil.cs @@ -1,4 +1,3 @@ -using System; using System.Diagnostics.CodeAnalysis; namespace OpenFeature.E2ETests.Utils; diff --git a/test/OpenFeature.E2ETests/Utils/TestHook.cs b/test/OpenFeature.E2ETests/Utils/TestHook.cs index fbe7568b..4167571a 100644 --- a/test/OpenFeature.E2ETests/Utils/TestHook.cs +++ b/test/OpenFeature.E2ETests/Utils/TestHook.cs @@ -1,8 +1,4 @@ -using System; -using System.Collections.Generic; using System.Diagnostics.CodeAnalysis; -using System.Threading; -using System.Threading.Tasks; using OpenFeature.Model; namespace OpenFeature.E2ETests.Utils; diff --git a/test/OpenFeature.Tests/ClearOpenFeatureInstanceFixture.cs b/test/OpenFeature.Tests/ClearOpenFeatureInstanceFixture.cs index c3351801..23a5fa41 100644 --- a/test/OpenFeature.Tests/ClearOpenFeatureInstanceFixture.cs +++ b/test/OpenFeature.Tests/ClearOpenFeatureInstanceFixture.cs @@ -1,4 +1,3 @@ -using System.Threading.Tasks; using Xunit; namespace OpenFeature.Tests; diff --git a/test/OpenFeature.Tests/FeatureProviderExceptionTests.cs b/test/OpenFeature.Tests/FeatureProviderExceptionTests.cs index 334f664e..c7a6646d 100644 --- a/test/OpenFeature.Tests/FeatureProviderExceptionTests.cs +++ b/test/OpenFeature.Tests/FeatureProviderExceptionTests.cs @@ -1,4 +1,3 @@ -using System; using OpenFeature.Constant; using OpenFeature.Error; using OpenFeature.Extension; diff --git a/test/OpenFeature.Tests/FeatureProviderTests.cs b/test/OpenFeature.Tests/FeatureProviderTests.cs index d7e5ca22..13241f4b 100644 --- a/test/OpenFeature.Tests/FeatureProviderTests.cs +++ b/test/OpenFeature.Tests/FeatureProviderTests.cs @@ -1,4 +1,3 @@ -using System.Threading.Tasks; using AutoFixture; using NSubstitute; using OpenFeature.Constant; diff --git a/test/OpenFeature.Tests/HookDataTests.cs b/test/OpenFeature.Tests/HookDataTests.cs index 96cbaf72..1c937e05 100644 --- a/test/OpenFeature.Tests/HookDataTests.cs +++ b/test/OpenFeature.Tests/HookDataTests.cs @@ -1,5 +1,3 @@ -using System; -using System.Collections.Generic; using OpenFeature.Model; using Xunit; diff --git a/test/OpenFeature.Tests/Hooks/LoggingHookTests.cs b/test/OpenFeature.Tests/Hooks/LoggingHookTests.cs index 1364f83f..04b7ffd9 100644 --- a/test/OpenFeature.Tests/Hooks/LoggingHookTests.cs +++ b/test/OpenFeature.Tests/Hooks/LoggingHookTests.cs @@ -1,5 +1,3 @@ -using System; -using System.Threading.Tasks; using Microsoft.Extensions.Logging; using Microsoft.Extensions.Logging.Testing; using OpenFeature.Constant; diff --git a/test/OpenFeature.Tests/ImmutableMetadataTest.cs b/test/OpenFeature.Tests/ImmutableMetadataTest.cs index cd2fd1d8..b19b542c 100644 --- a/test/OpenFeature.Tests/ImmutableMetadataTest.cs +++ b/test/OpenFeature.Tests/ImmutableMetadataTest.cs @@ -1,4 +1,3 @@ -using System.Collections.Generic; using OpenFeature.Model; using OpenFeature.Tests.Internal; using Xunit; diff --git a/test/OpenFeature.Tests/Internal/SpecificationAttribute.cs b/test/OpenFeature.Tests/Internal/SpecificationAttribute.cs index 9fea9fef..99fb541b 100644 --- a/test/OpenFeature.Tests/Internal/SpecificationAttribute.cs +++ b/test/OpenFeature.Tests/Internal/SpecificationAttribute.cs @@ -1,5 +1,3 @@ -using System; - namespace OpenFeature.Tests.Internal; [AttributeUsage(AttributeTargets.Method, AllowMultiple = true, Inherited = false)] diff --git a/test/OpenFeature.Tests/OpenFeatureClientTests.cs b/test/OpenFeature.Tests/OpenFeatureClientTests.cs index a43cf4d8..55603eb5 100644 --- a/test/OpenFeature.Tests/OpenFeatureClientTests.cs +++ b/test/OpenFeature.Tests/OpenFeatureClientTests.cs @@ -1,9 +1,4 @@ -using System; -using System.Collections.Generic; using System.Collections.Immutable; -using System.Linq; -using System.Threading; -using System.Threading.Tasks; using AutoFixture; using Microsoft.Extensions.Logging; using NSubstitute; diff --git a/test/OpenFeature.Tests/OpenFeatureEvaluationContextTests.cs b/test/OpenFeature.Tests/OpenFeatureEvaluationContextTests.cs index 630ec435..36a50dc1 100644 --- a/test/OpenFeature.Tests/OpenFeatureEvaluationContextTests.cs +++ b/test/OpenFeature.Tests/OpenFeatureEvaluationContextTests.cs @@ -1,5 +1,3 @@ -using System; -using System.Collections.Generic; using AutoFixture; using OpenFeature.Model; using OpenFeature.Tests.Internal; diff --git a/test/OpenFeature.Tests/OpenFeatureEventTests.cs b/test/OpenFeature.Tests/OpenFeatureEventTests.cs index d47a530f..27240443 100644 --- a/test/OpenFeature.Tests/OpenFeatureEventTests.cs +++ b/test/OpenFeature.Tests/OpenFeatureEventTests.cs @@ -1,7 +1,3 @@ -using System; -using System.Collections.Generic; -using System.Threading; -using System.Threading.Tasks; using AutoFixture; using NSubstitute; using OpenFeature.Constant; diff --git a/test/OpenFeature.Tests/OpenFeatureHookTests.cs b/test/OpenFeature.Tests/OpenFeatureHookTests.cs index cebe40c0..d1b63dae 100644 --- a/test/OpenFeature.Tests/OpenFeatureHookTests.cs +++ b/test/OpenFeature.Tests/OpenFeatureHookTests.cs @@ -1,9 +1,4 @@ -using System; -using System.Collections.Generic; using System.Collections.Immutable; -using System.Linq; -using System.Threading; -using System.Threading.Tasks; using AutoFixture; using NSubstitute; using NSubstitute.ExceptionExtensions; diff --git a/test/OpenFeature.Tests/OpenFeatureTests.cs b/test/OpenFeature.Tests/OpenFeatureTests.cs index 6afcc91c..f3c0f5f7 100644 --- a/test/OpenFeature.Tests/OpenFeatureTests.cs +++ b/test/OpenFeature.Tests/OpenFeatureTests.cs @@ -1,6 +1,3 @@ -using System; -using System.Linq; -using System.Threading.Tasks; using NSubstitute; using OpenFeature.Constant; using OpenFeature.Model; diff --git a/test/OpenFeature.Tests/ProviderRepositoryTests.cs b/test/OpenFeature.Tests/ProviderRepositoryTests.cs index 16fb5d13..4d250135 100644 --- a/test/OpenFeature.Tests/ProviderRepositoryTests.cs +++ b/test/OpenFeature.Tests/ProviderRepositoryTests.cs @@ -1,5 +1,3 @@ -using System; -using System.Threading.Tasks; using NSubstitute; using OpenFeature.Constant; using OpenFeature.Model; diff --git a/test/OpenFeature.Tests/Providers/Memory/InMemoryProviderTests.cs b/test/OpenFeature.Tests/Providers/Memory/InMemoryProviderTests.cs index 6a196fd5..42074bf5 100644 --- a/test/OpenFeature.Tests/Providers/Memory/InMemoryProviderTests.cs +++ b/test/OpenFeature.Tests/Providers/Memory/InMemoryProviderTests.cs @@ -1,5 +1,3 @@ -using System.Collections.Generic; -using System.Threading.Tasks; using OpenFeature.Constant; using OpenFeature.Error; using OpenFeature.Model; diff --git a/test/OpenFeature.Tests/StructureTests.cs b/test/OpenFeature.Tests/StructureTests.cs index 484e2b19..b0d5c210 100644 --- a/test/OpenFeature.Tests/StructureTests.cs +++ b/test/OpenFeature.Tests/StructureTests.cs @@ -1,5 +1,3 @@ -using System; -using System.Collections.Generic; using System.Collections.Immutable; using OpenFeature.Model; using Xunit; diff --git a/test/OpenFeature.Tests/Telemetry/EvaluationEventBuilderTests.cs b/test/OpenFeature.Tests/Telemetry/EvaluationEventBuilderTests.cs index 3b02a8ee..13bbe0b8 100644 --- a/test/OpenFeature.Tests/Telemetry/EvaluationEventBuilderTests.cs +++ b/test/OpenFeature.Tests/Telemetry/EvaluationEventBuilderTests.cs @@ -1,4 +1,3 @@ -using System.Collections.Generic; using OpenFeature.Constant; using OpenFeature.Model; using OpenFeature.Telemetry; diff --git a/test/OpenFeature.Tests/TestImplementations.cs b/test/OpenFeature.Tests/TestImplementations.cs index 4c298c88..87ca4fa0 100644 --- a/test/OpenFeature.Tests/TestImplementations.cs +++ b/test/OpenFeature.Tests/TestImplementations.cs @@ -1,8 +1,4 @@ -using System; -using System.Collections.Generic; using System.Collections.Immutable; -using System.Threading; -using System.Threading.Tasks; using OpenFeature.Constant; using OpenFeature.Model; diff --git a/test/OpenFeature.Tests/TestUtils.cs b/test/OpenFeature.Tests/TestUtils.cs index 15348db2..1487b928 100644 --- a/test/OpenFeature.Tests/TestUtils.cs +++ b/test/OpenFeature.Tests/TestUtils.cs @@ -1,8 +1,3 @@ -using System; -using System.Collections.Generic; -using System.Threading; -using System.Threading.Tasks; - internal class Utils { /// diff --git a/test/OpenFeature.Tests/TestUtilsTest.cs b/test/OpenFeature.Tests/TestUtilsTest.cs index ab7867ba..55342080 100644 --- a/test/OpenFeature.Tests/TestUtilsTest.cs +++ b/test/OpenFeature.Tests/TestUtilsTest.cs @@ -1,5 +1,3 @@ -using System; -using System.Threading.Tasks; using Xunit; namespace OpenFeature.Tests; diff --git a/test/OpenFeature.Tests/TrackingEventDetailsTest.cs b/test/OpenFeature.Tests/TrackingEventDetailsTest.cs index 22b1ce45..cf007a95 100644 --- a/test/OpenFeature.Tests/TrackingEventDetailsTest.cs +++ b/test/OpenFeature.Tests/TrackingEventDetailsTest.cs @@ -1,5 +1,3 @@ -using System; -using System.Collections.Generic; using OpenFeature.Model; using OpenFeature.Tests.Internal; using Xunit; diff --git a/test/OpenFeature.Tests/ValueTests.cs b/test/OpenFeature.Tests/ValueTests.cs index 34a2eb6b..335073c3 100644 --- a/test/OpenFeature.Tests/ValueTests.cs +++ b/test/OpenFeature.Tests/ValueTests.cs @@ -1,5 +1,3 @@ -using System; -using System.Collections.Generic; using OpenFeature.Model; using Xunit; From 8e8c0db6c1bcbb9861b311584f10e3ac6ca8abcf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Silva?= <2493377+askpt@users.noreply.github.com> Date: Mon, 19 May 2025 16:13:22 +0100 Subject: [PATCH 6/8] chore: remove Release configuration property group for TreatWarningsAsErrors MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com> --- build/Common.props | 4 ---- 1 file changed, 4 deletions(-) diff --git a/build/Common.props b/build/Common.props index 77715cc3..287b3231 100644 --- a/build/Common.props +++ b/build/Common.props @@ -19,10 +19,6 @@ true - - true - - From 19347ae5bd83948329f39c41c6a03b88745eb313 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Silva?= <2493377+askpt@users.noreply.github.com> Date: Mon, 19 May 2025 16:17:08 +0100 Subject: [PATCH 7/8] chore: remove Xunit using directives from multiple test files MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com> --- build/Common.tests.props | 1 + .../FeatureLifecycleManagerTests.cs | 1 - .../OpenFeatureBuilderExtensionsTests.cs | 1 - .../OpenFeatureServiceCollectionExtensionsTests.cs | 1 - .../Steps/ContextMergingPrecedenceStepDefinitions.cs | 1 - test/OpenFeature.E2ETests/Steps/EvaluationStepDefinitions.cs | 1 - test/OpenFeature.E2ETests/Steps/HooksStepDefinitions.cs | 1 - test/OpenFeature.E2ETests/Steps/MetadataStepDefinitions.cs | 1 - .../OpenFeature.IntegrationTests.csproj | 4 ---- .../AsyncLocalTransactionContextPropagatorTests.cs | 1 - test/OpenFeature.Tests/ClearOpenFeatureInstanceFixture.cs | 2 -- test/OpenFeature.Tests/FeatureProviderExceptionTests.cs | 1 - test/OpenFeature.Tests/FeatureProviderTests.cs | 1 - test/OpenFeature.Tests/HookDataTests.cs | 1 - test/OpenFeature.Tests/Hooks/LoggingHookTests.cs | 1 - test/OpenFeature.Tests/ImmutableMetadataTest.cs | 1 - test/OpenFeature.Tests/OpenFeatureClientTests.cs | 1 - test/OpenFeature.Tests/OpenFeatureEvaluationContextTests.cs | 1 - test/OpenFeature.Tests/OpenFeatureEventTests.cs | 1 - test/OpenFeature.Tests/OpenFeatureHookTests.cs | 1 - test/OpenFeature.Tests/OpenFeatureTests.cs | 1 - test/OpenFeature.Tests/ProviderRepositoryTests.cs | 1 - .../Providers/Memory/InMemoryProviderTests.cs | 1 - test/OpenFeature.Tests/StructureTests.cs | 1 - .../Telemetry/EvaluationEventBuilderTests.cs | 1 - test/OpenFeature.Tests/TestUtilsTest.cs | 2 -- test/OpenFeature.Tests/TrackingEventDetailsTest.cs | 1 - test/OpenFeature.Tests/ValueTests.cs | 1 - 28 files changed, 1 insertion(+), 32 deletions(-) diff --git a/build/Common.tests.props b/build/Common.tests.props index 3aac9cf9..238693ce 100644 --- a/build/Common.tests.props +++ b/build/Common.tests.props @@ -13,6 +13,7 @@ PreserveNewest + diff --git a/test/OpenFeature.DependencyInjection.Tests/FeatureLifecycleManagerTests.cs b/test/OpenFeature.DependencyInjection.Tests/FeatureLifecycleManagerTests.cs index db9ac4e0..8dc6a80b 100644 --- a/test/OpenFeature.DependencyInjection.Tests/FeatureLifecycleManagerTests.cs +++ b/test/OpenFeature.DependencyInjection.Tests/FeatureLifecycleManagerTests.cs @@ -4,7 +4,6 @@ using OpenFeature.Constant; using OpenFeature.DependencyInjection.Internal; using OpenFeature.Model; -using Xunit; namespace OpenFeature.DependencyInjection.Tests; diff --git a/test/OpenFeature.DependencyInjection.Tests/OpenFeatureBuilderExtensionsTests.cs b/test/OpenFeature.DependencyInjection.Tests/OpenFeatureBuilderExtensionsTests.cs index f742f98d..f1edca4c 100644 --- a/test/OpenFeature.DependencyInjection.Tests/OpenFeatureBuilderExtensionsTests.cs +++ b/test/OpenFeature.DependencyInjection.Tests/OpenFeatureBuilderExtensionsTests.cs @@ -2,7 +2,6 @@ using Microsoft.Extensions.Options; using OpenFeature.DependencyInjection.Internal; using OpenFeature.Model; -using Xunit; namespace OpenFeature.DependencyInjection.Tests; diff --git a/test/OpenFeature.DependencyInjection.Tests/OpenFeatureServiceCollectionExtensionsTests.cs b/test/OpenFeature.DependencyInjection.Tests/OpenFeatureServiceCollectionExtensionsTests.cs index d3ce5c8e..ddda3f22 100644 --- a/test/OpenFeature.DependencyInjection.Tests/OpenFeatureServiceCollectionExtensionsTests.cs +++ b/test/OpenFeature.DependencyInjection.Tests/OpenFeatureServiceCollectionExtensionsTests.cs @@ -1,6 +1,5 @@ using Microsoft.Extensions.DependencyInjection; using NSubstitute; -using Xunit; namespace OpenFeature.DependencyInjection.Tests; diff --git a/test/OpenFeature.E2ETests/Steps/ContextMergingPrecedenceStepDefinitions.cs b/test/OpenFeature.E2ETests/Steps/ContextMergingPrecedenceStepDefinitions.cs index 639ba22f..6ba9065f 100644 --- a/test/OpenFeature.E2ETests/Steps/ContextMergingPrecedenceStepDefinitions.cs +++ b/test/OpenFeature.E2ETests/Steps/ContextMergingPrecedenceStepDefinitions.cs @@ -1,6 +1,5 @@ using OpenFeature.E2ETests.Utils; using Reqnroll; -using Xunit; namespace OpenFeature.E2ETests.Steps; diff --git a/test/OpenFeature.E2ETests/Steps/EvaluationStepDefinitions.cs b/test/OpenFeature.E2ETests/Steps/EvaluationStepDefinitions.cs index a2e85429..3795727a 100644 --- a/test/OpenFeature.E2ETests/Steps/EvaluationStepDefinitions.cs +++ b/test/OpenFeature.E2ETests/Steps/EvaluationStepDefinitions.cs @@ -3,7 +3,6 @@ using OpenFeature.Extension; using OpenFeature.Model; using Reqnroll; -using Xunit; namespace OpenFeature.E2ETests.Steps; diff --git a/test/OpenFeature.E2ETests/Steps/HooksStepDefinitions.cs b/test/OpenFeature.E2ETests/Steps/HooksStepDefinitions.cs index c8882baa..8c1a6659 100644 --- a/test/OpenFeature.E2ETests/Steps/HooksStepDefinitions.cs +++ b/test/OpenFeature.E2ETests/Steps/HooksStepDefinitions.cs @@ -1,6 +1,5 @@ using OpenFeature.E2ETests.Utils; using Reqnroll; -using Xunit; namespace OpenFeature.E2ETests.Steps; diff --git a/test/OpenFeature.E2ETests/Steps/MetadataStepDefinitions.cs b/test/OpenFeature.E2ETests/Steps/MetadataStepDefinitions.cs index 7acbf917..3aae654f 100644 --- a/test/OpenFeature.E2ETests/Steps/MetadataStepDefinitions.cs +++ b/test/OpenFeature.E2ETests/Steps/MetadataStepDefinitions.cs @@ -1,7 +1,6 @@ using OpenFeature.E2ETests.Utils; using OpenFeature.Model; using Reqnroll; -using Xunit; namespace OpenFeature.E2ETests.Steps; diff --git a/test/OpenFeature.IntegrationTests/OpenFeature.IntegrationTests.csproj b/test/OpenFeature.IntegrationTests/OpenFeature.IntegrationTests.csproj index e8ddaa63..aabe1a59 100644 --- a/test/OpenFeature.IntegrationTests/OpenFeature.IntegrationTests.csproj +++ b/test/OpenFeature.IntegrationTests/OpenFeature.IntegrationTests.csproj @@ -22,8 +22,4 @@ - - - - diff --git a/test/OpenFeature.Tests/AsyncLocalTransactionContextPropagatorTests.cs b/test/OpenFeature.Tests/AsyncLocalTransactionContextPropagatorTests.cs index 51c94bfb..4c0ef544 100644 --- a/test/OpenFeature.Tests/AsyncLocalTransactionContextPropagatorTests.cs +++ b/test/OpenFeature.Tests/AsyncLocalTransactionContextPropagatorTests.cs @@ -1,5 +1,4 @@ using OpenFeature.Model; -using Xunit; namespace OpenFeature.Tests; diff --git a/test/OpenFeature.Tests/ClearOpenFeatureInstanceFixture.cs b/test/OpenFeature.Tests/ClearOpenFeatureInstanceFixture.cs index 23a5fa41..7ef471e4 100644 --- a/test/OpenFeature.Tests/ClearOpenFeatureInstanceFixture.cs +++ b/test/OpenFeature.Tests/ClearOpenFeatureInstanceFixture.cs @@ -1,5 +1,3 @@ -using Xunit; - namespace OpenFeature.Tests; public class ClearOpenFeatureInstanceFixture : IAsyncLifetime diff --git a/test/OpenFeature.Tests/FeatureProviderExceptionTests.cs b/test/OpenFeature.Tests/FeatureProviderExceptionTests.cs index c7a6646d..e1645269 100644 --- a/test/OpenFeature.Tests/FeatureProviderExceptionTests.cs +++ b/test/OpenFeature.Tests/FeatureProviderExceptionTests.cs @@ -1,7 +1,6 @@ using OpenFeature.Constant; using OpenFeature.Error; using OpenFeature.Extension; -using Xunit; namespace OpenFeature.Tests; diff --git a/test/OpenFeature.Tests/FeatureProviderTests.cs b/test/OpenFeature.Tests/FeatureProviderTests.cs index 13241f4b..8bea7037 100644 --- a/test/OpenFeature.Tests/FeatureProviderTests.cs +++ b/test/OpenFeature.Tests/FeatureProviderTests.cs @@ -3,7 +3,6 @@ using OpenFeature.Constant; using OpenFeature.Model; using OpenFeature.Tests.Internal; -using Xunit; namespace OpenFeature.Tests; diff --git a/test/OpenFeature.Tests/HookDataTests.cs b/test/OpenFeature.Tests/HookDataTests.cs index 1c937e05..0a6ee769 100644 --- a/test/OpenFeature.Tests/HookDataTests.cs +++ b/test/OpenFeature.Tests/HookDataTests.cs @@ -1,5 +1,4 @@ using OpenFeature.Model; -using Xunit; namespace OpenFeature.Tests; diff --git a/test/OpenFeature.Tests/Hooks/LoggingHookTests.cs b/test/OpenFeature.Tests/Hooks/LoggingHookTests.cs index 04b7ffd9..5c27959b 100644 --- a/test/OpenFeature.Tests/Hooks/LoggingHookTests.cs +++ b/test/OpenFeature.Tests/Hooks/LoggingHookTests.cs @@ -3,7 +3,6 @@ using OpenFeature.Constant; using OpenFeature.Hooks; using OpenFeature.Model; -using Xunit; namespace OpenFeature.Tests.Hooks; diff --git a/test/OpenFeature.Tests/ImmutableMetadataTest.cs b/test/OpenFeature.Tests/ImmutableMetadataTest.cs index b19b542c..e1324a05 100644 --- a/test/OpenFeature.Tests/ImmutableMetadataTest.cs +++ b/test/OpenFeature.Tests/ImmutableMetadataTest.cs @@ -1,6 +1,5 @@ using OpenFeature.Model; using OpenFeature.Tests.Internal; -using Xunit; namespace OpenFeature.Tests; diff --git a/test/OpenFeature.Tests/OpenFeatureClientTests.cs b/test/OpenFeature.Tests/OpenFeatureClientTests.cs index 55603eb5..cbecddc2 100644 --- a/test/OpenFeature.Tests/OpenFeatureClientTests.cs +++ b/test/OpenFeature.Tests/OpenFeatureClientTests.cs @@ -8,7 +8,6 @@ using OpenFeature.Extension; using OpenFeature.Model; using OpenFeature.Tests.Internal; -using Xunit; namespace OpenFeature.Tests; diff --git a/test/OpenFeature.Tests/OpenFeatureEvaluationContextTests.cs b/test/OpenFeature.Tests/OpenFeatureEvaluationContextTests.cs index 36a50dc1..9043ea43 100644 --- a/test/OpenFeature.Tests/OpenFeatureEvaluationContextTests.cs +++ b/test/OpenFeature.Tests/OpenFeatureEvaluationContextTests.cs @@ -1,7 +1,6 @@ using AutoFixture; using OpenFeature.Model; using OpenFeature.Tests.Internal; -using Xunit; namespace OpenFeature.Tests; diff --git a/test/OpenFeature.Tests/OpenFeatureEventTests.cs b/test/OpenFeature.Tests/OpenFeatureEventTests.cs index 27240443..45821899 100644 --- a/test/OpenFeature.Tests/OpenFeatureEventTests.cs +++ b/test/OpenFeature.Tests/OpenFeatureEventTests.cs @@ -3,7 +3,6 @@ using OpenFeature.Constant; using OpenFeature.Model; using OpenFeature.Tests.Internal; -using Xunit; namespace OpenFeature.Tests; diff --git a/test/OpenFeature.Tests/OpenFeatureHookTests.cs b/test/OpenFeature.Tests/OpenFeatureHookTests.cs index d1b63dae..22a0b17a 100644 --- a/test/OpenFeature.Tests/OpenFeatureHookTests.cs +++ b/test/OpenFeature.Tests/OpenFeatureHookTests.cs @@ -6,7 +6,6 @@ using OpenFeature.Error; using OpenFeature.Model; using OpenFeature.Tests.Internal; -using Xunit; namespace OpenFeature.Tests; diff --git a/test/OpenFeature.Tests/OpenFeatureTests.cs b/test/OpenFeature.Tests/OpenFeatureTests.cs index f3c0f5f7..9eb0aa40 100644 --- a/test/OpenFeature.Tests/OpenFeatureTests.cs +++ b/test/OpenFeature.Tests/OpenFeatureTests.cs @@ -2,7 +2,6 @@ using OpenFeature.Constant; using OpenFeature.Model; using OpenFeature.Tests.Internal; -using Xunit; namespace OpenFeature.Tests; diff --git a/test/OpenFeature.Tests/ProviderRepositoryTests.cs b/test/OpenFeature.Tests/ProviderRepositoryTests.cs index 4d250135..4284eaee 100644 --- a/test/OpenFeature.Tests/ProviderRepositoryTests.cs +++ b/test/OpenFeature.Tests/ProviderRepositoryTests.cs @@ -1,7 +1,6 @@ using NSubstitute; using OpenFeature.Constant; using OpenFeature.Model; -using Xunit; // We intentionally do not await for purposes of validating behavior. #pragma warning disable CS4014 // Because this call is not awaited, execution of the current method continues before the call is completed diff --git a/test/OpenFeature.Tests/Providers/Memory/InMemoryProviderTests.cs b/test/OpenFeature.Tests/Providers/Memory/InMemoryProviderTests.cs index 42074bf5..6b04f2f3 100644 --- a/test/OpenFeature.Tests/Providers/Memory/InMemoryProviderTests.cs +++ b/test/OpenFeature.Tests/Providers/Memory/InMemoryProviderTests.cs @@ -2,7 +2,6 @@ using OpenFeature.Error; using OpenFeature.Model; using OpenFeature.Providers.Memory; -using Xunit; namespace OpenFeature.Tests.Providers.Memory; diff --git a/test/OpenFeature.Tests/StructureTests.cs b/test/OpenFeature.Tests/StructureTests.cs index b0d5c210..b2b4e1c0 100644 --- a/test/OpenFeature.Tests/StructureTests.cs +++ b/test/OpenFeature.Tests/StructureTests.cs @@ -1,6 +1,5 @@ using System.Collections.Immutable; using OpenFeature.Model; -using Xunit; namespace OpenFeature.Tests; diff --git a/test/OpenFeature.Tests/Telemetry/EvaluationEventBuilderTests.cs b/test/OpenFeature.Tests/Telemetry/EvaluationEventBuilderTests.cs index 13bbe0b8..8bebd3f5 100644 --- a/test/OpenFeature.Tests/Telemetry/EvaluationEventBuilderTests.cs +++ b/test/OpenFeature.Tests/Telemetry/EvaluationEventBuilderTests.cs @@ -1,7 +1,6 @@ using OpenFeature.Constant; using OpenFeature.Model; using OpenFeature.Telemetry; -using Xunit; namespace OpenFeature.Tests.Telemetry; diff --git a/test/OpenFeature.Tests/TestUtilsTest.cs b/test/OpenFeature.Tests/TestUtilsTest.cs index 55342080..e414ee7f 100644 --- a/test/OpenFeature.Tests/TestUtilsTest.cs +++ b/test/OpenFeature.Tests/TestUtilsTest.cs @@ -1,5 +1,3 @@ -using Xunit; - namespace OpenFeature.Tests; public class TestUtilsTest diff --git a/test/OpenFeature.Tests/TrackingEventDetailsTest.cs b/test/OpenFeature.Tests/TrackingEventDetailsTest.cs index cf007a95..b704286f 100644 --- a/test/OpenFeature.Tests/TrackingEventDetailsTest.cs +++ b/test/OpenFeature.Tests/TrackingEventDetailsTest.cs @@ -1,6 +1,5 @@ using OpenFeature.Model; using OpenFeature.Tests.Internal; -using Xunit; namespace OpenFeature.Tests; diff --git a/test/OpenFeature.Tests/ValueTests.cs b/test/OpenFeature.Tests/ValueTests.cs index 335073c3..da76f29a 100644 --- a/test/OpenFeature.Tests/ValueTests.cs +++ b/test/OpenFeature.Tests/ValueTests.cs @@ -1,5 +1,4 @@ using OpenFeature.Model; -using Xunit; namespace OpenFeature.Tests; From 27f637522e2fad532e2dff35245c1b2e1ccf526e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Silva?= <2493377+askpt@users.noreply.github.com> Date: Mon, 19 May 2025 16:19:13 +0100 Subject: [PATCH 8/8] chore: remove Reqnroll using directive from multiple step definition files MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com> --- build/Common.tests.props | 4 ++++ test/OpenFeature.E2ETests/Steps/BaseStepDefinitions.cs | 1 - .../Steps/ContextMergingPrecedenceStepDefinitions.cs | 1 - test/OpenFeature.E2ETests/Steps/EvaluationStepDefinitions.cs | 1 - test/OpenFeature.E2ETests/Steps/HooksStepDefinitions.cs | 1 - test/OpenFeature.E2ETests/Steps/MetadataStepDefinitions.cs | 1 - 6 files changed, 4 insertions(+), 5 deletions(-) diff --git a/build/Common.tests.props b/build/Common.tests.props index 238693ce..054ad94d 100644 --- a/build/Common.tests.props +++ b/build/Common.tests.props @@ -16,6 +16,10 @@ + + + + diff --git a/test/OpenFeature.E2ETests/Steps/BaseStepDefinitions.cs b/test/OpenFeature.E2ETests/Steps/BaseStepDefinitions.cs index a0f36d0c..7a9c3c0a 100644 --- a/test/OpenFeature.E2ETests/Steps/BaseStepDefinitions.cs +++ b/test/OpenFeature.E2ETests/Steps/BaseStepDefinitions.cs @@ -1,7 +1,6 @@ using OpenFeature.E2ETests.Utils; using OpenFeature.Model; using OpenFeature.Providers.Memory; -using Reqnroll; namespace OpenFeature.E2ETests.Steps; diff --git a/test/OpenFeature.E2ETests/Steps/ContextMergingPrecedenceStepDefinitions.cs b/test/OpenFeature.E2ETests/Steps/ContextMergingPrecedenceStepDefinitions.cs index 6ba9065f..c95b2049 100644 --- a/test/OpenFeature.E2ETests/Steps/ContextMergingPrecedenceStepDefinitions.cs +++ b/test/OpenFeature.E2ETests/Steps/ContextMergingPrecedenceStepDefinitions.cs @@ -1,5 +1,4 @@ using OpenFeature.E2ETests.Utils; -using Reqnroll; namespace OpenFeature.E2ETests.Steps; diff --git a/test/OpenFeature.E2ETests/Steps/EvaluationStepDefinitions.cs b/test/OpenFeature.E2ETests/Steps/EvaluationStepDefinitions.cs index 3795727a..27e00359 100644 --- a/test/OpenFeature.E2ETests/Steps/EvaluationStepDefinitions.cs +++ b/test/OpenFeature.E2ETests/Steps/EvaluationStepDefinitions.cs @@ -2,7 +2,6 @@ using OpenFeature.E2ETests.Utils; using OpenFeature.Extension; using OpenFeature.Model; -using Reqnroll; namespace OpenFeature.E2ETests.Steps; diff --git a/test/OpenFeature.E2ETests/Steps/HooksStepDefinitions.cs b/test/OpenFeature.E2ETests/Steps/HooksStepDefinitions.cs index 8c1a6659..a79a616a 100644 --- a/test/OpenFeature.E2ETests/Steps/HooksStepDefinitions.cs +++ b/test/OpenFeature.E2ETests/Steps/HooksStepDefinitions.cs @@ -1,5 +1,4 @@ using OpenFeature.E2ETests.Utils; -using Reqnroll; namespace OpenFeature.E2ETests.Steps; diff --git a/test/OpenFeature.E2ETests/Steps/MetadataStepDefinitions.cs b/test/OpenFeature.E2ETests/Steps/MetadataStepDefinitions.cs index 3aae654f..033e9bd6 100644 --- a/test/OpenFeature.E2ETests/Steps/MetadataStepDefinitions.cs +++ b/test/OpenFeature.E2ETests/Steps/MetadataStepDefinitions.cs @@ -1,6 +1,5 @@ using OpenFeature.E2ETests.Utils; using OpenFeature.Model; -using Reqnroll; namespace OpenFeature.E2ETests.Steps;