Skip to content

[B2] Restore docs sidebar + footer chrome lost in the compiled-shell refactor (user-reported, hostile-audit/verifier miss) #1317

Description

@SisyphusZheng

User-reported and independently reproduced (explore investigation, stage #1288): the official website's docs sidebar and footer are broken/missing on the live site.

Evidence

  • Docs sidebar gone entirely: zero sidebar matches in www/app or built HTML; guide/docs/architecture pages have no section navigation. Meanwhile www/app/data/_generated-nav.ts still generates a full navSections tree that NOTHING consumes — dead generated truth.
  • Footer is a bare unstyled strip: www/app/islands/open-layout.tsx:242-245 has only border-top+background; render emits two spans + one link; orphaned @media (max-width:900px){.app-footer{padding:0}} at :269 references removed padding.
  • Root cause: 7bbef34b (compiled-shell refactor, ADR-0143, Aug 30) deleted 656 lines incl. .docs-sidebar/.nav-section and the rich 4-column footer; 7cb922a4 deleted the old shell tests instead of restoring the chrome. test(www,e2e): harden E2E selectors and cover the full public IA (#1232, B2.10) #1306's e2e hardening codified the regression (accessibility-performance.spec asserts zero footer headings).
  • Why the stage missed it (process lesson): public-route e2e asserts only main-landmark+h1 per route; visual baselines screenshot with fullPage:false (page-bottom footer never captured); hostile audit checked truth-derivation, not chrome completeness.

Acceptance

  • Docs/guide/architecture pages ship a real section sidebar consuming the generated navSections (or the generation is removed — no dead truth), usable on desktop and mobile.
  • Footer restored to a proper site footer (nav columns or equivalent, styled, bilingual), consistent across routes.
  • Coverage gap closed: e2e asserts sidebar + footer visibility/structure per layout class (semantic assertions, not pixel-only); visual baseline capture includes page bottom (fullPage or dedicated chrome snapshots). CI-gated.
  • Bilingual parity; all existing gates stay green (content-graph, www:check-truth, www:check-links incl. any new nav links).

Stage #1288. Part of #1155. This re-opens the Beta.2 website acceptance bar ('public information architecture is coherent') — the publish lane holds until this lands and re-verification passes.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions