From 47e73c9ff7aa7d87af1bb39ff0ac930b4842c920 Mon Sep 17 00:00:00 2001 From: gnana997 Date: Tue, 18 Mar 2025 21:06:01 +0530 Subject: [PATCH 1/4] added feature flag for sigs.k8s.io about api Signed-off-by: gnana997 --- feature/feature.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/feature/feature.go b/feature/feature.go index 81a8384d..18feaf21 100644 --- a/feature/feature.go +++ b/feature/feature.go @@ -23,6 +23,10 @@ const ( // itself to avoid impact to users. ClusterClaim featuregate.Feature = "ClusterClaim" + // ClusterProperty is a feature gate on hub controller and spoke-agent. When it is enabled on the + // spoke agent, it will use the claim controller to manage the managed cluster property + ClusterProperty featuregate.Feature = "ClusterProperty" + // AddonManagement is a feature gate on hub controller and spoke-agent. When it is enabled on the //spoke agent, it will start a new controllers to manage the managed cluster addons // registration and maintains the status of managed cluster addons through watching their leases. @@ -90,6 +94,7 @@ const ( // add it here. var DefaultSpokeRegistrationFeatureGates = map[featuregate.Feature]featuregate.FeatureSpec{ ClusterClaim: {Default: true, PreRelease: featuregate.Beta}, + ClusterProperty: {Default: true, PreRelease: featuregate.Beta}, AddonManagement: {Default: true, PreRelease: featuregate.Beta}, V1beta1CSRAPICompatibility: {Default: false, PreRelease: featuregate.Alpha}, MultipleHubs: {Default: false, PreRelease: featuregate.Alpha}, From 689d3ae482ce3aa09c52bd5e4281acb3dce04741 Mon Sep 17 00:00:00 2001 From: gnana997 Date: Wed, 19 Mar 2025 08:03:57 +0530 Subject: [PATCH 2/4] updated cluster property default to be false Signed-off-by: gnana997 --- feature/feature.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/feature/feature.go b/feature/feature.go index 18feaf21..9be4f89f 100644 --- a/feature/feature.go +++ b/feature/feature.go @@ -94,7 +94,7 @@ const ( // add it here. var DefaultSpokeRegistrationFeatureGates = map[featuregate.Feature]featuregate.FeatureSpec{ ClusterClaim: {Default: true, PreRelease: featuregate.Beta}, - ClusterProperty: {Default: true, PreRelease: featuregate.Beta}, + ClusterProperty: {Default: false, PreRelease: featuregate.Beta}, AddonManagement: {Default: true, PreRelease: featuregate.Beta}, V1beta1CSRAPICompatibility: {Default: false, PreRelease: featuregate.Alpha}, MultipleHubs: {Default: false, PreRelease: featuregate.Alpha}, From 8c3d68e4387862338a2d7d0694f76b8d47372949 Mon Sep 17 00:00:00 2001 From: gnana997 Date: Wed, 19 Mar 2025 12:35:33 +0530 Subject: [PATCH 3/4] updated cluster property to prerelease alpha Signed-off-by: gnana997 --- feature/feature.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/feature/feature.go b/feature/feature.go index 9be4f89f..edcfd87e 100644 --- a/feature/feature.go +++ b/feature/feature.go @@ -94,7 +94,7 @@ const ( // add it here. var DefaultSpokeRegistrationFeatureGates = map[featuregate.Feature]featuregate.FeatureSpec{ ClusterClaim: {Default: true, PreRelease: featuregate.Beta}, - ClusterProperty: {Default: false, PreRelease: featuregate.Beta}, + ClusterProperty: {Default: false, PreRelease: featuregate.Alpha}, AddonManagement: {Default: true, PreRelease: featuregate.Beta}, V1beta1CSRAPICompatibility: {Default: false, PreRelease: featuregate.Alpha}, MultipleHubs: {Default: false, PreRelease: featuregate.Alpha}, From 76dbee64ddb59b2e5e2aa6c0e705baba08d54383 Mon Sep 17 00:00:00 2001 From: gnana997 Date: Tue, 18 Mar 2025 21:06:01 +0530 Subject: [PATCH 4/4] added feature flag for sigs.k8s.io about api Signed-off-by: gnana997 --- feature/feature.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/feature/feature.go b/feature/feature.go index 81a8384d..edcfd87e 100644 --- a/feature/feature.go +++ b/feature/feature.go @@ -23,6 +23,10 @@ const ( // itself to avoid impact to users. ClusterClaim featuregate.Feature = "ClusterClaim" + // ClusterProperty is a feature gate on hub controller and spoke-agent. When it is enabled on the + // spoke agent, it will use the claim controller to manage the managed cluster property + ClusterProperty featuregate.Feature = "ClusterProperty" + // AddonManagement is a feature gate on hub controller and spoke-agent. When it is enabled on the //spoke agent, it will start a new controllers to manage the managed cluster addons // registration and maintains the status of managed cluster addons through watching their leases. @@ -90,6 +94,7 @@ const ( // add it here. var DefaultSpokeRegistrationFeatureGates = map[featuregate.Feature]featuregate.FeatureSpec{ ClusterClaim: {Default: true, PreRelease: featuregate.Beta}, + ClusterProperty: {Default: false, PreRelease: featuregate.Alpha}, AddonManagement: {Default: true, PreRelease: featuregate.Beta}, V1beta1CSRAPICompatibility: {Default: false, PreRelease: featuregate.Alpha}, MultipleHubs: {Default: false, PreRelease: featuregate.Alpha},