Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for some form struct based agent addon #293

Open
saswatamcode opened this issue Nov 29, 2024 · 2 comments
Open

Add support for some form struct based agent addon #293

saswatamcode opened this issue Nov 29, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@saswatamcode
Copy link

I would like to propose an idea for something like BuildStructAgentAddon, that takes in some interface{} which implements a Manifests() method which has default values and values you can pass in.

Essentially a downstream operator could just maintain the objects they manage as k8s structs instead of helm or Go templates, so such a function, makes it much easier for those operators to create agent addons based on pre-existing code. Also, has added benefit that linting/updating manifests/managing versions in Go is much easier.

@qiujian16
Copy link
Member

sorry for late reply, would you give some examples on this?

@qiujian16 qiujian16 added the enhancement New feature or request label Mar 10, 2025
@saswatamcode
Copy link
Author

@qiujian16 sorry for the confusing issue, this was written during a meeting. But essentially I was looking for a way to achieve this https://github.com/open-cluster-management-io/addon-framework/blob/main/examples/helloworld/helloworld.go example without embedding YAML files/helm charts, and instead passing k8s Go structs.

cc: @thibaultmg @JoaoBraveCoding as they have been working closely with this for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants