Skip to content

Conversation

@LDiazN
Copy link
Contributor

@LDiazN LDiazN commented Oct 1, 2025

Fixes several issues in the oonimeasurents component

Rewrites the /api/v1/measuremen_meta handler to be more similar to the monolith version

Also ports some measurement_meta related tests to the microservice

closes #1011

@LDiazN LDiazN requested a review from hellais October 1, 2025 11:56
@LDiazN LDiazN self-assigned this Oct 1, 2025
@LDiazN LDiazN marked this pull request as draft October 1, 2025 13:05
@LDiazN LDiazN changed the title Refs/heads/fix/measurements timestamp bug Several oonimeasurements fixes Oct 2, 2025
@LDiazN LDiazN marked this pull request as ready for review October 2, 2025 10:40
Copy link
Member

@hellais hellais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. I left few comments on improvements that are mostly cosmetic and some small bugs to address prior to merge.

After those are addressed this is good to go.

Thanks for putting it together.

@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 90.59829% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.11%. Comparing base (d943f03) to head (fb8c66a).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ts/src/oonimeasurements/routers/v1/measurements.py 83.67% 5 Missing and 3 partials ⚠️
...rvices/oonimeasurements/tests/test_measurements.py 95.45% 2 Missing and 1 partial ⚠️

❌ Your project check has failed because the head coverage (93.11%) is below the target coverage (95.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1012      +/-   ##
==========================================
+ Coverage   92.81%   93.11%   +0.29%     
==========================================
  Files          17       64      +47     
  Lines        1281     5647    +4366     
  Branches       65      360     +295     
==========================================
+ Hits         1189     5258    +4069     
- Misses         78      313     +235     
- Partials       14       76      +62     
Flag Coverage Δ
ooniauth 100.00% <ø> (?)
oonifindings 96.90% <ø> (?)
oonimeasurements 87.32% <90.59%> (?)
ooniprobe 92.81% <ø> (ø)
oonirun 99.39% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@hellais hellais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐳

@LDiazN LDiazN merged commit 7bf80d6 into master Oct 15, 2025
7 checks passed
@LDiazN LDiazN deleted the fix/measurements-timestamp-bug branch October 15, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Several oonimeasurements bugs

3 participants