-
Notifications
You must be signed in to change notification settings - Fork 32
Several oonimeasurements fixes #1012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good. I left few comments on improvements that are mostly cosmetic and some small bugs to address prior to merge.
After those are addressed this is good to go.
Thanks for putting it together.
ooniapi/services/oonimeasurements/src/oonimeasurements/routers/v1/measurements.py
Show resolved
Hide resolved
ooniapi/services/oonimeasurements/src/oonimeasurements/routers/v1/measurements.py
Outdated
Show resolved
Hide resolved
ooniapi/services/oonimeasurements/src/oonimeasurements/routers/v1/measurements.py
Outdated
Show resolved
Hide resolved
ooniapi/services/oonimeasurements/src/oonimeasurements/routers/v1/measurements.py
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is ❌ Your project check has failed because the head coverage (93.11%) is below the target coverage (95.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #1012 +/- ##
==========================================
+ Coverage 92.81% 93.11% +0.29%
==========================================
Files 17 64 +47
Lines 1281 5647 +4366
Branches 65 360 +295
==========================================
+ Hits 1189 5258 +4069
- Misses 78 313 +235
- Partials 14 76 +62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐳
Fixes several issues in the oonimeasurents component
Rewrites the
/api/v1/measuremen_metahandler to be more similar to the monolith versionAlso ports some
measurement_metarelated tests to the microservicecloses #1011