Skip to content

Create a tensor de-duplication pass #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
justinchuby opened this issue Jun 5, 2025 · 4 comments · May be fixed by #67
Open

Create a tensor de-duplication pass #66

justinchuby opened this issue Jun 5, 2025 · 4 comments · May be fixed by #67
Labels
contribution welcome good first issue Good for newcomers module: passes

Comments

@justinchuby
Copy link
Member

Pass to deduplicate initializers (model weights)
@AbhishekHerbertSamuel
Copy link

Hi! I'd love to work on this as a first-time contributor. Could you please assign it to me?

@justinchuby
Copy link
Member Author

Please feel free to create a PR. You can create the file in https://github.com/onnx/ir-py/tree/main/src/onnx_ir/passes/common

@AbhishekHerbertSamuel
Copy link

Sure, will do so. Thank you:)

AbhishekHerbertSamuel added a commit to AbhishekHerbertSamuel/ir-py that referenced this issue Jun 5, 2025
@AbhishekHerbertSamuel
Add deduplication pass for initializer tensors (onnx#66)
191ddb4
@AbhishekHerbertSamuel AbhishekHerbertSamuel linked a pull request Jun 5, 2025 that will close this issue
Open
@AbhishekHerbertSamuel
Copy link

Hi @justinchuby,

Thank you for creating this as a first-time contributor issue. I’ve submitted a PR here: #67 implementing the deduplication pass.

The logic aligns with the IR’s fingerprinting approach using (tobytes, dtype, shape) and updates graph nodes using replace_input_with(...). I’ve also documented the reasoning and structure inside the pass.

Looking forward to any feedback or suggestions you might have!

Best regards,
Abhishek

AbhishekHerbertSamuel added a commit to AbhishekHerbertSamuel/ir-py that referenced this issue Jun 5, 2025
@AbhishekHerbertSamuel
Add deduplication pass for initializer tensors (onnx#66)
159e89a 
Signed-off-by: Abhishek Herbert Samuel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribution welcome good first issue Good for newcomers module: passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add deduplication pass for initializer tensors (#66) AbhishekHerbertSamuel/ir-py
2 participants
@justinchuby @AbhishekHerbertSamuel