-
Notifications
You must be signed in to change notification settings - Fork 7
Description
Issue to be solved
Transactions for removing a listing from the storefront are generic, so they should work for any resource type.
But since the templates under templates/NFTCatalog
were generated using the NFT catalog tool, each project sub-directory contains its own {ProjectName}-StorefrontRemoveItem.mainnet.template.json
template file.
So if someone were to search for a "remove item" template, all these templates that essentially do the same thing would show up. Their labels would suggest that each template is built for a specific NFT collection, but that's not the case as they are generic. This makes this confusing and could present an unnecessary clutter in a template discovery tool.
I realized this when I was integrating template discovery support in Flowser:
Suggest A Solution
Deduplicate these templates, by creating a generic StorefrontRemoveItem
contract and remove all the other project-specific ones.
This shouldn't be a breaking change, since these templates only differ in comments which are not present in the AST that's used for hash calculation in the scope of reverse lookup (the /templates/search?cadence_base64=
endpoint).
What are you currently working on that this is blocking?
No response