Include human-friendly error messages on EVM transaction events #6836
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6836 +/- ##
==========================================
- Coverage 41.18% 41.17% -0.01%
==========================================
Files 2109 2109
Lines 185660 185669 +9
==========================================
- Hits 76460 76450 -10
- Misses 102788 102805 +17
- Partials 6412 6414 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
m-Peter
force-pushed
the
mpeter/evm-events-abi-decode-assert-errors
branch
2 times, most recently
from
2d8eb89 to
7fb6ff4
Compare
fvm/evm/events/events.go
Outdated
| errorMessage := p.Result.ErrorMsg() | ||
| if p.Result.ResultSummary().ErrorCode == types.ExecutionErrCodeExecutionReverted { | ||
| reason, errUnpack := abi.UnpackRevert(p.Result.ReturnedData) | ||
| if errUnpack == nil { | ||
| errorMessage = fmt.Sprintf("%v: %v", gethVM.ErrExecutionReverted.Error(), reason) | ||
| } | ||
| } |
There was a problem hiding this comment.
Can you make this a method on types.Result. Maybe call it ErrorMessageWithRevertReason or something.
There was a problem hiding this comment.
Nice idea 👌 Updated in e682cd2 .
m-Peter
force-pushed
the
mpeter/evm-events-abi-decode-assert-errors
branch
from
7fb6ff4 to
e682cd2
Compare
|
@janezpodhostnik @zhangchiqing This change affects only the |
Closes #6770