Skip to content

Commit 03b57ee

Browse files
authored
Merge pull request #272 from antjost/devGenCartTest
[IBM] Change checkCartesian non-regression test cases. We now compare boolean and instead of a PyTree, thereby making these non-regressoin test cases lighter.
2 parents 0d3f967 + 93c890c commit 03b57ee

File tree

4 files changed

+33
-104
lines changed

4 files changed

+33
-104
lines changed

Cassiopee/Generator/test/checkCartesian_m1.py

+9-28
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,9 @@
2323

2424
##Test 1 - Cartesian
2525
cartesian = G_IBM.checkCartesian(t)
26-
isCartesian = 0
27-
if cartesian: isCartesian=1
28-
Internal._createUniqueChild(t, 'TMP_Node', 'UserDefinedData_t')
29-
Internal._createUniqueChild(Internal.getNodeFromName1(t, 'TMP_Node'), 'Cartesian', 'DataArray_t', value=isCartesian)
3026
if Cmpi.rank == 0:
31-
test.testT(t,1)
32-
print('Is Cartesian::', cartesian, isCartesian)
27+
test.testO(cartesian,1)
28+
print('Is Cartesian::', cartesian)
3329
tsave = Internal.copyTree(t)
3430
#C.convertPyTree2File(t,'t_test1.cgns')
3531

@@ -38,14 +34,9 @@
3834
coord = Internal.getNodeFromName(Internal.getZones(t)[0],'CoordinateZ')[1]
3935
for i in range(6): coord[:,:,i] = coord[:,:,i]*i/10+coord[:,:,i]
4036
cartesian = G_IBM.checkCartesian(t)
41-
42-
isCartesian=0
43-
if cartesian: isCartesian=1
44-
Internal._createUniqueChild(t, 'TMP_Node', 'UserDefinedData_t')
45-
Internal._createUniqueChild(Internal.getNodeFromName1(t, 'TMP_Node'), 'Cartesian', 'DataArray_t', value=isCartesian)
4637
if Cmpi.rank == 0:
47-
test.testT(t,2)
48-
print('Is Cartesian::',cartesian,isCartesian)
38+
test.testO(cartesian,2)
39+
print('Is Cartesian::',cartesian)
4940
#C.convertPyTree2File(t,'t_test2.cgns')
5041

5142
## Test 3 - Y direction is non homogenous --> non Cartesian mesh
@@ -54,14 +45,9 @@
5445
coord = Internal.getNodeFromName(Internal.getZones(t)[0],'CoordinateY')[1]
5546
for i in range(6): coord[:,i,:] = coord[:,i,:]*i/10+coord[:,i,:]
5647
cartesian = G_IBM.checkCartesian(t)
57-
58-
isCartesian=0
59-
if cartesian:isCartesian=1
60-
Internal._createUniqueChild(t, 'TMP_Node', 'UserDefinedData_t')
61-
Internal._createUniqueChild(Internal.getNodeFromName1(t, 'TMP_Node'), 'Cartesian', 'DataArray_t', value=isCartesian)
6248
if Cmpi.rank == 0:
63-
test.testT(t,3)
64-
print('Is Cartesian::',cartesian,isCartesian)
49+
test.testO(cartesian,3)
50+
print('Is Cartesian::',cartesian)
6551
#C.convertPyTree2File(t,'t_test3.cgns')
6652

6753
## Test 4 - Z direction is non homogenous --> non Cartesian mesh
@@ -70,16 +56,11 @@
7056
coord = Internal.getNodeFromName(Internal.getZones(t)[0],'CoordinateX')[1]
7157
for i in range(6): coord[i,:,:] = coord[i,:,:]*i/10+coord[i,:,:]
7258
cartesian = G_IBM.checkCartesian(t)
73-
74-
isCartesian=0
75-
if cartesian:isCartesian=1
76-
Internal._createUniqueChild(t, 'TMP_Node', 'UserDefinedData_t')
77-
Internal._createUniqueChild(Internal.getNodeFromName1(t, 'TMP_Node'), 'Cartesian', 'DataArray_t', value=isCartesian)
7859
if Cmpi.rank == 0:
79-
test.testT(t,4)
80-
print('Is Cartesian::',cartesian,isCartesian)
60+
test.testO(cartesian,4)
61+
print('Is Cartesian::',cartesian)
8162
#C.convertPyTree2File(t,'t_test4.cgns')
8263

8364
del t
8465
del tsave
85-
if Cmpi.rank == 0: os.remove(LOCAL+'/t_TMP.cgns')
66+
if Cmpi.rank == 0: os.remove(LOCAL+'/t_TMP.cgns')

Cassiopee/Generator/test/checkCartesian_t1.py

+9-28
Original file line numberDiff line numberDiff line change
@@ -12,27 +12,18 @@
1212

1313
##Test 1 - Cartesian
1414
cartesian=G_IBM.checkCartesian(t)
15-
isCartesian=0
16-
if cartesian:isCartesian=1
17-
Internal._createUniqueChild(t, 'TMP_Node', 'UserDefinedData_t')
18-
Internal._createUniqueChild(Internal.getNodeFromName1(t, 'TMP_Node'), 'Cartesian', 'DataArray_t', value=isCartesian)
19-
test.testT(t,1)
15+
test.testO(cartesian,1)
2016
tsave = Internal.copyTree(t)
21-
print('Is Cartesian::',cartesian,isCartesian)
17+
print('Is Cartesian::',cartesian)
2218
#C.convertPyTree2File(t,'t_test1.cgns')
2319

2420
## Test 2 - Z direction is non homogenous --> non Cartesian mesh
2521
Internal._rmNode(t, Internal.getNodeFromName(t, 'TMP_Node'))
2622
coord = Internal.getNodeFromName(t,'CoordinateZ')[1]
2723
for i in range(6): coord[:,:,i]=coord[:,:,i]*i/10+coord[:,:,i]
2824
cartesian=G_IBM.checkCartesian(t)
29-
30-
isCartesian=0
31-
if cartesian:isCartesian=1
32-
Internal._createUniqueChild(t, 'TMP_Node', 'UserDefinedData_t')
33-
Internal._createUniqueChild(Internal.getNodeFromName1(t, 'TMP_Node'), 'Cartesian', 'DataArray_t', value=isCartesian)
34-
test.testT(t,2)
35-
print('Is Cartesian::',cartesian,isCartesian)
25+
test.testO(cartesian,2)
26+
print('Is Cartesian::',cartesian)
3627
#C.convertPyTree2File(t,'t_test2.cgns')
3728

3829
## Test 3 - Y direction is non homogenous --> non Cartesian mesh
@@ -41,26 +32,16 @@
4132
coord = Internal.getNodeFromName(t,'CoordinateY')[1]
4233
for i in range(6): coord[:,i,:]=coord[:,i,:]*i/10+coord[:,i,:]
4334
cartesian=G_IBM.checkCartesian(t)
44-
45-
isCartesian=0
46-
if cartesian:isCartesian=1
47-
Internal._createUniqueChild(t, 'TMP_Node', 'UserDefinedData_t')
48-
Internal._createUniqueChild(Internal.getNodeFromName1(t, 'TMP_Node'), 'Cartesian', 'DataArray_t', value=isCartesian)
49-
test.testT(t,3)
50-
print('Is Cartesian::',cartesian,isCartesian)
35+
test.testO(cartesian,3)
36+
print('Is Cartesian::',cartesian)
5137
#C.convertPyTree2File(t,'t_test3.cgns')
5238

53-
## Test 4 - Z direction is non homogenous --> non Cartesian mesh
39+
## Test 4 - X direction is non homogenous --> non Cartesian mesh
5440
t = Internal.copyTree(tsave)
5541
Internal._rmNode(t, Internal.getNodeFromName(t, 'TMP_Node'))
5642
coord = Internal.getNodeFromName(t,'CoordinateX')[1]
5743
for i in range(6): coord[i,:,:]=coord[i,:,:]*i/10+coord[i,:,:]
5844
cartesian=G_IBM.checkCartesian(t)
59-
60-
isCartesian=0
61-
if cartesian:isCartesian=1
62-
Internal._createUniqueChild(t, 'TMP_Node', 'UserDefinedData_t')
63-
Internal._createUniqueChild(Internal.getNodeFromName1(t, 'TMP_Node'), 'Cartesian', 'DataArray_t', value=isCartesian)
64-
test.testT(t,4)
65-
print('Is Cartesian::',cartesian,isCartesian)
45+
test.testO(cartesian,4)
46+
print('Is Cartesian::',cartesian)
6647
#C.convertPyTree2File(t,'t_test4.cgns')

Cassiopee/Generator/test/checkCartesian_t2.py

+7-21
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,9 @@
1212

1313
##Test 1 - Cartesian
1414
cartesian=G_IBM.checkCartesian(t)
15-
isCartesian=0
16-
if cartesian:isCartesian=1
17-
Internal._createUniqueChild(t, 'TMP_Node', 'UserDefinedData_t')
18-
Internal._createUniqueChild(Internal.getNodeFromName1(t, 'TMP_Node'), 'Cartesian', 'DataArray_t', value=isCartesian)
19-
test.testT(t,1)
15+
test.testO(cartesian,1)
2016
tsave = Internal.copyTree(t)
21-
print('Is Cartesian::',cartesian,isCartesian)
17+
print('Is Cartesian::',cartesian)
2218
#C.convertPyTree2File(t,'t_test1.cgns')
2319

2420
## Test 2 - Y direction is non homogenous --> non Cartesian mesh
@@ -27,26 +23,16 @@
2723
coord = Internal.getNodeFromName(t,'CoordinateY')[1]
2824
for i in range(6): coord[:,i,:]=coord[:,i,:]*i/10+coord[:,i,:]
2925
cartesian=G_IBM.checkCartesian(t)
30-
31-
isCartesian=0
32-
if cartesian:isCartesian=1
33-
Internal._createUniqueChild(t, 'TMP_Node', 'UserDefinedData_t')
34-
Internal._createUniqueChild(Internal.getNodeFromName1(t, 'TMP_Node'), 'Cartesian', 'DataArray_t', value=isCartesian)
35-
test.testT(t,2)
36-
print('Is Cartesian::',cartesian,isCartesian)
26+
test.testO(cartesian,2)
27+
print('Is Cartesian::',cartesian)
3728
#C.convertPyTree2File(t,'t_test2.cgns')
3829

39-
## Test 3 - Z direction is non homogenous --> non Cartesian mesh
30+
## Test 3 - X direction is non homogenous --> non Cartesian mesh
4031
t = Internal.copyTree(tsave)
4132
Internal._rmNode(t, Internal.getNodeFromName(t, 'TMP_Node'))
4233
coord = Internal.getNodeFromName(t,'CoordinateX')[1]
4334
for i in range(6): coord[i,:,:]=coord[i,:,:]*i/10+coord[i,:,:]
4435
cartesian=G_IBM.checkCartesian(t)
45-
46-
isCartesian=0
47-
if cartesian:isCartesian=1
48-
Internal._createUniqueChild(t, 'TMP_Node', 'UserDefinedData_t')
49-
Internal._createUniqueChild(Internal.getNodeFromName1(t, 'TMP_Node'), 'Cartesian', 'DataArray_t', value=isCartesian)
50-
test.testT(t,3)
51-
print('Is Cartesian::',cartesian,isCartesian)
36+
test.testO(cartesian,3)
37+
print('Is Cartesian::',cartesian)
5238
#C.convertPyTree2File(t,'t_test3.cgns')

Cassiopee/Generator/test/checkCartesian_t3.py

+8-27
Original file line numberDiff line numberDiff line change
@@ -14,27 +14,18 @@
1414

1515
##Test 1 - Cartesian
1616
cartesian=G_IBM.checkCartesian(t)
17-
isCartesian=0
18-
if cartesian:isCartesian=1
19-
Internal._createUniqueChild(t, 'TMP_Node', 'UserDefinedData_t')
20-
Internal._createUniqueChild(Internal.getNodeFromName1(t, 'TMP_Node'), 'Cartesian', 'DataArray_t', value=isCartesian)
21-
test.testT(t,1)
17+
test.testO(cartesian,1)
2218
tsave = Internal.copyTree(t)
23-
print('Is Cartesian::',cartesian,isCartesian)
19+
print('Is Cartesian::',cartesian)
2420
#C.convertPyTree2File(t,'t_test1.cgns')
2521

2622
## Test 2 - Z direction is non homogenous --> non Cartesian mesh
2723
Internal._rmNode(t, Internal.getNodeFromName(t, 'TMP_Node'))
2824
coord = Internal.getNodeFromName(Internal.getZones(t)[0],'CoordinateZ')[1]
2925
for i in range(6): coord[:,:,i]=coord[:,:,i]*i/10+coord[:,:,i]
3026
cartesian=G_IBM.checkCartesian(t)
31-
32-
isCartesian=0
33-
if cartesian:isCartesian=1
34-
Internal._createUniqueChild(t, 'TMP_Node', 'UserDefinedData_t')
35-
Internal._createUniqueChild(Internal.getNodeFromName1(t, 'TMP_Node'), 'Cartesian', 'DataArray_t', value=isCartesian)
36-
test.testT(t,2)
37-
print('Is Cartesian::',cartesian,isCartesian)
27+
test.testO(cartesian,2)
28+
print('Is Cartesian::',cartesian)
3829
#C.convertPyTree2File(t,'t_test2.cgns')
3930

4031
## Test 3 - Y direction is non homogenous --> non Cartesian mesh
@@ -43,13 +34,8 @@
4334
coord = Internal.getNodeFromName(Internal.getZones(t)[0],'CoordinateY')[1]
4435
for i in range(6): coord[:,i,:]=coord[:,i,:]*i/10+coord[:,i,:]
4536
cartesian=G_IBM.checkCartesian(t)
46-
47-
isCartesian=0
48-
if cartesian:isCartesian=1
49-
Internal._createUniqueChild(t, 'TMP_Node', 'UserDefinedData_t')
50-
Internal._createUniqueChild(Internal.getNodeFromName1(t, 'TMP_Node'), 'Cartesian', 'DataArray_t', value=isCartesian)
51-
test.testT(t,3)
52-
print('Is Cartesian::',cartesian,isCartesian)
37+
test.testO(cartesian,3)
38+
print('Is Cartesian::',cartesian)
5339
#C.convertPyTree2File(t,'t_test3.cgns')
5440

5541
## Test 4 - Z direction is non homogenous --> non Cartesian mesh
@@ -58,11 +44,6 @@
5844
coord = Internal.getNodeFromName(Internal.getZones(t)[0],'CoordinateX')[1]
5945
for i in range(6): coord[i,:,:]=coord[i,:,:]*i/10+coord[i,:,:]
6046
cartesian=G_IBM.checkCartesian(t)
61-
62-
isCartesian=0
63-
if cartesian:isCartesian=1
64-
Internal._createUniqueChild(t, 'TMP_Node', 'UserDefinedData_t')
65-
Internal._createUniqueChild(Internal.getNodeFromName1(t, 'TMP_Node'), 'Cartesian', 'DataArray_t', value=isCartesian)
66-
test.testT(t,4)
67-
print('Is Cartesian::',cartesian,isCartesian)
47+
test.testO(cartesian,4)
48+
print('Is Cartesian::',cartesian)
6849
#C.convertPyTree2File(t,'t_test4.cgns')

0 commit comments

Comments
 (0)