Merge pull request #1535 from bratpiorka/rrudnick_coverity_fix

coverity fixes

Author: ldorau

examples/ctl/ctl.c

@@ -66,9 +66,6 @@ static bool report_pool_stat_failure(const char *label,
             reason = "slab statistics";
         } else if (hint_level == 2) {
             reason = "allocation counters";
-        } else if (hint_level < 3) {
-            hint_level = 2;
-            reason = "allocation counters";
         } else {
             hint_level = 3;
         }

test/common/level_zero_mocks.cpp

@@ -99,6 +99,9 @@ TestCreateMemoryAllocationProperties(uint32_t modifier) {
 void MockedLevelZeroTestEnvironment::SetUp() {
     const char *lib_name = getenv("UMF_ZE_LOADER_LIB_NAME");
     ASSERT_NE(lib_name, nullptr);
+    if (lib_name == nullptr) {
+        return; // to avoid nullptr deref coverity issue
+    }
     ASSERT_NE(lib_name[0], '\0');
 
     lib_handle = utils_open_library(lib_name, 0);

test/pools/pool_residency.cpp

@@ -176,7 +176,12 @@ TEST_F(PoolResidencyTestFixture,
 }
 
 int main(int argc, char **argv) {
-    InitGoogleTest(&argc, argv);
-    AddGlobalTestEnvironment(new MockedLevelZeroTestEnvironment);
-    return RUN_ALL_TESTS();
+    try {
+        InitGoogleTest(&argc, argv);
+        AddGlobalTestEnvironment(new MockedLevelZeroTestEnvironment);
+        return RUN_ALL_TESTS();
+    } catch (...) {
+        std::cerr << "Exception occurred." << std::endl;
+        return 1;
+    }
 }

test/providers/provider_level_zero_residency.cpp

@@ -83,7 +83,12 @@ TEST_F(LevelZeroResidencyTestFixture, removeDeviceTwiceShouldFail) {
 }
 
 int main(int argc, char **argv) {
-    InitGoogleTest(&argc, argv);
-    AddGlobalTestEnvironment(new MockedLevelZeroTestEnvironment);
-    return RUN_ALL_TESTS();
+    try {
+        InitGoogleTest(&argc, argv);
+        AddGlobalTestEnvironment(new MockedLevelZeroTestEnvironment);
+        return RUN_ALL_TESTS();
+    } catch (...) {
+        std::cerr << "Exception occurred." << std::endl;
+        return 1;
+    }
 }