-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x64: updates for brgemm kernel and avx2 brgemm convolutions #2420
Open
ankalinin
wants to merge
10
commits into
main
Choose a base branch
from
akalinin/avx2_brgemm_conv_pr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform:cpu-x64
Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64
label
Jan 15, 2025
make test |
ankalinin
force-pushed
the
akalinin/avx2_brgemm_conv_pr
branch
4 times, most recently
from
January 16, 2025 18:42
555c553
to
ccce0f8
Compare
ankalinin
changed the title
[WIP] x64: updates for brgemm kernel and avx2 brgemm convolutions
x64: updates for brgemm kernel and avx2 brgemm convolutions
Jan 16, 2025
ankalinin
force-pushed
the
akalinin/avx2_brgemm_conv_pr
branch
from
January 16, 2025 19:25
ccce0f8
to
e359903
Compare
github-actions
bot
added
the
platform:cpu-aarch64
Codeowner: @oneapi-src/onednn-cpu-aarch64
label
Jan 16, 2025
ankalinin
force-pushed
the
akalinin/avx2_brgemm_conv_pr
branch
from
January 16, 2025 19:29
e359903
to
c00d9d9
Compare
@Radu2k could you have a look at the aarch64 changes? Thanks |
Radu2k
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, also no regressions in terms of performance. Thanks!
ankalinin
force-pushed
the
akalinin/avx2_brgemm_conv_pr
branch
from
January 17, 2025 19:28
c00d9d9
to
69b80e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:tests
Codeowner: @oneapi-src/onednn-arch
platform:cpu-aarch64
Codeowner: @oneapi-src/onednn-cpu-aarch64
platform:cpu-x64
Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request contains a few general brgemm code changes and some performance updates for avx2:
Performance testing by openvino on MTL. Here are a ratio brgemm to jit implementation for rls-v3.5 and for this brgemm update over v3.5: