Fix flaky test (#1192)

* Wait for view to be actionable in test.

* Be precise with node-version and add ssh debug

* Remove noise

Author: peterMuriuki

.github/workflows/cd-test.yml

@@ -11,15 +11,15 @@ jobs:
   test:
     strategy:
       matrix:
-        node-version: [16.x]
+        node-version: [16.17.0]
         os: [ubuntu-latest, windows-latest]
     runs-on: ${{ matrix.os }}
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
 
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v2
+        uses: actions/setup-node@v3
         with:
           node-version: ${{ matrix.node-version }}
           cache: "yarn"

packages/fhir-location-management/src/components/AddEditLocationUnit/tests/index.test.tsx

@@ -11,7 +11,7 @@ import { locationHierarchyResourceType } from '../../../constants';
 import { fhirHierarchy } from '../../../ducks/tests/fixtures';
 import { waitForElementToBeRemoved } from '@testing-library/dom';
 import { createdLocation1 } from '../../LocationForm/tests/fixtures';
-import { cleanup, render, screen } from '@testing-library/react';
+import { cleanup, render, screen, waitFor } from '@testing-library/react';
 
 jest.mock('fhirclient', () => {
   return jest.requireActual('fhirclient/lib/entry/browser');
@@ -94,11 +94,9 @@ test('renders correctly for new locations', async () => {
 
   await waitForElementToBeRemoved(document.querySelector('.ant-spin'));
 
-  expect(document.querySelector('title')).toMatchInlineSnapshot(`
-    <title>
-      Add Location Unit
-    </title>
-  `);
+  await waitFor(() => {
+    expect(screen.getByText('Add Location Unit')).toBeInTheDocument();
+  });
 
   // some small but inconclusive proof that the form rendered
   expect(screen.getByLabelText(/name/i)).toMatchSnapshot('name field');

packages/fhir-team-management/src/components/AddEditOrganization/tests/index.test.tsx

@@ -6,7 +6,7 @@ import { AddEditOrganization } from '..';
 import { Provider } from 'react-redux';
 import { store } from '@opensrp/store';
 import nock from 'nock';
-import { cleanup, render, screen } from '@testing-library/react';
+import { cleanup, render, screen, waitFor } from '@testing-library/react';
 import { waitForElementToBeRemoved } from '@testing-library/dom';
 import { createMemoryHistory } from 'history';
 import { authenticateUser } from '@onaio/session-reducer';
@@ -127,11 +127,9 @@ test('renders correctly for edit locations', async () => {
 
   expect(nock.pendingMocks()).toEqual([]);
 
-  expect(document.querySelector('title')).toMatchInlineSnapshot(`
-    <title>
-      Edit team | OpenSRP web Test Organisation
-    </title>
-  `);
+  await waitFor(() => {
+    expect(screen.getByText('Edit team | OpenSRP web Test Organisation')).toBeInTheDocument();
+  });
 
   // some small but incoclusive proof that the form rendered and has some initial values
   expect(screen.getByLabelText(/name/i)).toMatchSnapshot('name field');