Skip to content

feat(web): unify touch resize interactions - #4839

Open
btli wants to merge 6 commits into
omnigent-ai:mainfrom
btli:codex/touch-interactions-consolidated
Open

feat(web): unify touch resize interactions#4839
btli wants to merge 6 commits into
omnigent-ai:mainfrom
btli:codex/touch-interactions-consolidated

Conversation

@btli

@btli btli commented Aug 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Related issue

Part of #4790 — consolidates draft PRs #4780, #4781, #4782, #4784, #4785, and #4786.

Summary

This draft replaces the six touch-interaction drafts with one current-main implementation. It unifies pointer capture, cancellation, persistence, accessible separators, and carefully bounded hit gutters across the sidebar, inline workspace rail, terminal-list column, push panels, and comments panel. It also centralizes viewport and input-capability detection for web and Android.

ELI5: the thin dividers between app panes now have a larger invisible grab area, so a finger or stylus can resize them without covering nearby buttons or scrollbars.

sidebar | chat | inline rail | push panel
                 terminal list | terminal
file viewer | comments
       touch / pen / mouse / keyboard

Supersedes (but does not close): #4780, #4781, #4782, #4784, #4785, #4786.

Test Plan

  • bun --bun run test -- <17 touched Vitest files> — 626 passed, 1 expected failure.
  • uv run --group test pytest -q <5 touched e2e_ui files> — 5 passed.
  • Android OmnigentWebViewClientTest — 20 passed.
  • bun --bun run lint, bun --bun run type-check, and bun --bun run build — passed.
  • uv run pre-commit run --all-files — all applicable hooks passed; the current upstream uv.lock normalizer baseline was excluded because it rewrites an unrelated lockfile.
  • Mutation checks: every production-backed touched test file failed against the origin/main production tree, then passed with this implementation restored.

Demo

Android foldable/tablet touch-interactions video (Show taps enabled; touch dot visible)

The single recording covers folding/form-factor changes plus sidebar, inline rail, terminal-list column, push-panel, comments-panel, and adjacent-scroll seam behavior.

Type of change

  • Bug fix
  • Feature
  • UI / frontend change
  • Refactor / chore
  • Docs
  • Test / CI
  • Breaking change

Test coverage

  • Unit tests added / updated
  • Integration tests added / updated
  • E2E tests added / updated
  • Manual verification completed
  • Existing tests cover this change
  • Not applicable

Coverage notes

Manually verified the Android foldable/tablet recording with Developer Options “Show taps” enabled, including the visible touch dot and each resize/scroll seam represented by the six superseded drafts.

Changelog

Pane dividers are now easier and more reliable to resize with touch, stylus, mouse, or keyboard.

@github-actions github-actions Bot added the size/XL Pull request size: XL label Aug 15, 2026
@btli
btli force-pushed the codex/touch-interactions-consolidated branch 3 times, most recently from 0b69766 to 53e8a8a Compare August 15, 2026 18:08
btli pushed a commit to btli/omnigent that referenced this pull request Aug 15, 2026
omnigent-staging
staging: merge PR omnigent-ai#4839 (codex/touch-interactions-consolid…
e382d56 
…ated @ 53e8a8a)
This was referenced Aug 15, 2026
Closed
Open
btli pushed a commit to btli/omnigent that referenced this pull request Aug 15, 2026
omnigent-staging
staging: merge PR omnigent-ai#4839 (codex/touch-interactions-consolid…
a690fff 
…ated @ 53e8a8a)
btli pushed a commit to btli/omnigent that referenced this pull request Aug 17, 2026
omnigent-staging
staging: merge PR omnigent-ai#4839 (codex/touch-interactions-consolid…
17bd26a 
…ated @ 53e8a8a)
btli pushed a commit to btli/omnigent that referenced this pull request Aug 17, 2026
omnigent-staging
staging: merge PR omnigent-ai#4839 (codex/touch-interactions-consolid…
b40557a 
…ated @ 53e8a8a)
btli and others added 3 commits August 17, 2026 16:24
@btli omnigent
feat(web): unify touch resize interactions
beaa235 
Consolidate pointer, touch, stylus, and keyboard resize behavior across sidebar, inline rail, terminal column, push panels, and comments. Centralize responsive input capability and breakpoint handling for web and Android.

Signed-off-by: Bryan Li <bryan.li@gmail.com>
Co-authored-by: omnigent <noreply@omnigent.ai>
@btli omnigent
fix(web): tighten resize handle semantics
0fec6f7 
Signed-off-by: Bryan Li <bryan.li@gmail.com>
Co-authored-by: omnigent <noreply@omnigent.ai>
@btli omnigent
fix(web): react to terminal pointer capability changes
87a687c 
Signed-off-by: Bryan Li <bryan.li@gmail.com>
Co-authored-by: omnigent <noreply@omnigent.ai>
@btli
btli force-pushed the codex/touch-interactions-consolidated branch from 53e8a8a to f44a1ee Compare August 17, 2026 23:36
@btli
btli marked this pull request as ready for review August 17, 2026 23:36
@github-actions

github-actions Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

@btli Thanks for the PR! It doesn't reference an issue yet.

We require an issue for every PR, so the work can be prioritized before it's reviewed. Add one to the description:

  • Closes #123 if this PR finishes the issue. That links it, gives your PR the issue's priority, and closes the issue when this merges. You can also link it from the Development section of the sidebar.
  • Part of #123 if this is one step towards it. Related to, Towards, and Refs work the same way, and leave the issue open.

No issue exists for this yet? Open one first, then reference it. That's how we track what's worth doing, and it's usually quicker than it sounds. Note a reference has to point at an issue: naming another PR doesn't count.

The only exceptions are changes with no user-visible behaviour: pure Refactor / chore, Docs, or Test / CI work. If that's genuinely what this is, check that box under Type of change. Anything that fixes a bug, adds a feature, or changes the UI needs an issue, even when it also touches docs or tests.

See CONTRIBUTING.md for the full policy.

No action is taken beyond this comment.

@github-actions
github-actions Bot requested a review from daniellok-db August 17, 2026 23:36
btli pushed a commit to btli/omnigent that referenced this pull request Aug 17, 2026
omnigent-staging
staging: merge PR omnigent-ai#4839 (codex/touch-interactions-consolid…
e8c058c 
…ated @ f44a1ee)
btli and others added 3 commits August 17, 2026 16:51
@btli omnigent
refactor(web): reuse canonical resize breakpoint
c5b3342 
Signed-off-by: Bryan Li <bryan.li@gmail.com>
Co-authored-by: omnigent <noreply@omnigent.ai>
@btli omnigent
fix(web): close touch resize tribunal gaps
1620ec7 
Signed-off-by: Bryan Li <bryan.li@gmail.com>
Co-authored-by: omnigent <noreply@omnigent.ai>
@btli omnigent
fix(web): preserve transcript touch scroll at panel seam
f5dea90 
Signed-off-by: Bryan Li <bryan.li@gmail.com>
Co-authored-by: omnigent <noreply@omnigent.ai>
btli pushed a commit to btli/omnigent that referenced this pull request Aug 18, 2026
omnigent-staging
staging: merge PR omnigent-ai#4839 (codex/touch-interactions-consolid…
adb04a2 
…ated @ 17f71a3)
btli pushed a commit to btli/omnigent that referenced this pull request Aug 18, 2026
omnigent-staging
staging: merge PR omnigent-ai#4839 (codex/touch-interactions-consolid…
ab0696c 
…ated @ 17f71a3)
btli pushed a commit to btli/omnigent that referenced this pull request Aug 18, 2026
omnigent-staging
staging: merge PR omnigent-ai#4839 (codex/touch-interactions-consolid…
2c25a2e 
…ated @ 17f71a3)
@btli
btli force-pushed the codex/touch-interactions-consolidated branch from 17f71a3 to f5dea90 Compare August 18, 2026 13:20
btli pushed a commit to btli/omnigent that referenced this pull request Aug 18, 2026
omnigent-staging
staging: merge PR omnigent-ai#4839 (codex/touch-interactions-consolid…
ae25d63 
…ated @ f5dea90)
btli pushed a commit to btli/omnigent that referenced this pull request Aug 18, 2026
omnigent-staging
staging: merge PR omnigent-ai#4839 (codex/touch-interactions-consolid…
184defc 
…ated @ f5dea90)
btli pushed a commit to btli/omnigent that referenced this pull request Aug 18, 2026
omnigent-staging
staging: merge PR omnigent-ai#4839 (codex/touch-interactions-consolid…
a9d126c 
…ated @ f5dea90)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniellok-db daniellok-db Awaiting requested review from daniellok-db

Assignees

@daniellok-db daniellok-db

Labels

size/XL Pull request size: XL waiting-for-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@btli @daniellok-db