-
Notifications
You must be signed in to change notification settings - Fork 113
Closed
Milestone
Description
Since a year has passed since the last RubyGems release (1.4.5), I think it's time to publish a new release 1.4.6 or 1.5.0 (the latter may be preferred if included commits break backward compatibility).
Please note that ruby-units gem
1.4.5does exists in RubyGems.org, however it's not tagged in this git repository (in this repository, the latest tag is1.4.4).
Before publishing 1.4.6 (otherwise 1.5.0; depending on your choise), I think:
Date.rb is not namespaced #112 must be closed, since the corresponding PR Load RubyUnits::Unit instead of Date::Unit when overriding core #115 has been merged (thanks!)- Fix currency parsing stack limit too deep error #107 must be fixed, but need verification before merging.
- Make percentage units work like a unitless scalar. #108 must be merged, however, IMO, it must be included in next major release instead of minor release. You need further investigation on the included commits, too.
- Stack level too deep error #104 must be re-considered carefully. IMO, this PR has a great chance of producing a regression.
- Is RubyUnits::Unit#unit_name still used? #111 can be easily fixed since it seems to have no regression.
Incorrect exi and yebi binary prefix definitions #100 can be closed since the corresponding PR Correct exi prefix to exbi and yebi prefix to yobi #99 has already been merged to master.Strange Conversion? #102 must be rejected since ruby-units must handle expressions by rational. In principle, decimal results are incorrect in this library.
Metadata
Metadata
Assignees
Labels
No labels