Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory bug #46

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Fix memory bug #46

merged 1 commit into from
Nov 29, 2024

Conversation

ojwoodford
Copy link
Owner

Univariate problems were assumed to be small. When this wasn't the case, the resulting static arrays were too big, causing an error. This fixes the problem.

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.72%. Comparing base (4a372d6) to head (2111b5a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
- Coverage   86.14%   85.72%   -0.42%     
==========================================
  Files          19       19              
  Lines        1205     1205              
==========================================
- Hits         1038     1033       -5     
- Misses        167      172       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ojwoodford ojwoodford merged commit 2340947 into main Nov 29, 2024
4 of 5 checks passed
@@ -1,7 +1,7 @@
name = "NLLSsolver"
uuid = "50b5cf9e-bf7a-4e29-8981-4280cbba70cb"
authors = ["Oliver Woodford"]
version = "4.0.0"
version = "4.0.1"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try this instead: example

@ojwoodford ojwoodford deleted the FixMemoryIssue branch November 29, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants