fix(export): address PR #421 review — score-moving edits, error UI, wrap + reuse

Reviewer feedback from @Vaishnavi1709 (CHANGES_REQUESTED) and @Samhit21.

Blocking:
- #1 Added LinkedIn/GitHub link (guided picker → addedProfiles) now back-fills
  the empty legacy `_url` slot the scorer + contact gap read, so the add moves
  the score. applyProfileOverrides returns the back-filled keys.
- #2 Anonymous scorer now treats a GitHub link as satisfying the
  "Professional profile" completeness check (parity with the ContactCard rule),
  so a GitHub-but-no-LinkedIn résumé isn't docked / listed as missing LinkedIn.
- #3 applyOverrides returns an edited `fieldConfidence` (user-affirmed contact
  edits bumped to present, clears dropped to 0), threaded onto both the score
  input and displayResult so a typed-in / added link stops reading as absent
  against the frozen base parse.
- #4 useDownloadReport.download returns a boolean; the dialog closes only on
  success, so a generation failure no longer unmounts the error UI.
- #5 New shared src/lib/pdf/text-wrap.ts breaks a single overlong word at char
  boundaries (opt-in); the audit-report identity header uses it so a long URL
  no longer overflows the page.

Secondary:
- #6 Audit-report identity sourced via buildContact + basicsFromContact (no full
  buildAtsResumeModel + toJsonResume walk just to read .basics).
- #7 render-audit-report + serialize are now dynamic-imported in
  useDownloadReport, keeping the ~470 LOC report path out of the entry chunk.
- #8 Extracted src/lib/download/blob-download.ts (slugifyName +
  triggerBlobDownload); useDownloadPdf/useDownloadReport/useReportGap consume it.
- #9 wrapWordsToLines shared by both PDF renderers (render-ats-pdf keeps its
  no-mid-word-break contract; the report opts into breaking).
- #12 Achievements now map to JSON Resume `awards[]` (title + optional date;
  omitted entirely when absent, so achievement-free exports are byte-identical).

Nits:
- #14 usernameFromUrl drops its unreachable try/catch.
- #16 render-audit-report embeds Helvetica + Helvetica-Bold via Promise.all.
- #17 LinkedIn non-profile-path carve-out is now a `HostRule.nonProfilePath`
  field instead of an inline special case in the classify loop.

Deferred (with rationale in the PR reply): #10 override-channel consolidation,
#11 profiles-mirror memo split, #13 ISO-3166 location country codes, #15
unconditional profiles assign (breaks the empty-override no-op invariant), and
@Samhit21's non-profile-LinkedIn label nit (by-design).

Author: s-annam

src/components/features/DownloadReportDialog.tsx

@@ -52,8 +52,11 @@ export function ReportDownloadControl({
   );
 
   async function handleConfirm() {
-    await download({ format, includeIdentity });
-    setOpen(false);
+    // Close ONLY on success — a failed generation sets `error`, and closing
+    // here would unmount the dialog before the error line renders, leaving the
+    // user with no artifact and no message (#421 Blocking #4).
+    const ok = await download({ format, includeIdentity });
+    if (ok) setOpen(false);
   }
 
   return (

src/hooks/useAnalyzedResume.ts

@@ -49,13 +49,19 @@ import {
 import type {
   CascadeResult,
   HeuristicParsedResume,
+  FieldConfidence,
 } from "../lib/heuristics/types.ts";
 import { buildBlankResult } from "../lib/heuristics/empty-result.ts";
 
 export interface EditedResume {
   parsed: HeuristicParsedResume;
   rawText: string;
   score: AnonymousAtsScore;
+  /** Edited per-field confidence (user-affirmed contact edits bumped to
+   *  present). Threaded onto `displayResult` so the ContactCard's
+   *  "GitHub satisfies Professional profile" gap reads the same edited
+   *  confidence the score did (#421 Blocking #3). */
+  fieldConfidence: FieldConfidence;
 }
 
 export interface AnalyzedResume {
@@ -138,7 +144,7 @@ export function useAnalyzedResume(): AnalyzedResume {
   // Fold overrides back into a fresh { parsed, rawText } and re-grade live.
   const edited = useMemo<EditedResume | null>(() => {
     if (base === null) return null;
-    const { parsed, rawText, sections } = applyOverrides(
+    const { parsed, rawText, sections, fieldConfidence } = applyOverrides(
       base.parsed,
       base.rawText,
       base.sections,
@@ -152,18 +158,21 @@ export function useAnalyzedResume(): AnalyzedResume {
       addedBullets,
       removedBullets,
       addedProfiles,
+      base.fieldConfidence,
     );
     // The anonymous scorer pools its bullet set from `sections` (#133), so the
     // edited section view — not the original — must feed re-grading or a live
-    // bullet edit would not move Specificity / Structure.
+    // bullet edit would not move Specificity / Structure. `fieldConfidence` is
+    // the edited view (contact edits + added linkedin/github bumped to present),
+    // so a user-added professional profile moves completeness (#421).
     const score = computeAnonymousAtsScore({
       parsed,
-      fieldConfidence: base.fieldConfidence,
+      fieldConfidence,
       triggers: base.triggers,
       rawText,
       sections,
     });
-    return { parsed, rawText, score };
+    return { parsed, rawText, score, fieldConfidence };
   }, [
     base,
     doneScoreBullets,
@@ -180,7 +189,11 @@ export function useAnalyzedResume(): AnalyzedResume {
 
   const displayResult = useMemo<CascadeResult | null>(() => {
     if (base === null || edited === null) return null;
-    return { ...base, parsed: edited.parsed };
+    return {
+      ...base,
+      parsed: edited.parsed,
+      fieldConfidence: edited.fieldConfidence,
+    };
   }, [base, edited]);
 
   // Clear edits whenever a fresh parse lands (new file, reset) or a fresh

src/hooks/useDownloadPdf.ts

@@ -16,6 +16,7 @@ import type { CascadeResult } from "../lib/heuristics/types.ts";
 import type { AnonymousAtsScore } from "../lib/score/score.ts";
 import { buildAtsResumeModel } from "../lib/pdf/ats-resume-model.ts";
 import { renderAtsResumePdf } from "../lib/pdf/render-ats-pdf.ts";
+import { slugifyName, triggerBlobDownload } from "../lib/download/blob-download.ts";
 import type { EditableParse } from "./useEditableParse.ts";
 import { trackDownloadCompleted, type DownloadSource } from "../lib/analytics.ts";
 import { clearBlankDraft } from "./useResumeAnalysis.ts";
@@ -28,12 +29,7 @@ export interface UseDownloadPdf {
 
 /** Turn a candidate name into a safe, lower-kebab PDF filename. */
 function filenameFromName(name: string | undefined): string {
-  const slug = (name ?? "")
-    .normalize("NFKD")
-    .replace(/[^\w\s-]/g, "")
-    .trim()
-    .replace(/\s+/g, "-")
-    .toLowerCase();
+  const slug = slugifyName(name);
   return slug ? `${slug}-resume-ats.pdf` : "resume-ats.pdf";
 }
 
@@ -48,27 +44,16 @@ export function useDownloadPdf(
   const download = useCallback(async () => {
     setIsGenerating(true);
     setError(null);
-    let url: string | null = null;
     try {
       const model = buildAtsResumeModel(result, score, edit);
       const bytes = await renderAtsResumePdf(model);
-      // Copy into a fresh ArrayBuffer-backed view so Blob gets a clean buffer.
-      const blob = new Blob([bytes.slice()], { type: "application/pdf" });
-      url = URL.createObjectURL(blob);
-      const a = document.createElement("a");
-      a.href = url;
-      a.download = filenameFromName(model.contact.name);
-      document.body.appendChild(a);
-      a.click();
-      a.remove();
-      // Defer the revoke: a.click() only SCHEDULES the download — the browser
-      // reads the object URL asynchronously afterward. Revoking synchronously
-      // (e.g. in finally) invalidates the URL before the fetch starts, which
-      // silently kills the download on slower/remote contexts and on
-      // Firefox/Safari. Hand the URL off, then revoke on a later task.
-      const settledUrl = url;
-      url = null;
-      setTimeout(() => URL.revokeObjectURL(settledUrl), 60_000);
+      // `bytes.slice()` copies into a fresh ArrayBuffer-backed view so Blob gets
+      // a clean buffer.
+      triggerBlobDownload(
+        bytes.slice(),
+        "application/pdf",
+        filenameFromName(model.contact.name),
+      );
 
       // Distinguish a from-scratch authored download from an uploaded one
       // (#313). `tiers` is empty ONLY for `buildBlankResult()`'s output —
@@ -84,7 +69,6 @@ export function useDownloadPdf(
     } catch (err) {
       setError(err instanceof Error ? err.message : "Could not generate PDF.");
     } finally {
-      if (url) URL.revokeObjectURL(url);
       setIsGenerating(false);
     }
   }, [result, score, edit]);

src/hooks/useDownloadReport.ts

@@ -27,13 +27,10 @@ import type { CascadeResult } from "../lib/heuristics/types.ts";
 import type { LayoutTrigger } from "../lib/heuristics/types.ts";
 import type { AnonymousAtsScore } from "../lib/score/score.ts";
 import { getScoreRecommendation } from "../lib/score/recommendation.ts";
-import { buildAtsResumeModel } from "../lib/pdf/ats-resume-model.ts";
-import { toJsonResume } from "../lib/pdf/to-json-resume.ts";
-import { renderAuditReportPdf } from "../lib/pdf/render-audit-report.ts";
-import {
-  serializeAuditReportJson,
-  type AuditReportInput,
-} from "../lib/report/serialize.ts";
+import { buildContact } from "../lib/pdf/ats-resume-model.ts";
+import { basicsFromContact } from "../lib/pdf/to-json-resume.ts";
+import { slugifyName, triggerBlobDownload } from "../lib/download/blob-download.ts";
+import type { AuditReportInput } from "../lib/report/serialize.ts";
 import type { EditableParse } from "./useEditableParse.ts";
 import { trackReportDownloaded, type ReportFormat } from "../lib/analytics.ts";
 
@@ -44,36 +41,15 @@ export interface DownloadReportOptions {
 }
 
 export interface UseDownloadReport {
-  download: (opts: DownloadReportOptions) => Promise<void>;
+  /** Generate + download the report. Resolves `true` on success, `false` when
+   *  generation failed (the error is surfaced via `error`) — the caller gates
+   *  closing the dialog on this so a failure doesn't unmount the error UI
+   *  (#421 Blocking #4). */
+  download: (opts: DownloadReportOptions) => Promise<boolean>;
   isGenerating: boolean;
   error: string | null;
 }
 
-/** Lower-kebab slug for the report filename; empty in → generic name. */
-function slugFromName(name: string | undefined): string {
-  return (name ?? "")
-    .normalize("NFKD")
-    .replace(/[^\w\s-]/g, "")
-    .trim()
-    .replace(/\s+/g, "-")
-    .toLowerCase();
-}
-
-/** Trigger a same-document download of `bytes` as `filename`. */
-function triggerDownload(bytes: BlobPart, mime: string, filename: string): void {
-  const blob = new Blob([bytes], { type: mime });
-  const url = URL.createObjectURL(blob);
-  const a = document.createElement("a");
-  a.href = url;
-  a.download = filename;
-  document.body.appendChild(a);
-  a.click();
-  a.remove();
-  // Defer revoke: a.click() only schedules the download; revoking synchronously
-  // can kill it on slower/remote contexts + Firefox/Safari (mirrors useDownloadPdf).
-  setTimeout(() => URL.revokeObjectURL(url), 60_000);
-}
-
 export function useDownloadReport(
   result: CascadeResult,
   score: AnonymousAtsScore,
@@ -83,14 +59,16 @@ export function useDownloadReport(
   const [error, setError] = useState<string | null>(null);
 
   const download = useCallback(
-    async ({ format, includeIdentity }: DownloadReportOptions) => {
+    async ({ format, includeIdentity }: DownloadReportOptions): Promise<boolean> => {
       setIsGenerating(true);
       setError(null);
       try {
         // Identity is sourced ONLY when opted in — never build a basics block
         // we're about to strip (defense in depth alongside the serializer gate).
+        // Build it from the contact block directly (no full resume-model walk
+        // just to read `.basics`, #421 Secondary #6).
         const identity = includeIdentity
-          ? toJsonResume(buildAtsResumeModel(result, score, edit)).basics
+          ? basicsFromContact(buildContact(result, edit?.contactOverrides ?? {}))
           : undefined;
 
         const input: AuditReportInput = {
@@ -104,22 +82,33 @@ export function useDownloadReport(
 
         // Filename carries the name ONLY when identity is included — otherwise a
         // generic name so the download itself leaks nothing.
-        const slug = includeIdentity ? slugFromName(identity?.name) : "";
+        const slug = includeIdentity ? slugifyName(identity?.name) : "";
         const base = slug ? `${slug}-resume-audit-report` : "resume-audit-report";
 
+        // Lazy-load the renderer/serializer so the ~470 LOC audit-report path
+        // stays out of the entry chunk for the sessions that never click
+        // "Download report" (#421 Secondary #7, mirroring load-pdf-lib.ts).
         if (format === "pdf") {
+          const { renderAuditReportPdf } = await import(
+            "../lib/pdf/render-audit-report.ts"
+          );
           const bytes = await renderAuditReportPdf(input);
-          triggerDownload(bytes.slice(), "application/pdf", `${base}.pdf`);
+          triggerBlobDownload(bytes.slice(), "application/pdf", `${base}.pdf`);
         } else {
+          const { serializeAuditReportJson } = await import(
+            "../lib/report/serialize.ts"
+          );
           const json = serializeAuditReportJson(input);
-          triggerDownload(json, "application/json", `${base}.json`);
+          triggerBlobDownload(json, "application/json", `${base}.json`);
         }
 
         trackReportDownloaded({ format, includeIdentity });
+        return true;
       } catch (err) {
         setError(
           err instanceof Error ? err.message : "Could not generate report.",
         );
+        return false;
       } finally {
         setIsGenerating(false);
       }

src/hooks/useReportGap.ts

@@ -23,6 +23,7 @@ import { useCallback, useState } from "react";
 import type { CascadeResult } from "../lib/heuristics/types.ts";
 import type { ParseDisagreement } from "../lib/heuristics/disagreement.ts";
 import { buildReproArtifact } from "../lib/heuristics/repro-artifact.ts";
+import { triggerBlobDownload } from "../lib/download/blob-download.ts";
 import { trackGapReported } from "../lib/analytics.ts";
 
 export interface UseReportGap {
@@ -53,35 +54,20 @@ export function useReportGap(
 
   const report = useCallback(() => {
     setError(null);
-    let url: string | null = null;
     try {
       const artifact = buildReproArtifact(result, disagreements);
       const json = JSON.stringify(artifact, null, 2);
-      const blob = new Blob([json], { type: "application/json" });
-      url = URL.createObjectURL(blob);
-      const a = document.createElement("a");
-      a.href = url;
-      a.download = artifactFilename();
-      document.body.appendChild(a);
-      a.click();
-      a.remove();
+      triggerBlobDownload(json, "application/json", artifactFilename());
       // Count-only, env-gated telemetry — never the artifact contents.
       trackGapReported({
         disagreementCount: disagreements.length,
         triggers: result.triggers,
       });
-      // Defer the revoke: a.click() only schedules the download; revoking
-      // synchronously can kill it on slower/remote contexts (see useDownloadPdf).
-      const settledUrl = url;
-      url = null;
-      setTimeout(() => URL.revokeObjectURL(settledUrl), 60_000);
       setReported(true);
     } catch (err) {
       setError(
         err instanceof Error ? err.message : "Could not generate the report.",
       );
-    } finally {
-      if (url) URL.revokeObjectURL(url);
     }
   }, [result, disagreements]);
 

src/lib/contact/profile-registry.ts

@@ -31,6 +31,13 @@ interface HostRule {
   /** Human-facing network label shown in the UI. */
   network: string;
   kind: ProfileLink["kind"];
+  /** Paths on this host that are NOT a personal identity profile (e.g. a
+   *  LinkedIn company/jobs/feed page, a GitHub org page). Tested against the
+   *  full URL; a match keeps the link but downgrades it to a generic `other`
+   *  link on the bare host — never the network's `social`/`code`/… kind. Keeps
+   *  the per-host exclusion inside the `HostRule` shape instead of accreting a
+   *  special case in the classify loop (#421 review, nit 17). */
+  nonProfilePath?: RegExp;
   /** UI-only guided-add hint. When set, this host surfaces as a quick-pick chip
    *  in the profile-add affordance (`PROFILE_QUICK_PICKS`): tapping the chip
    *  pre-fills `prefix` and the caret lands after it so the user types only
@@ -50,6 +57,7 @@ export const PROFILE_HOSTS: readonly HostRule[] = [
     match: /(^|\.)linkedin\.com$/i,
     network: "LinkedIn",
     kind: "social",
+    nonProfilePath: LINKEDIN_NONPROFILE_RE,
     quickPick: { prefix: "https://linkedin.com/in/", hint: "your-handle" },
   },
   {
@@ -141,17 +149,15 @@ export function classifyProfile(rawUrl: string): ProfileLink | undefined {
   }
   if (hostname.length === 0) return undefined;
 
-  // A LinkedIn URL that is a feed/company/jobs/… page is not a personal
-  // identity profile — keep it, but do not label it `social`.
-  const isLinkedinHost = /(^|\.)linkedin\.com$/i.test(hostname);
-  if (isLinkedinHost && LINKEDIN_NONPROFILE_RE.test(url)) {
-    return { url, network: hostname, kind: "other" };
-  }
-
   for (const rule of PROFILE_HOSTS) {
-    if (rule.match.test(hostname)) {
-      return { url, network: rule.network, kind: rule.kind };
+    if (!rule.match.test(hostname)) continue;
+    // A non-profile path on this host (e.g. a LinkedIn feed/company/jobs page)
+    // is kept but downgraded to a generic `other` link on the bare host — never
+    // the network's identity kind.
+    if (rule.nonProfilePath?.test(url)) {
+      return { url, network: hostname, kind: "other" };
     }
+    return { url, network: rule.network, kind: rule.kind };
   }
   return { url, network: hostname, kind: "other" };
 }