Skip to content

Commit 0aed1b8

Browse files
pcoldicojunie-agentdwolfson
authored
feat(my_profile): one key binding convention, discoverable My Team view; fix Scorecard workflow (#469)
* feat(my_egeria): add experimental my_network script Co-authored-by: Junie <junie@jetbrains.com> Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com> * wip(my_egeria): my_network loads profile and existing peers, links new peers - Load the user's profile and existing Peer relationships on mount - Search actor profiles (case-insensitive) instead of user identities - Add description input and a Link Peer button to create the relationship Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com> * tidying up the project files, moved a number of folders to deprecated, added custom report format for listing peers Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com> * Further reformatting to clear out deprecated files and add in the use of the custome report format Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com> * Updates to Support Custom Report Spec Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com> * start of week clean up and synch Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com> * feat(my_profile): add My Network option for managing peers Merge the experimental my_network.py functionality into the My Profile app as a "My Network" option: list the user's peers, search for people and add them, view a peer's contact methods and communities, and remove a peer (with confirmation) via unlink_peer_person. - network_handler.py: NetworkMixin doing the Egeria calls - MyNetworkScreen.py: network screen and remove-confirmation dialog - my_network.py: add Remove from Network button with confirmation, hide stale details after removal - my_profile_report_specs.json: fix invalid JSON, query the Peer relationship, and show the person's GUID - tests for the mixin, screen and option routing Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com> * fix(my_profile): stop Technology Types "go back" from crashing TechnologyTypesScreen dismisses quit/go back with the strings "200"/"201", but tech_type_callback compared against the int 201. The back result was then treated as a tech type name, get_tech_type_detail returned the string "No elements found", and .get() on it raised AttributeError. - match "200"/"201" as either str or int and return to the main screen - if the tech type detail is not a dict, notify and return to the main screen instead of crashing - stop after showing the error screen when the detail lookup fails - use the Egeria client for get_tech_type_detail Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com> * docs(my_profile): document the My Network option - user manual: My Network section (view details, search and add, remove with confirmation), keyboard reference rows, intro mention - reference guide: NetworkMixin section with sequence diagram and function table, plus source layout, class diagram, menu dispatch, report spec, client and testing updates Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com> * chore: revert machine-specific config.json and test edits Restore config/config.json and test_classification_manager.py to their upstream versions. The config change pointed the report spec modules and log directory at local absolute paths, and the test change was local debugging of the Peer relationship query. Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com> * test(my_profile): cover Technology Types go back and missing details - go back/quit as "201"/"200" (str or int) returns to the main screen without looking up a tech type - a string detail result such as "No elements found" notifies and returns to the main screen - patch Egeria rather than AutomatedCuration, matching the handler, so the callback tests no longer try to reach the server - a failed detail lookup now pushes only the StatusScreen Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com> * fix(my_profile): restore Shop for Data go back and letter shortcuts The screen's prompt was a TextArea, which took focus when the screen opened. A focused TextArea consumes printable keys, so b (go back), q, s, u, t and k did nothing and Textual hid them from the footer. - make the prompt a Static, and mention b/Escape in it - add Escape as a go-back key (not shown in the footer) - move Go back next to Quit so it isn't cut off on narrow terminals - tests: b and Escape pressed straight after the screen opens dismiss with [200]; the callback returns [200] to the main screen - user manual: document Escape on Shop for Data Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com> * feat(my_profile): use one key binding convention on every screen Every screen now follows the same rules: - escape goes back one level (every screen except Main) - q is the only plain-letter key: main menu on list screens, quit on Main; left off text-entry forms, where it would be typed into the Input - every other action is a ctrl key with one meaning app-wide: ctrl+s submit, ctrl+n add, ctrl+d delete, ctrl+o open, ctrl+k/ctrl+b bookmark row/bookmarks, ctrl+u subscribe, ctrl+l sample, ctrl+g glossary search, ctrl+y copy GUID, ctrl+r refresh (was r) Return codes are unchanged; only the keys moved. Also fixes keys that could never fire: ctrl+i (sent as Tab) and ctrl+c on Edit Profile, the "return" key name on Status and the sample-data view, and the Technology Types quit/go back mix-ups. Adds ctrl+s to Create/Edit Profile. MainScreen shows the user name as its subtitle; its config logging moves to on_mount, since self.log needs a running app. test_key_bindings.py enforces the convention; docs updated to match. Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com> * feat(my_profile): make the Roles -> My Team view discoverable, changes to User Identities Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com> * Fix failing github scorecard check Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com> --------- Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com> Co-authored-by: Junie <junie@jetbrains.com> Co-authored-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
1 parent 519e238 commit 0aed1b8

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎.github/workflows/scorecard.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
persist-credentials: false
3131

3232
- name: "Run analysis"
33-
uses: ossf/scorecard-action@dc50aa6d9966401f441295b8d21c2302195df180 # v2.4.0
33+
uses: ossf/scorecard-action@fa7117db83c52d787ae5a89f350999701505d78e # v2.5.0
3434
with:
3535
results_file: results.sarif
3636
results_format: sarif

0 commit comments

Comments
 (0)