Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 images on hero page, https://www.opendota.com/heroes/86 #3137

Closed
Geczy opened this issue Jan 8, 2024 · 4 comments · Fixed by #3138
Closed

404 images on hero page, https://www.opendota.com/heroes/86 #3137

Geczy opened this issue Jan 8, 2024 · 4 comments · Fixed by #3138

Comments

@Geczy
Copy link
Contributor

Geczy commented Jan 8, 2024

Current Behavior

https://www.opendota.com/heroes/86

404 image

image

Expected behavior/code

show image

@howardchung
Copy link
Member

Looks like in dotaconstants we just need to filter out:

  "rubick_hidden1",
  "rubick_hidden2",
  "rubick_hidden3",

@Geczy
Copy link
Contributor Author

Geczy commented Jan 8, 2024

Rubicks not the only hero. It's a bunch of them so I think we need a different fix. Check batrider too

@howardchung
Copy link
Member

I think we just have to manually exclude all of these, unless we can identify a pattern

@Geczy
Copy link
Contributor Author

Geczy commented Jan 8, 2024

Looking into it, we can fix this by filtering on "behavior": "Hidden",

#3138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants