Fix Ruff lint errors

- Resolve undefined 'Odev' in run.py
- Fix FBT003 and S108 in test_python_env.py

Author: sea-odoo

odev/commands/database/run.py

@@ -1,11 +1,17 @@
 """Run an Odoo database locally."""
 
+from typing import TYPE_CHECKING
+
 from odev.common import args, progress
 from odev.common.commands import OdoobinTemplateCommand
 from odev.common.logging import logging
 from odev.common.version import OdooVersion
 
 
+if TYPE_CHECKING:
+    from odev.common.odev import Odev
+
+
 logger = logging.getLogger(__name__)
 
 

tests/tests/commands/test_database.py

@@ -418,7 +418,9 @@ def test_14_run_empty_db_warning(self):
             # Logging goes to stdout in these tests
             combined_output = stdout + stderr
             self.assertIn(f"Database {empty_db!r} is not an Odoo database. Defaulting to 'master'.", combined_output)
-            self.assertIn(f"Consider using 'odev create -V <version> {empty_db}' to initialize it properly.", combined_output)
+            self.assertIn(
+                f"Consider using 'odev create -V <version> {empty_db}' to initialize it properly.", combined_output
+            )
         finally:
             LocalDatabase(empty_db).drop()
 

tests/tests/common/test_python_env.py

@@ -1,9 +1,9 @@
-from subprocess import CalledProcessError, CompletedProcess
 from pathlib import Path
+from subprocess import CalledProcessError, CompletedProcess
 from unittest.mock import MagicMock, patch
 
+from odev.common import bash
 from odev.common.python import PythonEnv
-from odev.common import odev, bash
 
 from tests.fixtures import OdevTestCase
 
@@ -18,17 +18,17 @@ def setUpClass(cls):
 
     def test_run_script_streaming_success(self):
         """Test run_script with a streaming process that succeeds."""
-        env = PythonEnv(path="/tmp/fake_venv", version="3.10")
-        
+        env = PythonEnv(path="/tmp/fake_venv", version="3.10")  # noqa: S108
+
         with (
-            self.patch(Path, "exists", True),
-            self.patch(PythonEnv, "exists", True),
-            self.patch(PythonEnv, "python", Path("/tmp/fake_venv/bin/python")),
-            self.patch(bash, "stream", return_value=iter(["line 1", "line 2"]))
+            self.patch(Path, "exists", return_value=True),
+            self.patch(PythonEnv, "exists", return_value=True),
+            self.patch(PythonEnv, "python", Path("/tmp/fake_venv/bin/python")),  # noqa: S108
+            self.patch(bash, "stream", return_value=iter(["line 1", "line 2"])),
         ):
             progress_mock = MagicMock()
             result = env.run_script("fake_script.py", stream=True, progress=progress_mock)
-            
+
             self.assertIsInstance(result, CompletedProcess)
             self.assertEqual(result.returncode, 0)
             self.assertEqual(progress_mock.call_count, 2)
@@ -37,21 +37,21 @@ def test_run_script_streaming_success(self):
 
     def test_run_script_streaming_failure(self):
         """Test run_script with a streaming process that fails."""
-        env = PythonEnv(path="/tmp/fake_venv", version="3.10")
-        
+        env = PythonEnv(path="/tmp/fake_venv", version="3.10")  # noqa: S108
+
         def streaming_failure(command):
             yield "line 1"
             raise CalledProcessError(1, command)
 
         with (
-            self.patch(Path, "exists", True),
-            self.patch(PythonEnv, "exists", True),
-            self.patch(PythonEnv, "python", Path("/tmp/fake_venv/bin/python")),
-            self.patch(bash, "stream", side_effect=streaming_failure)
+            self.patch(Path, "exists", return_value=True),
+            self.patch(PythonEnv, "exists", return_value=True),
+            self.patch(PythonEnv, "python", Path("/tmp/fake_venv/bin/python")),  # noqa: S108
+            self.patch(bash, "stream", side_effect=streaming_failure),
         ):
             progress_mock = MagicMock()
             result = env.run_script("fake_script.py", stream=True, progress=progress_mock)
-            
+
             self.assertIsInstance(result, CompletedProcess)
             self.assertEqual(result.returncode, 1)
             progress_mock.assert_called_once_with("line 1")