[FIX] l10n_ar: 5614/2024: Tax Breakdown on B2C (0.0 taxes)

When doing a Invoice B to exempts customer we have a problem: the RG
Leyend new table is not showed, This because if the VAT Content and
other taxes were 0. After checking with ARCA Online PDF report, and
some feedback with customers we found out that the Leyend it is
always shown and the VAT content line is always shown, even if VAT
taxes are 0.0. Only need to hide the other taxes line if this one is 0.0

We also add a new key to the dictionary that prepare the tax detail values
to properly identify the group of taxes. If not we will need to depend on
the translations of the name to check which group it is.

Update unit test to follow this new approach and also add a unit case
where vat tax 0.0 and not other taxes are added.

opw-4814730

closes odoo#214866

Signed-off-by: Antoine Dupuis (andu) <[email protected]>

Author: jue-adhoc

addons/l10n_ar/models/account_move.py

@@ -403,7 +403,6 @@ def grouping_function(base_line, tax_data):
             if (
                 grouping_key
                 and not grouping_key['skip']
-                and not self.currency_id.is_zero(values['tax_amount_currency'])
             ):
                 results.append({
                     'name': grouping_key['name'],

addons/l10n_ar/tests/test_manual.py

@@ -255,7 +255,7 @@ def test_18_invoice_b_tax_breakdown_1(self):
     def test_19_invoice_b_tax_breakdown_2(self):
         """ Display only Other Taxes (VAT taxes are 0) """
         invoice = self._create_invoice_from_dict({
-            'ref': 'test_invoice_21:  inal Consumer Invoice B with 0 tax and internal tax',
+            'ref': 'test_invoice_21: Final Consumer Invoice B with 0 tax and internal tax',
             "move_type": 'out_invoice',
             "partner_id": self.partner_cf,
             "company_id": self.company_ri,
@@ -270,8 +270,14 @@ def test_19_invoice_b_tax_breakdown_2(self):
             {
                 'tax_amount_currency': 300.00,
                 'formatted_tax_amount_currency': '300.00',
-                'name': 'Other National Ind. Taxes $',
+                'name': 'Other National Ind. Taxes $'
             },
+            {
+                'formatted_tax_amount_currency': '0.00',
+                'name': 'VAT Content $',
+                'tax_amount_currency': 0.0
+            }
+
         ])
         self._assert_tax_totals_summary(invoice._l10n_ar_get_invoice_totals_for_report(), {
             'same_tax_base': True,
@@ -282,6 +288,36 @@ def test_19_invoice_b_tax_breakdown_2(self):
             'subtotals': [],
         })
 
+    def test_20_invoice_b_tax_breakdown_3(self):
+        """ Display only Other Taxes (VAT taxes are 0 and non other taxes) """
+        invoice = self._create_invoice_from_dict({
+            'ref': 'test_invoice_22: Final Consumer Invoice B with only 0 tax',
+            "move_type": 'out_invoice',
+            "partner_id": self.partner_cf,
+            "company_id": self.company_ri,
+            "invoice_date": "2021-03-20",
+            "invoice_line_ids": [
+                {'product_id': self.product_iva_105_perc, 'price_unit': 10000.0, 'quantity': 1,
+                    'tax_ids': [(6, 0, [self.tax_no_gravado.id])]},
+            ],
+        })
+        results = invoice._l10n_ar_get_invoice_custom_tax_summary_for_report()
+        self.assertEqual(results, [
+            {
+                'tax_amount_currency': 0.0,
+                'formatted_tax_amount_currency': '0.00',
+                'name': 'VAT Content $'
+            },
+        ])
+        self._assert_tax_totals_summary(invoice._l10n_ar_get_invoice_totals_for_report(), {
+            'same_tax_base': True,
+            'currency_id': self.currency.id,
+            'base_amount_currency': 10000.0,
+            'tax_amount_currency': 0.0,
+            'total_amount_currency': 10000.0,
+            'subtotals': [],
+        })
+
     def test_l10n_ar_prices_and_taxes(self):
         invoice = self.env['account.move'].create({
             "move_type": 'out_invoice',