Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make possible to reduce fluky tests #22

Open
kamilsk opened this issue Jan 25, 2021 · 1 comment
Open

make possible to reduce fluky tests #22

kamilsk opened this issue Jan 25, 2021 · 1 comment
Assignees
@kamilsk
Labels
difficulty: medium help wanted type:bug type:critical
Milestone
breaker 1.2

Comments

@kamilsk
Copy link
Member

kamilsk commented Jan 25, 2021 

--- FAIL: TestBreakBySignal (0.00s)
    --- FAIL: TestBreakBySignal/with_signal (0.02s)
        breaker_test.go:216: max difference between 2021-01-24 21:27:21.89766 +0300 MSK m=+0.017424561 and 2021-01-24 21:27:21.908426 +0300 MSK m=+0.028190544 allowed is 10ms, but difference was -10.765983ms
FAIL

$ make test
--- FAIL: TestMultiplexThree (0.01s)
    deprecated_test.go:30: a breaker is not released
    deprecated_test.go:30: a breaker has inconsistent state
    deprecated_test.go:30: a breaker has no error
FAIL
FAIL    github.com/kamilsk/breaker      0.884s
FAIL
make: *** [test] Error 1
@kamilsk kamilsk added this to the breaker 1.2 milestone Jan 25, 2021
@kamilsk kamilsk self-assigned this Jan 25, 2021
@kamilsk
Copy link
Member Author

kamilsk commented Jan 26, 2021

It shows fundamental error: if Done is closed, the Err must return Interrupted, but it is undefined, because released int32 stores 1 only if goroutine is released

kamilsk added a commit that referenced this issue Jan 26, 2021
@kamilsk
issue \#22: prevent fluky tests and fix critical bug related to Err()…
03ca004 
… guarantees
kamilsk added a commit that referenced this issue Jan 26, 2021
@kamilsk
issue #22: prevent fluky tests and fix critical bug related to Err() …
da0975e 
…guarantees
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kamilsk kamilsk

Labels
difficulty: medium help wanted type:bug type:critical
Projects
None yet
Milestone
breaker 1.2
Development

No branches or pull requests
1 participant
@kamilsk