From 7041009277fc591b5898fbdec8d9c050fa91e547 Mon Sep 17 00:00:00 2001 From: Oscar Dominguez Date: Thu, 1 Sep 2022 21:52:29 +0200 Subject: [PATCH 1/2] ci(workflow): fix test workflow to assure it is not skipped if test_matrix fails --- .github/workflows/test.yml | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 4beec547..a7a01179 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -18,18 +18,21 @@ jobs: - 18 steps: - uses: actions/checkout@master - - name: "Use Node.js ${{ matrix.node_version }}" - uses: actions/setup-node@2fddd8803e2f5c9604345a0b591c3020ee971a93 # tag=v3 + - name: Use Node.js ${{ matrix.node_version }} + uses: actions/setup-node@2fddd8803e2f5c9604345a0b591c3020ee971a93 with: - node-version: "${{ matrix.node_version }}" + node-version: ${{ matrix.node_version }} cache: npm - run: npm ci - - run: npm test --ignore-scripts # run lint only once + - run: npm test --ignore-scripts test: runs-on: ubuntu-latest needs: test_matrix steps: - - uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # tag=v3 + - run: exit 1 + if: ${{ needs.test_matrix.result != 'success' }} + - uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b - run: npm ci - run: npm run lint - - run: "npm run test:ts" + - run: npm run test:ts + if: ${{ always }} From 188f55500ef99266db483b351a5d675c0c824fd8 Mon Sep 17 00:00:00 2001 From: Oscar Dominguez Date: Thu, 1 Sep 2022 22:28:41 +0200 Subject: [PATCH 2/2] Update test.yml --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index a7a01179..42296be6 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -35,4 +35,4 @@ jobs: - run: npm ci - run: npm run lint - run: npm run test:ts - if: ${{ always }} + if: ${{ always() }}