Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: type OAuthAppAuthentication does not conform to OIDC specifications #279

Open
1 task done
ataylorme opened this issue Sep 6, 2024 · 1 comment
Open
1 task done
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Bug Something isn't working as documented

Comments

@ataylorme
Copy link

What happened?

I am using auth-oauth-user.js to generate a user access token using the web flow.

The responses are used in an OpenID Connect (OIDC) identity provider. The return type OAuthAppAuthentication does not conform to OIDC specifications.

This is causing me to manually remap the returned value from auth-oauth-user.js from camelCase back to snake_case as originally provided by https://github.com/login/oauth/access_token

I believe auth-oauth-user.js should not alter the response from https://github.com/login/oauth/access_token and instead return snake_case

Versions

"@octokit/auth-oauth-user": "^5.1.1"

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@ataylorme ataylorme added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@github-project-automation github-project-automation bot moved this to 🆕 Triage in 🧰 Octokit Active Sep 6, 2024
@kfcampbell kfcampbell moved this from 🆕 Triage to 🔥 Backlog in 🧰 Octokit Active Sep 9, 2024
@kfcampbell kfcampbell added Status: Up for grabs Issues that are ready to be worked on by anyone and removed Status: Triage This is being looked at and prioritized labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Bug Something isn't working as documented
Projects
Status: 🔥 Backlog
Development

No branches or pull requests

2 participants