Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Regression with 5.6.0 #1558

Closed
toots opened this issue Jan 29, 2024 · 8 comments
Closed

[BUG] Regression with 5.6.0 #1558

toots opened this issue Jan 29, 2024 · 8 comments
Labels

Comments

@toots
Copy link

toots commented Jan 29, 2024

Sorry, I don't have a minimal reproduction setup but the js build of the liquidsoap parser has a regression with js_of_ocaml 5.6.0:

Error while processing file ../liquidsoap/tests/language/eval.liq: Error: Unknown position:

Error -1: Exception raised: TypeError: sedlex_state_15 is not a function

The same build works with 5.5.2..

@toots toots added the bug label Jan 29, 2024
@hhugo
Copy link
Member

hhugo commented Jan 30, 2024

Can you try with master ?

@hhugo
Copy link
Member

hhugo commented Jan 30, 2024

Also, can you provide the problematic JS file ?

@toots
Copy link
Author

toots commented Jan 30, 2024

It appears to be fixed if I install pinned version of this git repo's opam packages. This is a bit confusing, though, because the version is still reported as 5.5.2..

@hhugo
Copy link
Member

hhugo commented Feb 2, 2024

I wonder if this is the same issue as #1559 ? can you provide the problematic js file ?

@hhugo
Copy link
Member

hhugo commented Feb 6, 2024

@toots, gentle ping ..

@toots
Copy link
Author

toots commented Feb 6, 2024

@hhugo
Copy link
Member

hhugo commented Feb 8, 2024

Thanks, the issue is different from #1559.

Regression introduced by #1544
Fixed by #1541

Thanks for the report. I'll try to make a new release soon

@hhugo
Copy link
Member

hhugo commented Feb 10, 2024

It appears to be fixed if I install pinned version of this git repo's opam packages. This is a bit confusing, though, because the version is still reported as 5.5.2..

I've just tried installing version 5.5.2 followed by a opam pin add js_of_ocaml-compiler --dev and I see js_of_ocaml --version report version correctly.

$ js_of_ocaml --version
5.6.0+git-5.6.0-30-gb7d29593db-dirty

opam show js_of_ocaml-compiler still reports 5.5.2 though. Is this the behavior you've witness ? or is it js_of_ocaml --version that was incorrect ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants