Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary + themes rickety on entry-view #159

Open
lefnire opened this issue Jun 24, 2023 · 0 comments
Open

Summary + themes rickety on entry-view #159

lefnire opened this issue Jun 24, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@lefnire
Copy link
Collaborator

lefnire commented Jun 24, 2023

When an entry is clicked, it goes:

  1. <Insights entry_ids={[entry.id]} /> is re-rendered (entry_ids is changed)
  2. useEffect(...., [entry_ids]) is debounced a bit, then triggers a re-fetch of insights_get_request

But there seems to be some sort of race-condition, because if you get into an entry too fast, or create an entry while something else is happening, then the "Summaries & Themes" insight (and maybe the other insights for that matter, just that Summaries & Themes is most obvious) either (a) remains unchanged (prior results); or (b) is blank, indicating the user doesn't have enough entries.

Investigate op: "update" changes like in here 0f8bb1a#diff-e8230420a204b9ff8677465015eccb5102d4495fbf839542902395002aeef8ceR174, which fixed similar problems

@lefnire lefnire added the bug Something isn't working label Jun 24, 2023
@lefnire lefnire self-assigned this Jun 24, 2023
@lefnire lefnire added this to Gnothi Jun 24, 2023
@github-project-automation github-project-automation bot moved this to Later in Gnothi Jun 24, 2023
@lefnire lefnire moved this from Later to In Progress in Gnothi Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ASAP
Development

No branches or pull requests

1 participant