refactor: remove [Artifacts.Local.t] (#8743)

Signed-off-by: Rudi Grinberg <[email protected]>

Author: rgrinberg

src/dune_rules/artifacts.ml

@@ -60,19 +60,20 @@ let add_binaries t ~dir l =
   { t with local_bins }
 ;;
 
-module Local = struct
-  type t = Path.Build.t Filename.Map.t
-
-  let create =
-    Path.Build.Set.fold ~init:Filename.Map.empty ~f:(fun path acc ->
-      let name = Path.Build.basename path in
-      let key =
-        if Sys.win32
-        then Option.value ~default:name (String.drop_suffix name ~suffix:".exe")
-        else name
-      in
-      Filename.Map.set acc key path)
-  ;;
-end
-
-let create (context : Context.t) ~local_bins = { context; local_bins }
+let create =
+  let drop_suffix name =
+    if Sys.win32
+    then Option.value ~default:name (String.drop_suffix name ~suffix:".exe")
+    else name
+  in
+  fun (context : Context.t) ~local_bins ->
+    let local_bins =
+      Memo.lazy_ (fun () ->
+        let+ local_bins = Memo.Lazy.force local_bins in
+        Path.Build.Set.fold local_bins ~init:Filename.Map.empty ~f:(fun path acc ->
+          let name = Path.Build.basename path in
+          let key = drop_suffix name in
+          Filename.Map.set acc key path))
+    in
+    { context; local_bins }
+;;

src/dune_rules/artifacts.mli

@@ -18,12 +18,5 @@ val local_bin : Path.Build.t -> Path.Build.t
 val binary : t -> ?hint:string -> loc:Loc.t option -> string -> Action.Prog.t Memo.t
 
 val binary_available : t -> string -> bool Memo.t
-
-module Local : sig
-  type t
-
-  val create : Path.Build.Set.t -> t
-end
-
 val add_binaries : t -> dir:Path.Build.t -> File_binding.Expanded.t list -> t
-val create : Context.t -> local_bins:Local.t Memo.Lazy.t -> t
+val create : Context.t -> local_bins:Path.Build.Set.t Memo.Lazy.t -> t

src/dune_rules/artifacts_db.ml

@@ -88,7 +88,6 @@ let get_installed_binaries ~(context : Context.t) stanzas =
       | _ -> Memo.return Path.Build.Set.empty)
     >>| Path.Build.Set.union_all)
   >>| Path.Build.Set.union_all
-  >>| Artifacts.Local.create
 ;;
 
 let all =