Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify compatibility with dune? #3

Open
tomjridge opened this issue Apr 15, 2019 · 5 comments
Open

Clarify compatibility with dune? #3

tomjridge opened this issue Apr 15, 2019 · 5 comments

Comments

@tomjridge
Copy link

I guess this package is not compatible with dune? Are there any plans to make it compatible?

@Leandros
Copy link

I'm wondering, too. I'm getting

Error: Uninterpreted extension 'include'.

@Leandros
Copy link

Leandros commented Apr 18, 2019

I have updated it, to work with dune and ocaml-migrate-parsetree: https://github.com/aexpl/ppx_include
Take a look at the test for usage with dune, and even other derivers.

I've also published it in my personal OPAM repo, if you want to use it: https://github.com/aexpl/opam-repository

@tomjridge
Copy link
Author

tomjridge commented Apr 18, 2019 via email

@tomjridge
Copy link
Author

And now I have looked at the examples, everything works fine! Thank you very much @Leandros

@Leandros
Copy link

Leandros commented Apr 30, 2019

You're welcome. I've also fixed a bug which prevented anything after an [%%include ...] to be parsed. It can now be used in almost all places correctly. As well as reporting the correct filename in errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants