Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theme: Ukiyo #5053

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Add theme: Ukiyo #5053

merged 3 commits into from
Jan 14, 2025

Conversation

wizentex
Copy link
Contributor

@wizentex wizentex commented Jan 3, 2025

I am submitting a recently removed Theme from a fork repository

Repo URL

Link to the theme:

https://github.com/technerium/obsidian-ukiyo

Theme checklist

  • My repo contains all required files (please do not add them to this obsidian-releases repo).
    • manifest.json
    • theme.css
    • The screenshot file (16:9 aspect ratio, recommended size is 512px by 288px for fast loading).
  • I have indicated which modes (dark, light, or both) are compatible with my theme.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my theme's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Themes/App+themes/Theme+guidelines and have self-reviewed my theme to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other themes that I'm using. I have given proper attribution to these other themes in my README.md.

Note regarding fork

I kept the theme name and version in sync with the original to ensure the change is transparent for users. Please let me know if anything needs to be adjusted in that regard.

@github-actions github-actions bot changed the title Reinstated Ukiyo from a fork. Add theme: Ukiyo Jan 3, 2025
Copy link

github-actions bot commented Jan 3, 2025

Hello!

I found the following issues in your theme submission

Errors:

❌ Your theme screenshot is too big, we generally recommend a size around 512 × 288 pixels.
Detected size: 1920 x 1040 pixels


Warnings:

⚠️ Your repository includes a obsidian.css file, this is only used in legacy versions of Obsidian.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

github-actions bot commented Jan 3, 2025

Hello!

I found the following issues in your theme submission

Warnings:

⚠️ Your repository includes a obsidian.css file, this is only used in legacy versions of Obsidian.
⚠️ Theme theme screenshot size is not optimal, we generally recommend a size around 512 × 288 pixels.
Detected size: 512 x 277 pixels


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

github-actions bot commented Jan 3, 2025

Hello!

I found the following issues in your theme submission

Warnings:

⚠️ Your repository includes a obsidian.css file, this is only used in legacy versions of Obsidian.
⚠️ Theme theme screenshot size is not optimal, we generally recommend a size around 512 × 288 pixels.
Detected size: 512 x 277 pixels


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@wizentex wizentex closed this Jan 3, 2025
@wizentex wizentex reopened this Jan 3, 2025
Copy link

github-actions bot commented Jan 3, 2025

Hello!

I found the following issues in your theme submission

Warnings:

⚠️ Your repository includes a obsidian.css file, this is only used in legacy versions of Obsidian.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@joethei
Copy link
Collaborator

joethei commented Jan 3, 2025

Copyright (c) 2022 Kinmury
Update this to add yourself., but keep the original credit.

"author": "Technerium",
Please credit the original author here.

"authorURI": "https://github.com/technerium/obsidian-ukiyo"
This should not point to the theme repo, but rather your website / GH profile.

@joethei joethei self-assigned this Jan 3, 2025
@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Jan 3, 2025
@wizentex wizentex closed this Jan 3, 2025
@wizentex wizentex reopened this Jan 3, 2025
Copy link

github-actions bot commented Jan 3, 2025

Hello!

I found the following issues in your theme submission

Warnings:

⚠️ Your repository includes a obsidian.css file, this is only used in legacy versions of Obsidian.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@github-actions github-actions bot added Ready for review and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels Jan 3, 2025
@wizentex
Copy link
Contributor Author

wizentex commented Jan 3, 2025

Thanks @joethei, I've completed the changes.

Copy link

github-actions bot commented Jan 4, 2025

Hello!

I found the following issues in your theme submission

Warnings:

⚠️ Your repository includes a obsidian.css file, this is only used in legacy versions of Obsidian.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

Hello!

I found the following issues in your theme submission

Warnings:

⚠️ Your repository includes a obsidian.css file, this is only used in legacy versions of Obsidian.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@joethei joethei merged commit d0ed58f into obsidianmd:master Jan 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants