Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theme: Playground #5051

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benjaminezequiel
Copy link

@benjaminezequiel benjaminezequiel commented Jan 3, 2025

I am submitting a new Community Theme

Repo URL

Link to my theme: https://github.com/benjaminezequiel/playground-theme

Theme checklist

  • My repo contains all required files (please do not add them to this obsidian-releases repo).
    • manifest.json
    • theme.css
    • The screenshot file (16:9 aspect ratio, recommended size is 512px by 288px for fast loading).
  • I have indicated which modes (dark, light, or both) are compatible with my theme.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my theme's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Themes/App+themes/Theme+guidelines and have self-reviewed my theme to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other themes that I'm using. I have given proper attribution to these other themes in my README.md.

@github-actions github-actions bot changed the title Update community-css-themes.json Add theme: Playground Jan 3, 2025
Copy link

github-actions bot commented Jan 3, 2025

Hello!

I found the following issues in your theme submission

Errors:

❌ Theme name mismatch, the name in this PR (Playground) is not the same as the one in your repo (playground-theme). If you just changed your theme name, remember to change it in the manifest.json in your repo, and your latest GitHub release, if you have one.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@joethei
Copy link
Collaborator

joethei commented Jan 3, 2025

@font-face {
Inter is already loaded by Obsidian, it does not need to be included here.

@joethei joethei self-assigned this Jan 3, 2025
@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Jan 3, 2025
@benjaminezequiel
Copy link
Author

Hi @joethei, just made a new release removing Inter!

@joethei
Copy link
Collaborator

joethei commented Jan 3, 2025

Please also update the code in your repo, always

@benjaminezequiel
Copy link
Author

Sorry, I forgot to push it! Done.

@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants