-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin: ShaahMaat-md #4996
base: master
Are you sure you want to change the base?
Add plugin: ShaahMaat-md #4996
Conversation
Hello!I found the following issues in your plugin submission Errors: ❌ Please don't include This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it. |
Thank you for your submission, an automated scan of your plugin code's revealed the following issues: Required[1]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets. Do NOT open a new PR for re-validation. |
/skip The highlighted code uses a CSS variable to set the appropriate background color for each square. Removing said variable would necessitate three different CSS classes just to set a single color and would make the code needlessly convoluted. The colours are completely customisable via the settings tab of the plugin and, due to the nature of the plugin, it does not make sense to allow these colours to be modified by snippets or themes. |
It seems that the pull request was not correctly updated by the bot, so I am reopening |
Changes requested by bot have been made, ready for additional review by human. |
I am submitting a new Community Plugin
Repo URL
Link to my plugin: https://github.com/MihailKovachev/shaahmaat-md
Release Checklist
main.js
manifest.json
styles.css
(optional)v
)id
in mymanifest.json
matches theid
in thecommunity-plugins.json
file.I have given proper attribution to these other projects in my
README.md
.