Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: iWeaver Sync #4818

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add plugin: iWeaver Sync #4818

wants to merge 1 commit into from

Conversation

Yueyanc
Copy link

@Yueyanc Yueyanc commented Dec 4, 2024

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/iWeaverAI-Org/obsidian-iweaver

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Copy link

github-actions bot commented Dec 4, 2024

Hello!

I found the following issues in your plugin submission

Warnings:

⚠️ We generally discourage including your email addresses in the author field.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@github-actions github-actions bot changed the title Update community-plugins.json Add plugin: iWeaver Sync Dec 4, 2024
@Yueyanc
Copy link
Author

Yueyanc commented Dec 4, 2024

Continuation of #4745

@ObsidianReviewBot
Copy link
Collaborator

The automated review has not found any issues with your code, assigning human for additional review.

@joethei
Copy link
Collaborator

joethei commented Jan 3, 2025

Sorry for the delay.

private syncIntervalId: NodeJS.Timeout | null = null;
Use a regular number as the type here, and use activeWindow.setTimeout / activeWindow.clearTimeout where this is being used.

this.app.fileManager.processFrontMatter(, this.app.fileManager.processFrontMatter(file, (frontmatter) => {
processFrontMatter should only be used if you write to the frontmatter, as you are only reading you should use the MetadataCache API.

"iWeaver Sync", "iWeaver Chat"
Use sentence case in UI

"minAppVersion": "0.15.0",
You are using newer API's, set this to the latest public build number.

@joethei joethei self-assigned this Jan 3, 2025
@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes requested Minor changes requested PR can be merged after some final changes have been requested plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants