Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Anchor Link Display Text #4797

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rca-umb
Copy link

@rca-umb rca-umb commented Dec 1, 2024

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/rca-umb/anchor-link-display-text

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@github-actions github-actions bot changed the title Add Anchor Link Display Text plugin Add plugin: Anchor Link Display Text Dec 1, 2024
@ObsidianReviewBot
Copy link
Collaborator

The automated review has not found any issues with your code, assigning human for additional review.

@joethei joethei removed their assignment Dec 2, 2024
@Zachatoo
Copy link
Collaborator

Zachatoo commented Dec 7, 2024

This is an awesome plugin idea!


.setName('Notification text')
Minor UX critique, I would recommend conditionally showing this setting based on the previous setting. It isn't relevant to the user if the previous setting is disabled.

@Zachatoo Zachatoo self-assigned this Dec 7, 2024
@Zachatoo Zachatoo added Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Dec 7, 2024
@joethei joethei added Changes requested and removed Minor changes requested PR can be merged after some final changes have been requested labels Dec 9, 2024
@ObsidianReviewBot ObsidianReviewBot added Ready for review and removed Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Dec 9, 2024
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by Zachatoo have been made, assigning additional human for additional review

@rca-umb
Copy link
Author

rca-umb commented Dec 9, 2024

This is an awesome plugin idea!

.setName('Notification text') Minor UX critique, I would recommend conditionally showing this setting based on the previous setting. It isn't relevant to the user if the previous setting is disabled.

Good point, I appreciate the feedback!

Edit: Fixed in 1.0.1

@joethei
Copy link
Collaborator

joethei commented Jan 3, 2025

this.notificationTextSetting = new Setting(containerEl)
Why should this be a setting?
It makes no sense for me.

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Jan 3, 2025
@rca-umb
Copy link
Author

rca-umb commented Jan 3, 2025

this.notificationTextSetting = new Setting(containerEl) Why should this be a setting? It makes no sense for me.

@joethei
That's a fair question. I suppose I just wanted to give maximum flexibility. I definitely wanted the option for a notification because I personally like being notified when things get changed automatically, but I could see some people finding it unnecessary. When it came to the actual contents of the message, I wasn't sure how verbose it should be; "link changed", "anchor link changed", "foo#bar changed to foo#bar|foo bar", etc. For me, I don't really care what it says as long as I can see the visual feedback when an edit is programmatically made to my document, so I just figured I would give the user the option in case something worked better for them. I understand that this may not be the best choice and can make it fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes requested Minor changes requested PR can be merged after some final changes have been requested plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants