Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Link Opening Restore #4785

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SmallZombie
Copy link

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/SmallZombie/link-opening-restore

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@github-actions github-actions bot changed the title Add Link Opening Restore plugin Add plugin: Link Opening Restore Nov 30, 2024
@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:Remember to rename the sample classes to something that makes sense to your plugin. If there are any errors, Obsidian will spit out this class name, so this will be important for users to debug if they need to.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot self-assigned this Dec 1, 2024
@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Ready for review and removed Ready for review Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Dec 1, 2024
@ObsidianReviewBot ObsidianReviewBot removed their assignment Dec 1, 2024
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, assigning human for additional review.

@joethei joethei removed their assignment Dec 2, 2024
@Zachatoo
Copy link
Collaborator

Zachatoo commented Dec 7, 2024

This is an Obsidian plugin that restores the link opening method to Ctrl + Left Click in edit mode. You can use the '切换功能开关' command to toggle it.
It isn't clear to me what functionality this plugin is adding. I've tried ctrl clicking on internal and external links, with and without your plugin installed, and there doesn't appear to be any functionality difference. Can you update the README to clarify what your plugin does?

@Zachatoo Zachatoo added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made and removed Ready for review labels Dec 7, 2024
@Zachatoo Zachatoo self-assigned this Dec 7, 2024
@SmallZombie
Copy link
Author

Sorry, this is a bug: SmallZombie/link-opening-restore#1
It has now been fixed and re-released as version 1.0.

(Sorry for the late reply, I’m not sure why GitHub didn't send me an email)

@ObsidianReviewBot ObsidianReviewBot added Ready for review and removed Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Dec 19, 2024
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by Zachatoo have been made, assigning additional human for additional review

@joethei
Copy link
Collaborator

joethei commented Jan 3, 2025

# Obsidian Link Opener
Naming something "Obsidian xyz" is reserved for first party products we create, please change this header.

"description": "Restore the link opening behavior in Obsidian.",
Avoid including sentences like "This is a plugin for Obsidian" in your description, it should be a given since this is only shown when browsing plugins through the app or on our website.
We have published a guide for plugin descriptions to follow here: https://docs.obsidian.md/Plugins/Releasing/Submission+requirements+for+plugins#Keep+plugin+descriptions+short+and+simple.

this.app.workspace.on('active-leaf-change', () => {
Why are you registering this listener on every leaf change and not just once?

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested labels Jan 3, 2025
@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels Jan 3, 2025
@SmallZombie
Copy link
Author

Modified the logic for adding and removing listeners.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants