Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Observable Plot #4731

Conversation

corychainsman
Copy link

@corychainsman corychainsman commented Nov 21, 2024

Added Observable Plot plugin

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/corychainsman/Obsidian-Observable-Plot

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Added Obsidian Observable Plot plugin
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Please don't use the word obsidian in the plugin ID. The ID is used for your plugin's folder so keeping it short and simple avoids clutter and helps with sorting.
❌ Please don't use the word Obsidian in your plugin name since it's redundant and adds clutter to the plugin list.
❌ Please don't include Obsidian in the plugin description


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@github-actions github-actions bot changed the title Add Obsidian Observable Plot plugin Add plugin: Observable Plot Nov 21, 2024
@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:Please remove the main.js file from the repo and add it to your .gitignore. Compiled release files shouldn't get mixed with source code in your commits and should go to the releases files instead.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot self-assigned this Nov 21, 2024
@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Ready for review and removed Ready for review Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Nov 21, 2024
@ObsidianReviewBot ObsidianReviewBot removed their assignment Nov 21, 2024
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, assigning human for additional review.

@joethei
Copy link
Collaborator

joethei commented Nov 21, 2024

Please remove the main.js file from the repo and add it to your .gitignore. Compiled release files shouldn't get mixed with source code in your commits and should go to the releases files instead.

Copyright (c) 2024 Obsidian Observable Plot Plugin Contributors
Naming something "Obsidian xyz" is reserved for first party products we create, please change this.

this.logMessage(Fetching data from ${config.dataUrl});, this.logMessage(Successfully fetched data: ${typeof plotData === 'object' ? 'GeoJSON/TopoJSON' : plotData.length + ' items'});
Please avoid unnecessary logging. If you need it for debugging purposes, add a check to only log during development.

const response = await fetch(config.dataUrl);
Use the requestUrl function from the Obsidian API instead, it will handle some things like CORS automatically.

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Nov 21, 2024
@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels Nov 23, 2024
@joethei
Copy link
Collaborator

joethei commented Nov 28, 2024

The manifest has to be in the root of the repo, and this: "css": "styles.css" is not a valid part of the manifest, remove it.

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested labels Nov 28, 2024
Copy link

Hi there, as this PR has not seen any activity in the last 30 days, it will be closed in 15 days unless there are any updates.

@github-actions github-actions bot added the stale label Dec 29, 2024
Copy link

Hi there, to keep things tidy, we're closing PRs after one and a half months of inactivity.
Feel free to create a new pull request when you're ready to continue. Thanks for your understanding!

@github-actions github-actions bot closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes requested Minor changes requested PR can be merged after some final changes have been requested plugin stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants