-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin: Obsifetch #4716
Add plugin: Obsifetch #4716
Conversation
Thank you for your submission, an automated scan of your plugin code's revealed the following issues: Required[1][2][3][4][5]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets. [1]:The command name should not include the plugin name. Optional[1][2][3]:Casting to Do NOT open a new PR for re-validation. |
Changes requested by bot have been made, assigning human for additional review. |
"styles": ["styles.css"] .setName('Custom ASCII Logo'), id: 'show-obsifetch', if (userAgent.includes('linux')) {, } else if (userAgent.includes('mac') || userAgent.includes('macintosh') || userAgent.includes('darwin')) {, } else if (userAgent.includes('win')) { this.ribbonIcon.remove(); |
.setName('Custom ASCII Art') (sorry, did not paste in the link last time) |
ooh, that's what it was :). my bad, i didn't recognized it either. corrected it now. thank you, @joethei |
I am submitting a new Community Plugin
Repo URL
Link to my plugin: https://github.com/tabibyte/obsifetch
Release Checklist
main.js
manifest.json
styles.css
(optional)v
)id
in mymanifest.json
matches theid
in thecommunity-plugins.json
file.I have given proper attribution to these other projects in my
README.md
.