From d8c88924bd0642a8989cda13b99f76c90971f1a7 Mon Sep 17 00:00:00 2001 From: Yannick Marcon Date: Sat, 25 Jan 2025 18:37:12 +0100 Subject: [PATCH] fix: rm tmp dir after file download --- .../src/main/java/org/obiba/opal/web/FilesResource.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/opal-core-ws/src/main/java/org/obiba/opal/web/FilesResource.java b/opal-core-ws/src/main/java/org/obiba/opal/web/FilesResource.java index cc99f225ea..2237a171c7 100644 --- a/opal-core-ws/src/main/java/org/obiba/opal/web/FilesResource.java +++ b/opal-core-ws/src/main/java/org/obiba/opal/web/FilesResource.java @@ -14,6 +14,7 @@ import com.google.common.collect.Lists; import jakarta.annotation.Nullable; import jakarta.ws.rs.core.*; +import org.apache.commons.io.FileUtils; import org.apache.commons.io.FilenameUtils; import org.apache.commons.vfs2.*; import org.apache.shiro.SecurityUtils; @@ -605,7 +606,7 @@ private Response getFile(FileObject file, String key) throws IOException { } Files.copy(output.toPath(), os); if (!Strings.isNullOrEmpty(key)) { - output.getParentFile().delete(); + FileUtils.deleteQuietly(output.getParentFile()); } }; @@ -638,7 +639,7 @@ private Response getFolder(FileObject folder, Collection children, Strin return true; }, new File(tmpDir, fileName), key); Files.copy(output.toPath(), os); - tmpDir.delete(); + FileUtils.deleteQuietly(tmpDir); }; return Response.ok(stream, mimeType)