Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --remote_log from exp_fns.sh #1074

Open
jeswan opened this issue Sep 17, 2020 · 2 comments
Open

Remove --remote_log from exp_fns.sh #1074

jeswan opened this issue Sep 17, 2020 · 2 comments

Comments

@jeswan
Copy link
Contributor

jeswan commented Sep 17, 2020

Issue by iftenney
Thursday Apr 16, 2020 at 18:58 GMT
Originally opened as nyu-mll/jiant#1074

Allow running these if not on GCP. The log should still be in a text file in the console.

If running on Kubernetes, this flag doesn't matter anyway since k8s does its own log management.

iftenney included the following code: https://github.com/nyu-mll/jiant/pull/1074/commits
@jeswan
Copy link
Contributor Author

jeswan commented Sep 17, 2020

Comment by sleepinyourhat
Thursday Apr 16, 2020 at 19:04 GMT

LGTM. Approving as edge probing-specific.

@jeswan
Copy link
Contributor Author

jeswan commented Sep 17, 2020

Comment by jeswan
Thursday Sep 17, 2020 at 16:09 GMT

Are these changes still necessary? Planning to close all PRs to move jiant2 to this repo in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeswan