chore: use new nw download functions

Author: ayushmanchhabra

src/get.js

@@ -5,7 +5,8 @@ import path from "node:path";
 import progress from "cli-progress";
 import tar from "tar";
 
-import { unzip } from "./get/decompress.js";
+import decompress, { unzip } from "./get/decompress.js";
+import nw from "./get/nw.js";
 
 import util from "./util.js";
 
@@ -31,129 +32,50 @@ import util from "./util.js";
  * @return {Promise<void>}
  */
 async function get(options) {
-  if (fs.existsSync(options.cacheDir) === false) {
+
+  const cacheDirExists = await util.fileExists(options.cacheDir);
+  if (cacheDirExists === false) {
     await fs.promises.mkdir(options.cacheDir, { recursive: true });
   }
-  await getNwjs(options);
-  if (options.ffmpeg === true) {
-    await getFfmpeg(options);
-  }
-  if (options.nativeAddon === "gyp") {
-    await getNodeHeaders(options);
-  }
-}
 
-const getNwjs = async (options) => {
-  const bar = new progress.SingleBar({}, progress.Presets.rect);
-  const out = path.resolve(
+  let nwFilePath = path.resolve(
     options.cacheDir,
     `nwjs${options.flavor === "sdk" ? "-sdk" : ""}-v${options.version}-${options.platform}-${options.arch}.${options.platform === "linux" ? "tar.gz" : "zip"
     }`,
   );
-  // If options.cache is false, remove cache.
+
+  let nwDirPath = path.resolve(
+    options.cacheDir,
+    `nwjs${options.flavor === "sdk" ? "-sdk" : ""}-v${options.version}-${options.platform}-${options.arch}`,
+  );
+
   if (options.cache === false) {
-    await fs.promises.rm(out, {
+    await fs.promises.rm(nwFilePath, {
       recursive: true,
       force: true,
     });
   }
 
-  if (fs.existsSync(out) === true) {
-    await fs.promises.rm(
-      path.resolve(
-        options.cacheDir,
-        `nwjs${options.flavor === "sdk" ? "-sdk" : ""}-v${options.version}-${options.platform}-${options.arch}`,
-      ),
-      { recursive: true, force: true },
-    );
-    if (options.platform === "linux") {
-      await tar.extract({
-        file: out,
-        C: options.cacheDir
-      });
-    } else {
-      await unzip(out, options.cacheDir);
-      if (options.platform === "osx") {
-        await createSymlinks(options);
-      }
-    }
-    return;
+  if (util.fileExists(nwFilePath)) {
+    nwFilePath = await nw(options.downloadUrl, options.version, options.flavor, options.platform, options.arch, options.cacheDir);
   }
 
-  const stream = fs.createWriteStream(out);
-  const request = new Promise((res, rej) => {
-    let url = "";
-
-    // Set download url and destination.
-    if (
-      options.downloadUrl === "https://dl.nwjs.io" ||
-      options.downloadUrl === "https://npm.taobao.org/mirrors/nwjs" ||
-      options.downloadUrl === "https://npmmirror.com/mirrors/nwjs"
-    ) {
-      url = `${options.downloadUrl}/v${options.version}/nwjs${options.flavor === "sdk" ? "-sdk" : ""
-      }-v${options.version}-${options.platform}-${options.arch}.${options.platform === "linux" ? "tar.gz" : "zip"
-      }`;
-    }
+  await fs.promises.rm(nwDirPath, { recursive: true, force: true });
 
-    https.get(url, (response) => {
-      // For GitHub releases and mirrors, we need to follow the redirect.
-      if (
-        options.downloadUrl === "https://npm.taobao.org/mirrors/nwjs" ||
-        options.downloadUrl === "https://npmmirror.com/mirrors/nwjs"
-      ) {
-        url = response.headers.location;
-      }
+  await decompress(nwFilePath, options.cacheDir);
 
-      https.get(url, (response) => {
-        let chunks = 0;
-        bar.start(Number(response.headers["content-length"]), 0);
-        response.on("data", (chunk) => {
-          chunks += chunk.length;
-          bar.increment();
-          bar.update(chunks);
-        });
-
-        response.on("error", (error) => {
-          rej(error);
-        });
-
-        response.on("end", () => {
-          bar.stop();
-          res();
-        });
-
-        response.pipe(stream);
-      });
-
-      response.on("error", (error) => {
-        rej(error);
-      });
-    });
-  });
-
-  await request;
-  await fs.promises.rm(
-    path.resolve(
-      options.cacheDir,
-      `nwjs${options.flavor === "sdk" ? "-sdk" : ""}-v${options.version}-${options.platform}-${options.arch}`,
-    ),
-    { recursive: true, force: true },
-  );
-  if (options.platform === "linux") {
-    await tar.extract({
-      file: out,
-      C: options.cacheDir
-    });
-  } else {
-    await unzip(out, options.cacheDir);
-    if (options.platform === "osx") {
-      await createSymlinks(options);
-    }
+  if (options.platform === "osx") {
+    await createSymlinks(options);
+  }
 
+  if (options.ffmpeg === true) {
+    await getFfmpeg(options);
+  }
+  if (options.nativeAddon === "gyp") {
+    await getNodeHeaders(options);
   }
 }
 
-
 const getFfmpeg = async (options) => {
   const nwDir = path.resolve(
     options.cacheDir,

src/util.js

@@ -219,7 +219,7 @@ async function getNodeManifest({
 }
 
 /**
- * Parse options
+ * Parse options.
  *
  * @param  {import("../../index.js").Options} options  Options
  * @param  {object}                           pkg      Package.json as JSON

test/specs/get.test.js

@@ -7,7 +7,7 @@ import { beforeAll, describe, it } from "vitest";
 
 import get from '../../src/get.js';
 
-describe.skip("get", async () => {
+describe("get", async () => {
   const nwOptions = {
     version: "0.83.0",
     flavor: "sdk",