Skip to content

Commit 1cac5fa

Browse files
committed
Look for python3 first on MacOS, not py
`py` is not installed by default *and* trying to run it results in a popup asking if you want to install it. `python3` is installed by default. This hopefully should not be too disruptive to people on Windows, since they should be going through `x.ps1` instead anyway. Just in case, I've added a check for Cygwin and Msys (i'm not sure how else you'd get a bash shell on windows).
1 parent 4a43094 commit 1cac5fa

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

x

+7-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,13 @@ xpy=$(dirname "$(realpath "$0")")/x.py
2525

2626
# On Windows, `py -3` sometimes works. We need to try it first because `python3`
2727
# sometimes tries to launch the app store on Windows.
28-
for SEARCH_PYTHON in py python3 python python2; do
28+
# On MacOS, `py` tries to install "Developer command line tools". Try `python3` first.
29+
# NOTE: running `bash -c ./x` from Windows doesn't set OSTYPE.
30+
case ${OSTYPE:-} in
31+
cygwin*|msys*) SEARCH="py python3 python python2";;
32+
*) SEARCH="python3 python py python2";;
33+
esac
34+
for SEARCH_PYTHON in $SEARCH; do
2935
if python=$(command -v $SEARCH_PYTHON) && [ -x "$python" ]; then
3036
if [ $SEARCH_PYTHON = py ]; then
3137
extra_arg="-3"

0 commit comments

Comments
 (0)