Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Move rockspec/src.rock downloading logic to RemotePackage impl #287

Open
mrcjkb opened this issue Dec 29, 2024 · 3 comments
Open
Labels

Comments

@mrcjkb
Copy link
Member

mrcjkb commented Dec 29, 2024

...since we may want to support other servers than luarocks.
None of it should be exposed by rocks-lib.

We might want to move RemotePackage to its own module.

@mrcjkb mrcjkb added good first issue Good for newcomers refactor labels Dec 29, 2024
@vhyrro
Copy link
Contributor

vhyrro commented Dec 29, 2024

With #285, maybe we should let RemotePackageDB implement various aspects like this? I'm thinking of some trait that one could implement for downloading, querying etc. Then the RemotePackageDB would operate on this trait.

@mrcjkb
Copy link
Member Author

mrcjkb commented Dec 29, 2024

Sounds good to me. I think it's just a question of moving the logic in the operations::download module to the RemotePackageDB impl.
We might not even have to expose RemotePackage.

@vhyrro
Copy link
Contributor

vhyrro commented Dec 29, 2024

That's a good point, library consumers will only really need LocalPackages and PackageReqs for daily use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants