Skip to content

Commit 86aa9ff

Browse files
author
Teranode
committed
Revert back to vuetify instance creation
https://github.com/vuetifyjs/vuetify/releases/tag/v3.1.6 - This should solve the issue with the memory leak, so now reverting back to using vuetify's createVuetify instance
1 parent b1c27c6 commit 86aa9ff

File tree

4 files changed

+13
-10
lines changed

4 files changed

+13
-10
lines changed

README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,4 +70,6 @@ There is a bug with vuetify where custom scss files might not function correctly
7070

7171
#### 2. Theme values not applying & memory leak (Source: https://github.com/vuetifyjs/vuetify/issues/16156)
7272

73-
There's currently a bug with vueuse/head where it's potentially causing a memory leak and also not adapting changes when using the `useTheme` composable. For now, I have made a workaround where the module will be running its own `createVuetify` instance inheriting from vueitfy and making the necissary changes to make it function. Until this is fixed thta will be used instead.
73+
~~There's currently a bug with vueuse/head where it's potentially causing a memory leak and also not adapting changes when using the `useTheme` composable. For now, I have made a workaround where the module will be running its own `createVuetify` instance inheriting from vueitfy and making the necissary changes to make it function. Until this is fixed thta will be used instead.~~
74+
75+
This should have been fixed in vueitfy's `3.1.6` version.

package.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@nuxt-alt/vuetify",
3-
"version": "1.1.0",
3+
"version": "1.1.1",
44
"description": "An alternative module for setting up Vuetify 3 with nuxt.",
55
"homepage": "https://github.com/nuxt-alt/vuetify",
66
"author": "Teranode",
@@ -27,14 +27,14 @@
2727
"dev:prepare": "unbuild --stub && nuxi prepare playground"
2828
},
2929
"dependencies": {
30-
"@nuxt/kit": "^3.1.1",
31-
"sass": "^1.58.0",
30+
"@nuxt/kit": "^3.2.2",
31+
"sass": "^1.58.3",
3232
"vite-plugin-vuetify": "^1.0.2",
33-
"vuetify": "^3.0.5"
33+
"vuetify": "^3.1.6"
3434
},
3535
"devDependencies": {
36-
"@types/node": "^18.11.18",
37-
"nuxt": "^3.1.1",
36+
"@types/node": "^18.14.1",
37+
"nuxt": "^3.2.2",
3838
"unbuild": "latest"
3939
},
4040
"repository": {

src/module.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,11 +73,12 @@ export default defineNuxtModule({
7373
})
7474

7575
// Runtime
76-
nuxt.options.alias['#vuetify'] = resolve('./runtime/vuetify');
76+
// Todo: Remove in next build and it's remnants
77+
//nuxt.options.alias['#vuetify'] = resolve('./runtime/vuetify');
7778

7879
// vuetify-specific composables
7980
addImports([
80-
{ from: resolve('./runtime/theme'), name: 'useTheme' },
81+
{ from: CONFIG_KEY, name: 'useTheme' },
8182
{ from: CONFIG_KEY, name: 'useDisplay' },
8283
{ from: CONFIG_KEY, name: 'useRtl' },
8384
{ from: CONFIG_KEY, name: 'useLocale' },

src/runtime/templates/plugin.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { defineNuxtPlugin } from '#imports';
2-
import { createVuetify } from '#vuetify';
2+
import { createVuetify } from 'vuetify';
33

44
const opts = JSON.parse('<%= JSON.stringify(options) %>')
55

0 commit comments

Comments
 (0)